[{"id":4860,"web_url":"https://patchwork.libcamera.org/comment/4860/","msgid":"<20200519142933.GM470768@oden.dyn.berto.se>","date":"2020-05-19T14:29:33","subject":"Re: [libcamera-devel] [PATCH 2/8] cam: Add FrameSink base class","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-05-19 06:24:59 +0300, Laurent Pinchart wrote:\n> The FrameSink class serves as a base to implement components that\n> consume frames. This allows handling frame sinks in a generic way,\n> independent of their nature. The BufferWrite class will be ported to\n> FrameSink in a second step.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/cam/frame_sink.cpp | 31 +++++++++++++++++++++++++++++++\n> src/cam/frame_sink.h | 35 +++++++++++++++++++++++++++++++++++\n> src/cam/meson.build | 1 +\n> 3 files changed, 67 insertions(+)\n> create mode 100644 src/cam/frame_sink.cpp\n> create mode 100644 src/cam/frame_sink.h\n> \n> diff --git a/src/cam/frame_sink.cpp b/src/cam/frame_sink.cpp\n> new file mode 100644\n> index 000000000000..fbe16e2f5081\n> --- /dev/null\n> +++ b/src/cam/frame_sink.cpp\n> @@ -0,0 +1,31 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2020, Ideas on Board Oy\n> + *\n> + * frame_sink.cpp - Base Frame Sink Class\n> + */\n> +\n> +#include \"frame_sink.h\"\n> +\n> +FrameSink::~FrameSink()\n> +{\n> +}\n> +\n> +int FrameSink::configure(const libcamera::CameraConfiguration &config)\n> +{\n> +\treturn 0;\n> +}\n> +\n> +void FrameSink::mapBuffer(libcamera::FrameBuffer *buffer)\n> +{\n> +}\n> +\n> +int FrameSink::start()\n> +{\n> +\treturn 0;\n> +}\n> +\n> +int FrameSink::stop()\n> +{\n> +\treturn 0;\n> +}\n> diff --git a/src/cam/frame_sink.h b/src/cam/frame_sink.h\n> new file mode 100644\n> index 000000000000..39604a07eb70\n> --- /dev/null\n> +++ b/src/cam/frame_sink.h\n> @@ -0,0 +1,35 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2020, Ideas on Board Oy\n> + *\n> + * frame_sink.h - Base Frame Sink Class\n> + */\n> +#ifndef __CAM_FRAME_SINK_H__\n> +#define __CAM_FRAME_SINK_H__\n> +\n> +#include \n> +\n> +namespace libcamera {\n> +class CameraConfiguration;\n> +class FrameBuffer;\n> +class Stream;\n> +} /* namespace libcamera */\n> +\n> +class FrameSink\n> +{\n> +public:\n> +\tvirtual ~FrameSink();\n> +\n> +\tvirtual int configure(const libcamera::CameraConfiguration &config);\n> +\n> +\tvirtual void mapBuffer(libcamera::FrameBuffer *buffer);\n> +\n> +\tvirtual int start();\n> +\tvirtual int stop();\n> +\n> +\tvirtual bool consumeBuffer(const libcamera::Stream *stream,\n> +\t\t\t\t libcamera::FrameBuffer *buffer) = 0;\n> +\tlibcamera::Signal bufferReleased;\n> +};\n> +\n> +#endif /* __CAM_FRAME_SINK_H__ */\n> diff --git a/src/cam/meson.build b/src/cam/meson.build\n> index 89e124fbae2a..d7b72ec02f8c 100644\n> --- a/src/cam/meson.build\n> +++ b/src/cam/meson.build\n> @@ -4,6 +4,7 @@ cam_sources = files([\n> 'buffer_writer.cpp',\n> 'capture.cpp',\n> 'event_loop.cpp',\n> + 'frame_sink.cpp',\n> 'main.cpp',\n> 'options.cpp',\n> 'stream_options.cpp',\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90933603D9\n\tfor ;\n\tTue, 19 May 2020 16:29:35 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id b6so13971570ljj.1\n\tfor ;\n\tTue, 19 May 2020 07:29:35 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tb2sm9064533lfi.14.2020.05.19.07.29.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 19 May 2020 07:29:33 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"bcF4Ad+d\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=SIhIpI4GUqyqxDDmE6yfhXHBzztiBFIwwF38312Ulb4=;\n\tb=bcF4Ad+d9jt1sTgeze50wivNS8QyUSgb0kwcCOtpYuYG4Tyw3EUMFNakelfTu8IogY\n\tpflkbgW2bZJrteSANd3G3U77AwYpC0KbAslrE9heVY6wAUi82kkvjadljBTN+5FzuHdo\n\t3qGABCwJXEiKb9mBMqu8jh1DqwCrQevOXoc1j7suPlhg8mepTFB16i8UVsb4uHznepWZ\n\tewPlF5CBw6RgEbgVRG4ziG532wA0r0QLV1s8fT83I0h/FNw8gtF65q6iuExJY2YObRy4\n\tCaksqS5mSQpKSXxF+lpQCU6jdIlGmgz9YyqYgWSl6kmY25V5OAywIQvAVjlbdvmwjcE3\n\tyxKA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=SIhIpI4GUqyqxDDmE6yfhXHBzztiBFIwwF38312Ulb4=;\n\tb=gcuqKBBNSj+6+aj3ANokgmsWBuaLvlyTSJVeSWMtRkcmYBulf+4mGjYYDz4YogQrVT\n\tcoi2gsv+1BXgFkKgI7/jXP3uBdUa5s9L6tKA9XB+1DeUYr0BwKmgXS5Nq5GgInW4U0rd\n\ttGsHtz5EwKCEjzJ1inO/nJKiAT2s7Dlp/xHOfWTSf3jh2udccoRKc5mpqvDmepQuaHA8\n\tug0Z3EKJVveReSUJmY1YhuO4gMTjl/We6iYIm0EnZ+B/2+s3bGARl1RDzhbf01/sxz2a\n\tH6SMew8PklGP0zxlcg8tw6zCU+7vKqmif51UPnJKglBW0NoX4cMqN/rimnL6Wqt8w4Bc\n\tDPBw==","X-Gm-Message-State":"AOAM5300Fc3RvCXTskQu/lRMOAyev2jqR6zv+o/8py1+pzcUsXCpk9LF\n\tS6C+AgMR6OfN3gzPimmwl+RspA==","X-Google-Smtp-Source":"ABdhPJySl3gAPjVQ6r8sojBBQQGOZiaIjIFjZbKDGulveDiIgRl6fX3fNDpb0jg5XroIbPkyRSGJVg==","X-Received":"by 2002:a2e:7a12:: with SMTP id\n\tv18mr13290168ljc.74.1589898574601; \n\tTue, 19 May 2020 07:29:34 -0700 (PDT)","Date":"Tue, 19 May 2020 16:29:33 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200519142933.GM470768@oden.dyn.berto.se>","References":"<20200519032505.17307-1-laurent.pinchart@ideasonboard.com>\n\t<20200519032505.17307-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200519032505.17307-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/8] cam: Add FrameSink base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 19 May 2020 14:29:35 -0000"}}]