[{"id":4844,"web_url":"https://patchwork.libcamera.org/comment/4844/","msgid":"<0421dcaf2a76237920d2513d41a2403dd96d1ca6.camel@uajain.com>","date":"2020-05-19T08:36:24","subject":"Re: [libcamera-devel] [PATCH] libcamera: geometry: Set steps to 0\n\tin default SizeRange constructor","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Laurent,\n\nOn Tue, 2020-05-19 at 06:04 +0300, Laurent Pinchart wrote:\n> The default SizeRange constructor initializes the min and max\n> members,\n> but leaves the hStep and vStep members uninitialized. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/geometry.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/geometry.h\n> b/include/libcamera/geometry.h\n> index 2d364891858c..edda42cf34cc 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -71,6 +71,7 @@ class SizeRange\n> {\n> public:\n> \tSizeRange()\n> +\t\t: hStep(0), vStep(0)\n> \t{\n> \t}\n> \n\nThis makes sense.\nReviewed-by: Umang Jain ","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 511BB603D8\n\tfor ;\n\tTue, 19 May 2020 10:36:26 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-cq957 with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-cq957-19-5EC39A88-29\n\t2020-05-19 08:36:24.624617133 +0000 UTC m=+4692534.772423934","from mail.uajain.com (unknown)\n\tby ismtpd0002p1maa1.sendgrid.net (SG) with ESMTP\n\tid 3FtBhITeR42x3EwqI3alSQ Tue, 19 May 2020 08:36:24.205 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"suTX2zYc\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:from:in-reply-to:references:content-type:mime-version:to:\n\tcontent-transfer-encoding;\n\ts=s1; bh=yrATZhVLenGfHpCgDW5jZ8I7VSM8yJjg4Nbel/EjDxw=;\n\tb=suTX2zYcgJ7qnQdHTelWrHsmhPunN4XhBXaNTjsllCpnqZmcvOpbYDjp1PRMOH/QxzaZ\n\tnUBe80Mu18xZKaj1v5GqDv3oPJX7UmdEQAxyhwS3xEQsKzdX3Mf6nCK4JqvzTS00BDDWgO\n\th9VC3K2/lz+oQrBqjw8Kdq1arLuadp/1s=","Message-ID":"<0421dcaf2a76237920d2513d41a2403dd96d1ca6.camel@uajain.com>","From":"Umang Jain ","Date":"Tue, 19 May 2020 08:36:24 +0000 (UTC)","In-Reply-To":"<20200519030445.15912-1-laurent.pinchart@ideasonboard.com>","References":"<20200519030445.15912-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=us-ascii","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcROc560Os82e1tQwAlD2FoC3Y5fElKMjRqiLn0ahEns6zGyfHXjL7LbMoFe7pfgUlc+ENwcAlCKyFtQiC0x7EFxgVMrsZFqgcFXZT1pQVsmc3rzxkmOsi6/Lm2yfWoSVdU4Y+C9vwY3xkoUb8B4FtnGBJYEAUDHmISYD9ARBo471PGgGS95dtapDfAI6eGLjRR/iesqdX4guZbFzjWjMOUw==","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: geometry: Set steps to 0\n\tin default SizeRange constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 19 May 2020 08:36:27 -0000"}},{"id":4856,"web_url":"https://patchwork.libcamera.org/comment/4856/","msgid":"<20200519140605.GK470768@oden.dyn.berto.se>","date":"2020-05-19T14:06:05","subject":"Re: [libcamera-devel] [PATCH] libcamera: geometry: Set steps to 0\n\tin default SizeRange constructor","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-05-19 06:04:45 +0300, Laurent Pinchart wrote:\n> The default SizeRange constructor initializes the min and max members,\n> but leaves the hStep and vStep members uninitialized. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/geometry.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index 2d364891858c..edda42cf34cc 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -71,6 +71,7 @@ class SizeRange\n> {\n> public:\n> \tSizeRange()\n> +\t\t: hStep(0), vStep(0)\n> \t{\n> \t}\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7769603D9\n\tfor ;\n\tTue, 19 May 2020 16:06:07 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id o14so13885255ljp.4\n\tfor ;\n\tTue, 19 May 2020 07:06:07 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\th2sm8543098ljb.45.2020.05.19.07.06.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 19 May 2020 07:06:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"tLbWDlGB\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=lZ7+FjDQObBo78Wis0LSskF8e+m1VHtuA0ng6PC81GA=;\n\tb=tLbWDlGBM4LahWLOTN04zQ7LwF5Q0XUgLbG0AQ9Sdj/03QVawdP7Ifh8n9zoR/5xd8\n\tKo6tEv5h4SQAyfZiUlqJSP7pGR0Mt5K49Z8IvZdJJzLmPxWSf8Ywqj+nNKXyQiQlvU6t\n\toQbOOUCo5AnIBaeabiUzziBCzbWNTj4ysfvDOZt5mukvInVvhs0YCydyEtOUesvIHFn1\n\tVlIRvSKHc63iqpbmbme9vCENXoLku6phDi6Hof+cS/Pd59Md6O0jZYfdlQpAN7WdR7kH\n\t48oMPqUjsCMfQ8s7spRnoSxAsh2NVHsE9mRHKfPBw+hK48B7R+p02ylf3JIvZDXPi8ex\n\t+b3Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=lZ7+FjDQObBo78Wis0LSskF8e+m1VHtuA0ng6PC81GA=;\n\tb=h0rENAeE5n1dir97g1a3NziBJQy2lFOI0QEWgYzKiMFcnYDHPDrG8i348O3QgpxNEG\n\tbuGkHqXRTIRPU+rb2o2Y7yJ1QrjeYQi745wfJkbG+3u2raRGjybA85aUIIhME5wHDBfv\n\t13xxS94UmNNtjQiQJQsecKr0SVlwCnU3Puxfh2uIb5LGRWfZ6Z3dYxivHr598iDy8bq/\n\tUx3TperYgl6LW9mqdYFV1ppcok6yTmm6CNNFd3iCUmjgH4tdgl+zFifsvbiLH6z4B0jU\n\tD8jv8h5aFUArMid0/1gANiXv6vorv1ixqx8mQsx/Zcoct9clKqxGf70QDEX+k0JENqnc\n\tCeOQ==","X-Gm-Message-State":"AOAM531qBWnHgrDYpzKocewaEmnErCX+0a1/1JLecxJFr1MN5IOQd60M\n\thCkGELcKGiRb1sjH2tShvD3SeJfVueyY7A==","X-Google-Smtp-Source":"ABdhPJyPKpLIyMTOzEy1YLoDP3a2DokKkgCbNKg9bF1lDoIui+Ae7B5WY4Jr+2x9os8dEGeFegzE3w==","X-Received":"by 2002:a2e:7c03:: with SMTP id x3mr4832780ljc.113.1589897167280;\n\tTue, 19 May 2020 07:06:07 -0700 (PDT)","Date":"Tue, 19 May 2020 16:06:05 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200519140605.GK470768@oden.dyn.berto.se>","References":"<20200519030445.15912-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200519030445.15912-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: geometry: Set steps to 0\n\tin default SizeRange constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 19 May 2020 14:06:08 -0000"}}]