[{"id":4834,"web_url":"https://patchwork.libcamera.org/comment/4834/","msgid":"<646a1ccb-e207-26ea-ef76-e528319b2409@ideasonboard.com>","date":"2020-05-18T11:08:34","subject":"Re: [libcamera-devel] [PATCH v2] (q)cam: Fix header guards","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 18/05/2020 11:51, Laurent Pinchart wrote:\n> Several headers part of cam and qcam use __LIBCAMERA_*_H__ as a header\n\ns/headers part/headers form part/ ?\n\n> guard. They're not part of the libcamera core, use __CAM_*_H__ and\n> __QCAM_*_H__ instead, similarly to all other headers of cam and qcam.\n> \n\nWith this commit message fixed up a little:\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/buffer_writer.h | 6 +++---\n> src/qcam/dng_writer.h | 6 +++---\n> 2 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/cam/buffer_writer.h b/src/cam/buffer_writer.h\n> index 8c9b2436fdae..47e26103e13e 100644\n> --- a/src/cam/buffer_writer.h\n> +++ b/src/cam/buffer_writer.h\n> @@ -4,8 +4,8 @@\n> *\n> * buffer_writer.h - Buffer writer\n> */\n> -#ifndef __LIBCAMERA_BUFFER_WRITER_H__\n> -#define __LIBCAMERA_BUFFER_WRITER_H__\n> +#ifndef __CAM_BUFFER_WRITER_H__\n> +#define __CAM_BUFFER_WRITER_H__\n> \n> #include \n> #include \n> @@ -28,4 +28,4 @@ private:\n> \tstd::map> mappedBuffers_;\n> };\n> \n> -#endif /* __LIBCAMERA_BUFFER_WRITER_H__ */\n> +#endif /* __CAM_BUFFER_WRITER_H__ */\n> diff --git a/src/qcam/dng_writer.h b/src/qcam/dng_writer.h\n> index d74d73d06a14..bf44c879aff7 100644\n> --- a/src/qcam/dng_writer.h\n> +++ b/src/qcam/dng_writer.h\n> @@ -4,8 +4,8 @@\n> *\n> * dng_writer.h - DNG writer\n> */\n> -#ifndef __LIBCAMERA_DNG_WRITER_H__\n> -#define __LIBCAMERA_DNG_WRITER_H__\n> +#ifndef __QCAM_DNG_WRITER_H__\n> +#define __QCAM_DNG_WRITER_H__\n> \n> #ifdef HAVE_TIFF\n> #define HAVE_DNG\n> @@ -28,4 +28,4 @@ public:\n> \n> #endif /* HAVE_TIFF */\n> \n> -#endif /* __LIBCAMERA_DNG_WRITER_H__ */\n> +#endif /* __QCAM_DNG_WRITER_H__ */\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83F9B603DB\n\tfor ;\n\tMon, 18 May 2020 13:08:41 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F28F3258;\n\tMon, 18 May 2020 13:08:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cFUkrBIz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589800120;\n\tbh=bT2wXX1fjp6xfrPalWOgRFIEWxxFr+OpLoQQJ51PvxQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=cFUkrBIzjxfXt2Evf5PUf4Na2fb9wqmts9U+lI8EUMr5ntBcg/gFXC5L6ciOZ7XxN\n\tUW3/NvDPboI8MEUpqRJRy18Mg+ZWhM676lKycNvL3NLzr0X78+1x0ncl2k6+6bVqNU\n\tST1BswkIDJx8+7s0K3EpWeeJyzUDiiKN6XucVyWA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200518105129.9867-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<646a1ccb-e207-26ea-ef76-e528319b2409@ideasonboard.com>","Date":"Mon, 18 May 2020 12:08:34 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200518105129.9867-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2] (q)cam: Fix header guards","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 May 2020 11:08:41 -0000"}},{"id":4836,"web_url":"https://patchwork.libcamera.org/comment/4836/","msgid":"<20200518114206.GB5851@pendragon.ideasonboard.com>","date":"2020-05-18T11:42:06","subject":"Re: [libcamera-devel] [PATCH v2] (q)cam: Fix header guards","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, May 18, 2020 at 12:08:34PM +0100, Kieran Bingham wrote:\n> On 18/05/2020 11:51, Laurent Pinchart wrote:\n> > Several headers part of cam and qcam use __LIBCAMERA_*_H__ as a header\n> \n> s/headers part/headers form part/ ?\n\nI meant \"several headers [that are] part of ...\". Is that incorrect\ngrammar ?\n\n> > guard. They're not part of the libcamera core, use __CAM_*_H__ and\n> > __QCAM_*_H__ instead, similarly to all other headers of cam and qcam.\n> \n> With this commit message fixed up a little:\n> \n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/cam/buffer_writer.h | 6 +++---\n> > src/qcam/dng_writer.h | 6 +++---\n> > 2 files changed, 6 insertions(+), 6 deletions(-)\n> > \n> > diff --git a/src/cam/buffer_writer.h b/src/cam/buffer_writer.h\n> > index 8c9b2436fdae..47e26103e13e 100644\n> > --- a/src/cam/buffer_writer.h\n> > +++ b/src/cam/buffer_writer.h\n> > @@ -4,8 +4,8 @@\n> > *\n> > * buffer_writer.h - Buffer writer\n> > */\n> > -#ifndef __LIBCAMERA_BUFFER_WRITER_H__\n> > -#define __LIBCAMERA_BUFFER_WRITER_H__\n> > +#ifndef __CAM_BUFFER_WRITER_H__\n> > +#define __CAM_BUFFER_WRITER_H__\n> > \n> > #include \n> > #include \n> > @@ -28,4 +28,4 @@ private:\n> > \tstd::map> mappedBuffers_;\n> > };\n> > \n> > -#endif /* __LIBCAMERA_BUFFER_WRITER_H__ */\n> > +#endif /* __CAM_BUFFER_WRITER_H__ */\n> > diff --git a/src/qcam/dng_writer.h b/src/qcam/dng_writer.h\n> > index d74d73d06a14..bf44c879aff7 100644\n> > --- a/src/qcam/dng_writer.h\n> > +++ b/src/qcam/dng_writer.h\n> > @@ -4,8 +4,8 @@\n> > *\n> > * dng_writer.h - DNG writer\n> > */\n> > -#ifndef __LIBCAMERA_DNG_WRITER_H__\n> > -#define __LIBCAMERA_DNG_WRITER_H__\n> > +#ifndef __QCAM_DNG_WRITER_H__\n> > +#define __QCAM_DNG_WRITER_H__\n> > \n> > #ifdef HAVE_TIFF\n> > #define HAVE_DNG\n> > @@ -28,4 +28,4 @@ public:\n> > \n> > #endif /* HAVE_TIFF */\n> > \n> > -#endif /* __LIBCAMERA_DNG_WRITER_H__ */\n> > +#endif /* __QCAM_DNG_WRITER_H__ */\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BEF7603DA\n\tfor ;\n\tMon, 18 May 2020 13:42:15 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB17D258;\n\tMon, 18 May 2020 13:42:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"X9+Xqlm5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589802135;\n\tbh=oMtMlZf9Cwt7L8KF5PQslTCsVyt3wyq8w6AC04+3chg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=X9+Xqlm51hOesQg88r6us5LE6gUS9UNCeT1JuYtYT7zTxBa9+53mnhO/epjWUskX0\n\tfOyxYAPYu8t7ql9yEN1VLFgx4FUhGDld2/kOeGm6qmt4q4neKvat99A4Wm29oEK3vg\n\toGVBFAXjIh1QzQyCPSsymoJTFDonsgkbL6Za/2dY=","Date":"Mon, 18 May 2020 14:42:06 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200518114206.GB5851@pendragon.ideasonboard.com>","References":"<20200518105129.9867-1-laurent.pinchart@ideasonboard.com>\n\t<646a1ccb-e207-26ea-ef76-e528319b2409@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<646a1ccb-e207-26ea-ef76-e528319b2409@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] (q)cam: Fix header guards","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 May 2020 11:42:15 -0000"}},{"id":4837,"web_url":"https://patchwork.libcamera.org/comment/4837/","msgid":"","date":"2020-05-18T11:55:02","subject":"Re: [libcamera-devel] [PATCH v2] (q)cam: Fix header guards","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 18/05/2020 12:42, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Mon, May 18, 2020 at 12:08:34PM +0100, Kieran Bingham wrote:\n>> On 18/05/2020 11:51, Laurent Pinchart wrote:\n>>> Several headers part of cam and qcam use __LIBCAMERA_*_H__ as a header\n>>\n>> s/headers part/headers form part/ ?\n> \n> I meant \"several headers [that are] part of ...\". Is that incorrect\n> grammar ?\n\n\nAs written in $COMMIT ... no ;-)\n\nYou can add the \"that are a\" if you wish, but \"several headers part of\"\nis not valid.\n\n\n>>> guard. They're not part of the libcamera core, use __CAM_*_H__ and\n>>> __QCAM_*_H__ instead, similarly to all other headers of cam and qcam.\n>>\n>> With this commit message fixed up a little:\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n>>> Signed-off-by: Laurent Pinchart \n>>> ---\n>>> src/cam/buffer_writer.h | 6 +++---\n>>> src/qcam/dng_writer.h | 6 +++---\n>>> 2 files changed, 6 insertions(+), 6 deletions(-)\n>>>\n>>> diff --git a/src/cam/buffer_writer.h b/src/cam/buffer_writer.h\n>>> index 8c9b2436fdae..47e26103e13e 100644\n>>> --- a/src/cam/buffer_writer.h\n>>> +++ b/src/cam/buffer_writer.h\n>>> @@ -4,8 +4,8 @@\n>>> *\n>>> * buffer_writer.h - Buffer writer\n>>> */\n>>> -#ifndef __LIBCAMERA_BUFFER_WRITER_H__\n>>> -#define __LIBCAMERA_BUFFER_WRITER_H__\n>>> +#ifndef __CAM_BUFFER_WRITER_H__\n>>> +#define __CAM_BUFFER_WRITER_H__\n>>> \n>>> #include \n>>> #include \n>>> @@ -28,4 +28,4 @@ private:\n>>> \tstd::map> mappedBuffers_;\n>>> };\n>>> \n>>> -#endif /* __LIBCAMERA_BUFFER_WRITER_H__ */\n>>> +#endif /* __CAM_BUFFER_WRITER_H__ */\n>>> diff --git a/src/qcam/dng_writer.h b/src/qcam/dng_writer.h\n>>> index d74d73d06a14..bf44c879aff7 100644\n>>> --- a/src/qcam/dng_writer.h\n>>> +++ b/src/qcam/dng_writer.h\n>>> @@ -4,8 +4,8 @@\n>>> *\n>>> * dng_writer.h - DNG writer\n>>> */\n>>> -#ifndef __LIBCAMERA_DNG_WRITER_H__\n>>> -#define __LIBCAMERA_DNG_WRITER_H__\n>>> +#ifndef __QCAM_DNG_WRITER_H__\n>>> +#define __QCAM_DNG_WRITER_H__\n>>> \n>>> #ifdef HAVE_TIFF\n>>> #define HAVE_DNG\n>>> @@ -28,4 +28,4 @@ public:\n>>> \n>>> #endif /* HAVE_TIFF */\n>>> \n>>> -#endif /* __LIBCAMERA_DNG_WRITER_H__ */\n>>> +#endif /* __QCAM_DNG_WRITER_H__ */\n>>>\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFF04603DA\n\tfor ;\n\tMon, 18 May 2020 13:55:07 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DD332258;\n\tMon, 18 May 2020 13:55:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OyvvjulL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589802907;\n\tbh=wArza/2DsA7bL3BnoklUGjFvwn04VgRiXU4rnO2CmtI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=OyvvjulLmVQnyZaq1vnF0tcsXNQTDiiDR+aRiSliF7rVFj6c+D4r3BGTStqvJIKUi\n\tVG65uKFh+rTmW/ZSzOombSWfPMXenNi15vYC8OFAy1BR7pyQhZxnDw+1gXZn1/pK0j\n\t/7HV/T9nVfbQLXSLf0DPPx+FNRPnKRvdgoh54/go=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200518105129.9867-1-laurent.pinchart@ideasonboard.com>\n\t<646a1ccb-e207-26ea-ef76-e528319b2409@ideasonboard.com>\n\t<20200518114206.GB5851@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 18 May 2020 12:55:02 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200518114206.GB5851@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2] (q)cam: Fix header guards","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 May 2020 11:55:08 -0000"}}]