{"id":3797,"url":"https://patchwork.libcamera.org/api/patches/3797/?format=json","web_url":"https://patchwork.libcamera.org/patch/3797/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200515124245.18040-4-email@uajain.com>","date":"2020-05-15T12:42:53","name":"[libcamera-devel,v2,3/4] test: log: log_api: Close open fds on error paths","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a7742046f325e27c7fe2b0cdee8964a0864b027d","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3797/mbox/","series":[{"id":905,"url":"https://patchwork.libcamera.org/api/series/905/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=905","date":"2020-05-15T12:42:52","name":"Coverity scan fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/905/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3797/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3797/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E242660E0F\n\tfor ;\n\tFri, 15 May 2020 14:42:54 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-rpdh9 with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-rpdh9-19-5EBE8E4D-27\n\t2020-05-15 12:42:53.614076869 +0000 UTC m=+4361719.364516320","from mail.uajain.com (unknown)\n\tby ismtpd0001p1maa1.sendgrid.net (SG) with ESMTP id\n\t18xcdec4Roe1WdGokaodIw for ;\n\tFri, 15 May 2020 12:42:53.141 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"pPSl68t1\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=CVlZQdEZ+lTx2UvlTlFz67zvM7i8+MT+A3eEp0ALdvk=;\n\tb=pPSl68t12Pl2UVTXpa5V3sd3CvRKl6x0AjldSh3ihHnzWSmujfXcXevjeWC1NE/rGszM\n\t1b187QHO9+MVYWMU644Vkr7gf+gBuYENnHjlSBPVJn+ieih+ktNc085/dlFCk+fHSACYxP\n\twcLjae2l2aOz5xF/HXoqwHmxHcVVKXyvk=","From":"Umang Jain ","Date":"Fri, 15 May 2020 12:42:53 +0000 (UTC)","Message-Id":"<20200515124245.18040-4-email@uajain.com>","In-Reply-To":"<20200515124245.18040-1-email@uajain.com>","References":"<20200515124245.18040-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcumJKJCztqrDTQNOfbQrvHfzJz5+dA5iyzk1X2aMakKJMauHf+8y4XIeDLfzKNBlhddoPRNDlJ0oVmQujTCu53m4YZXT6mjH7M16lzr/OQK15oXrHX606tl2oKRXTDQvjsCB04mL8yfvEDI12ZRAxioaxqlDTyPQTIUQcmhmyB/Sb3z+kdFeGc35BQ+ViATXzvdiqI/o2FeMz94hQgrqICA==","To":"libcamera-devel ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH v2 3/4] test: log: log_api: Close open fds\n\ton error paths","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 15 May 2020 12:42:55 -0000"},"content":"Pointed out by Coverity DefectId=279091\n\nSigned-off-by: Umang Jain \n---\n test/log/log_api.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/test/log/log_api.cpp b/test/log/log_api.cpp\nindex 33622f8..4d2c8db 100644\n--- a/test/log/log_api.cpp\n+++ b/test/log/log_api.cpp\n@@ -86,6 +86,7 @@ protected:\n \n \t\tif (logSetFile(path) < 0) {\n \t\t\tcerr << \"Failed to set log file\" << endl;\n+\t\t\tclose(fd);\n \t\t\treturn TestFail;\n \t\t}\n \n@@ -96,6 +97,7 @@ protected:\n \t\tlseek(fd, 0, SEEK_SET);\n \t\tif (read(fd, buf, sizeof(buf)) < 0) {\n \t\t\tcerr << \"Failed to read tmp log file\" << endl;\n+\t\t\tclose(fd);\n \t\t\treturn TestFail;\n \t\t}\n \t\tclose(fd);\n","prefixes":["libcamera-devel","v2","3/4"]}