{"id":3795,"url":"https://patchwork.libcamera.org/api/patches/3795/?format=json","web_url":"https://patchwork.libcamera.org/patch/3795/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200515124245.18040-2-email@uajain.com>","date":"2020-05-15T12:42:52","name":"[libcamera-devel,v2,1/4] test: ipc: unixsocket: Close open fds on error paths","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a265df6225f0e386036420a0c212c554000a1dc9","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3795/mbox/","series":[{"id":905,"url":"https://patchwork.libcamera.org/api/series/905/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=905","date":"2020-05-15T12:42:52","name":"Coverity scan fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/905/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3795/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3795/checks/","tags":{},"headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0471860E04\n\tfor ;\n\tFri, 15 May 2020 14:42:53 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-7qsdm with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-7qsdm-19-5EBE8E4C-32\n\t2020-05-15 12:42:52.653305372 +0000 UTC m=+4361727.335562953","from mail.uajain.com (unknown)\n\tby ismtpd0007p1maa1.sendgrid.net (SG) with ESMTP\n\tid P5V8PnQwRdWqfWPesnwfjg Fri, 15 May 2020 12:42:52.051 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"eO84GZUU\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:\n\tcontent-transfer-encoding:content-type;\n\ts=s1; bh=nwEIAkapDHGcHhUqs9QsOYZYpbdReQVrJEj7JvJUIhQ=;\n\tb=eO84GZUUUx+BJofUTPUDgpix6bxrwwKX9/sOaAWB5lwwYvyxJ7AelY2ffLkQ2p13lky+\n\t4ueb43BmbFaJM26qZWs+2yKQBTvrXkooGemoZ6TE4EbHAuFnOmYbWjqfT3qVEe63gKVgtK\n\t80sOE+YNMlAba4G5KlJ17dFE+blcYFW8s=","From":"Umang Jain ","Date":"Fri, 15 May 2020 12:42:52 +0000 (UTC)","Message-Id":"<20200515124245.18040-2-email@uajain.com>","In-Reply-To":"<20200515124245.18040-1-email@uajain.com>","References":"<20200515124245.18040-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcYDswUgqLHty1lirORaEntVnOx/r7D4hv5S0oXe9vaj0hrpQTq3hRAmZeRvRAd4sctXteVeh8mmJPDovpQNo1MOQ9n1stXIdPkAQ+yhmSbZsuw2DGXM57HKiJ7Gh6Rh9dN71auyHh3JuIzPDLFwZZ1v41Yjatwylor5sLzLHpuHCcAB/qI1exfztX8MoFxxX52AEuLFXE/lnvn2b1Sqd1og==","To":"libcamera-devel ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH v2 1/4] test: ipc: unixsocket: Close open\n\tfds on error paths","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 15 May 2020 12:42:54 -0000"},"content":"Pointed out by Coverity DefectId=279099\n\nSigned-off-by: Umang Jain \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n test/ipc/unixsocket.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp\nindex f53042b..5348f35 100644\n--- a/test/ipc/unixsocket.cpp\n+++ b/test/ipc/unixsocket.cpp\n@@ -145,6 +145,7 @@ private:\n \n \t\t\t\t\tif (num < 0) {\n \t\t\t\t\t\tcerr << \"Read failed\" << endl;\n+\t\t\t\t\t\tclose(outfd);\n \t\t\t\t\t\tstop(-EIO);\n \t\t\t\t\t\treturn;\n \t\t\t\t\t} else if (!num)\n@@ -152,6 +153,7 @@ private:\n \n \t\t\t\t\tif (write(outfd, buf, num) < 0) {\n \t\t\t\t\t\tcerr << \"Write failed\" << endl;\n+\t\t\t\t\t\tclose(outfd);\n \t\t\t\t\t\tstop(-EIO);\n \t\t\t\t\t\treturn;\n \t\t\t\t\t}\n","prefixes":["libcamera-devel","v2","1/4"]}