[{"id":4840,"web_url":"https://patchwork.libcamera.org/comment/4840/","msgid":"<83c9ff96-336b-064a-cae6-093255720ccd@ideasonboard.com>","date":"2020-05-18T15:44:17","subject":"Re: [libcamera-devel] [PATCH v2 3/5] libcamera: camera_manager:\n\tIntroduce signals when a camera is added/removed","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 13/05/2020 18:29, Umang Jain wrote:\n> Emit 'cameraAdded' and 'cameraRemoved' from CameraManager to enable\n> hotplug and hot-unplug support in appplications like QCam.\n\ns/appplications/applications/\n\n\nHrm ... seeing cameraAdded and cameraRemoved, makes me think back to my\nearlier signal name bikeshedding ;-) Perhaps that one should be\ndeviceAdded and deviceRemoved (was newDevicesFound?)\n\nAnyway, let the bikeshedding happen on that patch instead ;-)\n\n> Signed-off-by: Umang Jain \n> ---\n> include/libcamera/camera_manager.h | 6 +++++-\n> src/libcamera/camera_manager.cpp | 34 +++++++++++++++++++++++++++---\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 3 files changed, 37 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\n> index 079f848..366fa07 100644\n> --- a/include/libcamera/camera_manager.h\n> +++ b/include/libcamera/camera_manager.h\n> @@ -13,6 +13,7 @@\n> #include \n> \n> #include \n> +#include \n> \n> namespace libcamera {\n> \n> @@ -35,13 +36,16 @@ public:\n> \tstd::shared_ptr get(dev_t devnum);\n> \n> \tvoid addCamera(std::shared_ptr camera, dev_t devnum);\n> -\tvoid removeCamera(Camera *camera);\n> +\tvoid removeCamera(std::shared_ptr camera);\n> \n> \tstatic const std::string &version() { return version_; }\n> \n> \tvoid setEventDispatcher(std::unique_ptr dispatcher);\n> \tEventDispatcher *eventDispatcher();\n> \n> +\tSignal> cameraAdded;\n> +\tSignal> cameraRemoved;\n> +\n> private:\n> \tstatic const std::string version_;\n> \tstatic CameraManager *self_;\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index a13cfe1..b9d2496 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -186,7 +186,7 @@ void CameraManager::Private::addCamera(std::shared_ptr &camera,\n> \t\t}\n> \t}\n> \n> -\tcameras_.push_back(std::move(camera));\n> +\tcameras_.push_back(camera);\n> \n> \tif (devnum) {\n> \t\tunsigned int index = cameras_.size() - 1;\n> @@ -376,6 +376,32 @@ std::shared_ptr CameraManager::get(dev_t devnum)\n> \treturn iter->second.lock();\n> }\n> \n> +/**\n> + * \\brief Notify of a new camera added to the system\n\nMissing the \\var to reference the signal.\n\n> + *\n> + * This signal is emitted when a new camera is detected and successfully handled\n> + * by the camera manager. The notification occurs alike for cameras detected\n> + * when the manager is started with start() or when new cameras are later\n> + * connected to the system. When the signal is emitted the new camera is already\n> + * available from the list of cameras().\n> + *\n> + * The signal is emitted from the CameraManager thread. Applications shall\n> + * minimize the time spent in the signal handler and shall in particular not\n> + * perform any blocking operation.\n> + */\n> +\n> +/**\n\nAnd missing here too.\n\n> + * \\brief Notify of a new camera removed from the system\n> + *\n> + * This signal is emitted when a camera is removed from the system. When the\n> + * signal is emitted the camera is not available from the list of cameras()\n> + * anymore.\n> + *\n> + * The signal is emitted from the CameraManager thread. Applications shall\n> + * minimize the time spent in the signal handler and shall in particular not\n> + * perform any blocking operation.\n> + */\n> +\n> /**\n> * \\brief Add a camera to the camera manager\n> * \\param[in] camera The camera to be added\n> @@ -395,6 +421,7 @@ void CameraManager::addCamera(std::shared_ptr camera, dev_t devnum)\n> \tASSERT(Thread::current() == p_.get());\n> \n> \tp_->addCamera(camera, devnum);\n> +\tcameraAdded.emit(camera);\n> }\n> \n> /**\n> @@ -407,11 +434,12 @@ void CameraManager::addCamera(std::shared_ptr camera, dev_t devnum)\n> *\n> * \\context This function shall be called from the CameraManager thread.\n> */\n> -void CameraManager::removeCamera(Camera *camera)\n> +void CameraManager::removeCamera(std::shared_ptr camera)\n> {\n> \tASSERT(Thread::current() == p_.get());\n> \n> -\tp_->removeCamera(camera);\n> +\tp_->removeCamera(camera.get());\n> +\tcameraRemoved.emit(camera);\n\nIs there any race here, or potential problem emitting the signal with\nthe camera, after it's been removed from the CameraManager? (I\nhope/expect not as it's using a shared_ptr ... But I haven't checked to\nsee if there are any implications caused by the removeCamera call)\n\n\n> }\n> \n> /**\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 254d341..a9187e1 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -555,7 +555,7 @@ void PipelineHandler::disconnect()\n> \t\t\tcontinue;\n> \n> \t\tcamera->disconnect();\n> -\t\tmanager_->removeCamera(camera.get());\n> +\t\tmanager_->removeCamera(camera);\n> \t}\n> \n> \tcameras_.clear();\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D838D603DA\n\tfor ;\n\tMon, 18 May 2020 17:44:21 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7CEDC258;\n\tMon, 18 May 2020 17:44:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wOmii1U5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589816661;\n\tbh=QbkjmTsSXeFqMR0RARCjEfcuqyq4iZbPlUydkTNtwZw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=wOmii1U5WEB0pNqKIzVH6hW1Ut4/wthwOFUNDmicMnY7lA4CohI6xUty599yDJv0J\n\td2twubKgD8rxEOuG4YtT0duWFUFWp2iTjoM2OTr9sJOfvvLUffM1ezWbtGJJ3XjMk2\n\tNnsbckrvOolUZnE1BvSHarkpIbVvOrB9KOa4nFuM=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Umang Jain ,\n\tlibcamera-devel ","References":"<20200513172950.72685-1-email@uajain.com>\n\t<20200513172950.72685-4-email@uajain.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<83c9ff96-336b-064a-cae6-093255720ccd@ideasonboard.com>","Date":"Mon, 18 May 2020 16:44:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200513172950.72685-4-email@uajain.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2 3/5] libcamera: camera_manager:\n\tIntroduce signals when a camera is added/removed","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 18 May 2020 15:44:22 -0000"}},{"id":4845,"web_url":"https://patchwork.libcamera.org/comment/4845/","msgid":"<5a09fdc0eff73cf4c2721d0864ebaaf7c0674ae2.camel@uajain.com>","date":"2020-05-19T08:53:49","subject":"Re: [libcamera-devel] [PATCH v2 3/5] libcamera: camera_manager:\n\tIntroduce signals when a camera is added/removed","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Kieran,\n\nOn Mon, 2020-05-18 at 16:44 +0100, Kieran Bingham wrote:\n> Hi Umang,\n> \n> On 13/05/2020 18:29, Umang Jain wrote:\n> > Emit 'cameraAdded' and 'cameraRemoved' from CameraManager to enable\n> > hotplug and hot-unplug support in appplications like QCam.\n> \n> s/appplications/applications/\n> \n> \n> Hrm ... seeing cameraAdded and cameraRemoved, makes me think back to\n> my\n> earlier signal name bikeshedding ;-) Perhaps that one should be\n> deviceAdded and deviceRemoved (was newDevicesFound?)\n> \n> Anyway, let the bikeshedding happen on that patch instead ;-)\n\nThe DeviceEnumerator::newDevicesFound is somewhat internal to libcamera\n(i.e. not meant to be used by applications - only by CameraManager).\n'cameraAdded' and 'cameraRemoved' are application facing signal-probes\nthat denote hotplugging. Maybe using 'newCameraAdded'\nand 'cameraRemoved' for CameraManager will make more things clear? \n\nAs far as DeviceEnumerator:newDevicesFound is concerned, I think:\ns/newDeviceFound/deviceAdded/ should do too.\n\n> \n> > Signed-off-by: Umang Jain \n> > ---\n> > include/libcamera/camera_manager.h | 6 +++++-\n> > src/libcamera/camera_manager.cpp | 34\n> > +++++++++++++++++++++++++++---\n> > src/libcamera/pipeline_handler.cpp | 2 +-\n> > 3 files changed, 37 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/include/libcamera/camera_manager.h\n> > b/include/libcamera/camera_manager.h\n> > index 079f848..366fa07 100644\n> > --- a/include/libcamera/camera_manager.h\n> > +++ b/include/libcamera/camera_manager.h\n> > @@ -13,6 +13,7 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > \n> > namespace libcamera {\n> > \n> > @@ -35,13 +36,16 @@ public:\n> > \tstd::shared_ptr get(dev_t devnum);\n> > \n> > \tvoid addCamera(std::shared_ptr camera, dev_t devnum);\n> > -\tvoid removeCamera(Camera *camera);\n> > +\tvoid removeCamera(std::shared_ptr camera);\n> > \n> > \tstatic const std::string &version() { return version_; }\n> > \n> > \tvoid setEventDispatcher(std::unique_ptr\n> > dispatcher);\n> > \tEventDispatcher *eventDispatcher();\n> > \n> > +\tSignal> cameraAdded;\n> > +\tSignal> cameraRemoved;\n> > +\n> > private:\n> > \tstatic const std::string version_;\n> > \tstatic CameraManager *self_;\n> > diff --git a/src/libcamera/camera_manager.cpp\n> > b/src/libcamera/camera_manager.cpp\n> > index a13cfe1..b9d2496 100644\n> > --- a/src/libcamera/camera_manager.cpp\n> > +++ b/src/libcamera/camera_manager.cpp\n> > @@ -186,7 +186,7 @@ void\n> > CameraManager::Private::addCamera(std::shared_ptr &camera,\n> > \t\t}\n> > \t}\n> > \n> > -\tcameras_.push_back(std::move(camera));\n> > +\tcameras_.push_back(camera);\n> > \n> > \tif (devnum) {\n> > \t\tunsigned int index = cameras_.size() - 1;\n> > @@ -376,6 +376,32 @@ std::shared_ptr\n> > CameraManager::get(dev_t devnum)\n> > \treturn iter->second.lock();\n> > }\n> > \n> > +/**\n> > + * \\brief Notify of a new camera added to the system\n> \n> Missing the \\var to reference the signal.\n> \n> > + *\n> > + * This signal is emitted when a new camera is detected and\n> > successfully handled\n> > + * by the camera manager. The notification occurs alike for\n> > cameras detected\n> > + * when the manager is started with start() or when new cameras\n> > are later\n> > + * connected to the system. When the signal is emitted the new\n> > camera is already\n> > + * available from the list of cameras().\n> > + *\n> > + * The signal is emitted from the CameraManager thread.\n> > Applications shall\n> > + * minimize the time spent in the signal handler and shall in\n> > particular not\n> > + * perform any blocking operation.\n> > + */\n> > +\n> > +/**\n> \n> And missing here too.\n> \n> > + * \\brief Notify of a new camera removed from the system\n> > + *\n> > + * This signal is emitted when a camera is removed from the\n> > system. When the\n> > + * signal is emitted the camera is not available from the list of\n> > cameras()\n> > + * anymore.\n> > + *\n> > + * The signal is emitted from the CameraManager thread.\n> > Applications shall\n> > + * minimize the time spent in the signal handler and shall in\n> > particular not\n> > + * perform any blocking operation.\n> > + */\n> > +\n> > /**\n> > * \\brief Add a camera to the camera manager\n> > * \\param[in] camera The camera to be added\n> > @@ -395,6 +421,7 @@ void\n> > CameraManager::addCamera(std::shared_ptr camera, dev_t\n> > devnum)\n> > \tASSERT(Thread::current() == p_.get());\n> > \n> > \tp_->addCamera(camera, devnum);\n> > +\tcameraAdded.emit(camera);\n> > }\n> > \n> > /**\n> > @@ -407,11 +434,12 @@ void\n> > CameraManager::addCamera(std::shared_ptr camera, dev_t\n> > devnum)\n> > *\n> > * \\context This function shall be called from the CameraManager\n> > thread.\n> > */\n> > -void CameraManager::removeCamera(Camera *camera)\n> > +void CameraManager::removeCamera(std::shared_ptr camera)\n> > {\n> > \tASSERT(Thread::current() == p_.get());\n> > \n> > -\tp_->removeCamera(camera);\n> > +\tp_->removeCamera(camera.get());\n> > +\tcameraRemoved.emit(camera);\n> \n> Is there any race here, or potential problem emitting the signal with\n> the camera, after it's been removed from the CameraManager? (I\n> hope/expect not as it's using a shared_ptr ... But I haven't checked\n> to\n> see if there are any implications caused by the removeCamera call)\n> \n> \n> > }\n> > \n> > /**\n> > diff --git a/src/libcamera/pipeline_handler.cpp\n> > b/src/libcamera/pipeline_handler.cpp\n> > index 254d341..a9187e1 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -555,7 +555,7 @@ void PipelineHandler::disconnect()\n> > \t\t\tcontinue;\n> > \n> > \t\tcamera->disconnect();\n> > -\t\tmanager_->removeCamera(camera.get());\n> > +\t\tmanager_->removeCamera(camera);\n> > \t}\n> > \n> > \tcameras_.clear();\n> >","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C532603D8\n\tfor ;\n\tTue, 19 May 2020 10:53:50 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-5j4tk with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-5j4tk-19-5EC39E9D-C\n\t2020-05-19 08:53:49.250121265 +0000 UTC m=+4693582.320491801","from mail.uajain.com (unknown)\n\tby ismtpd0002p1hnd1.sendgrid.net (SG) with ESMTP\n\tid Bd6AMosUSmiEQTs6cey-XA Tue, 19 May 2020 08:53:48.736 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"MKWY11yH\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=subject:from:in-reply-to:references:content-type:mime-version:to:cc:\n\tcontent-transfer-encoding;\n\ts=s1; bh=ynzTvsuQVRbBTsaDZ9du0PfAcT2TnbTsvKzhdAzhq3c=;\n\tb=MKWY11yH0tnIjZl8xDAuMM/Lhuhji+rSXVlYgG92CH7X8taRCGT+0q2jBM3d5lHLX3rk\n\tA6BTwLyINKIv4OTkI/jEXwJY5fFnKbz1kVwmmhw3VxtaVZAr5jvMVza0v2DREM4V/3JBxJ\n\t6ejz+38F+3nttN6R8ZHniXyz3Ym4TaGRk=","Message-ID":"<5a09fdc0eff73cf4c2721d0864ebaaf7c0674ae2.camel@uajain.com>","From":"Umang Jain ","Date":"Tue, 19 May 2020 08:53:49 +0000 (UTC)","In-Reply-To":"<83c9ff96-336b-064a-cae6-093255720ccd@ideasonboard.com>","References":"<20200513172950.72685-1-email@uajain.com>\n\t<20200513172950.72685-4-email@uajain.com>\n\t<83c9ff96-336b-064a-cae6-093255720ccd@ideasonboard.com>","Content-Type":"text/plain; charset=us-ascii","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcofpXQ1KwJPJayd5tGsU1eDJ/Qtv+1WZIuwCkuzvj222EPMqvcvTQSp6S28DIEjKq54dar0j7b3C1ZiXSXF8HiAtAAh+9zYe68e0cHeohzdGPc9qudWPd8lA3dph/BWL1x8n+ex1Q/j5cIxo143P17eu1BA88tz7osFTC0m4Us0tR2igoJvPNV8ZLtn6ou4s4InxW3oXFkgVXGhlzE2qdSg==","To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel ","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 3/5] libcamera: camera_manager:\n\tIntroduce signals when a camera is added/removed","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 19 May 2020 08:53:51 -0000"}}]