[{"id":593,"web_url":"https://patchwork.libcamera.org/comment/593/","msgid":"<20190125144831.GC4320@pendragon.ideasonboard.com>","date":"2019-01-25T14:48:31","subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: pipelines: add log\n\tcategory for each pipeline","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Jan 25, 2019 at 03:39:50PM +0100, Niklas Söderlund wrote:\n> The VIMC and UVC pipeline handlers lacked a dedicated log category.\n\nThis doesn't really require a separate patch, you can define the\ncategories in the first patch that makes use of them.\n\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/uvcvideo.cpp | 3 +++\n> src/libcamera/pipeline/vimc.cpp | 3 +++\n> 2 files changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n> index 5de8a0cb9c3406a8..1a445edfa8df777c 100644\n> --- a/src/libcamera/pipeline/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo.cpp\n> @@ -8,11 +8,14 @@\n> #include \n> \n> #include \"device_enumerator.h\"\n> +#include \"log.h\"\n> #include \"media_device.h\"\n> #include \"pipeline_handler.h\"\n> \n> namespace libcamera {\n> \n> +LOG_DEFINE_CATEGORY(UVC)\n> +\n> class PipelineHandlerUVC : public PipelineHandler\n> {\n> public:\n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index f58a97d51619515d..32b35626306bbce9 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -8,11 +8,14 @@\n> #include \n> \n> #include \"device_enumerator.h\"\n> +#include \"log.h\"\n> #include \"media_device.h\"\n> #include \"pipeline_handler.h\"\n> \n> namespace libcamera {\n> \n> +LOG_DEFINE_CATEGORY(VIMC)\n> +\n> class PipeHandlerVimc : public PipelineHandler\n> {\n> public:","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2705260B1D\n\tfor ;\n\tFri, 25 Jan 2019 15:48:32 +0100 (CET)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a02:a03f:4499:2700:1060:1d4c:d6a:8e80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 949FF325;\n\tFri, 25 Jan 2019 15:48:31 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548427711;\n\tbh=XPH1X0FVAbTsiYcagBmD/l7y8ra4Ekr6uW1RmK9aejU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hEOWhDX1xj097mgd6MEIywKxHUmsVt7L+X40e7qK+0dO00eb8TxT1enseckE13prF\n\tm/Xhfen19lMmgJM35+S5jQiHJjWZfxRwYMT/Sl3cvF4jUZT78nHy1W9CQOoPne3aUb\n\tM2+gxa57XC+k7chY1cSEJ3kC5JY8yOwrJ17tfHFI=","Date":"Fri, 25 Jan 2019 16:48:31 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190125144831.GC4320@pendragon.ideasonboard.com>","References":"<20190125143951.27992-1-niklas.soderlund@ragnatech.se>\n\t<20190125143951.27992-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190125143951.27992-3-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: pipelines: add log\n\tcategory for each pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 25 Jan 2019 14:48:32 -0000"}}]