[{"id":4775,"web_url":"https://patchwork.libcamera.org/comment/4775/","msgid":"<6a8add4e-c1f6-bd08-8928-3c8884eeda2c@xs4all.nl>","date":"2020-05-11T07:27:57","subject":"Re: [libcamera-devel] [PATCH v11 13/13] dt-bindings: Add media\n\tproperties","submitter":{"id":43,"url":"https://patchwork.libcamera.org/api/people/43/","name":"Hans Verkuil","email":"hverkuil-cisco@xs4all.nl"},"content":"On 09/05/2020 11:04, Jacopo Mondi wrote:\n> Add a DT header file to contain definitions for standard media properties.\n> \n> The file is named after:\n> Documentation/devicetree/bindings/media/video-interfaces.txt\n> which contains the standard media properties definitions.\n> \n> Initially add three macros to define the supported 'orientation'\n> property values.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n> \n> I currently don't have users in mainline for this, I understand this implies\n> this is probably not going to be accepted. At the same time we don't have a\n> common place for media-related definitions, which support properties defined in\n> video-interfaces.txt\n> \n> I leave it here at the end of the series for discussions, but I'm fine dropping\n> it from the series.\n> \n> Thanks\n>   j\n> \n> ---\n>  include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++\n>  1 file changed, 15 insertions(+)\n>  create mode 100644 include/dt-bindings/media/video-interfaces.h\n> \n> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h\n> new file mode 100644\n> index 0000000000000..404c697d6bd6e\n> --- /dev/null\n> +++ b/include/dt-bindings/media/video-interfaces.h\n> @@ -0,0 +1,15 @@\n> +/* SPDX-License-Identifier: GPL-2.0-only */\n> +/*\n> + * include/dt-bindings/media/video-interfaces.h\n> + *\n> + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org>\n> + */\n> +\n> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> +\n> +#define FRONT_CAMERA\t\t<0>\n> +#define BACK_CAMERA\t\t<1>\n> +#define EXTERNAL_CAMERA\t\t<2>\n\nUh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ?\n\nI'm skipping this patch for the PR.\n\nRegards,\n\n\tHans\n\n> +\n> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */\n> --\n> 2.26.1\n>","headers":{"Return-Path":"<hverkuil-cisco@xs4all.nl>","Received":["from lb2-smtp-cloud7.xs4all.net (lb2-smtp-cloud7.xs4all.net\n\t[194.109.24.28])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7706603E0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 May 2020 09:27:59 +0200 (CEST)","from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d])\n\tby smtp-cloud7.xs4all.net with ESMTPA\n\tid Y2qzjxHritKAsY2r0jnQb4; Mon, 11 May 2020 09:27:59 +0200"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=xs4all.nl header.i=@xs4all.nl\n\theader.b=\"ZWq9BdqO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1;\n\tt=1589182079; bh=djFYuodzN4n71AJy/ln34i1tOSfwYHOl2CIsBKilu2g=;\n\th=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From:\n\tSubject;\n\tb=ZWq9BdqOaAblLRg+t/bVIpo8mW/NtldKPrpfGt6uTLxWx4wqwz85DWUeu0dJTdBnB\n\tQ9O3zOpyTzaUN0uPLmDXgvZWA4DrA25Fl1ULSf+AfBydN21hGRdbD2R0qtW6aaqXD0\n\tWY0/bIy4nENa6xCc1qbEpos27RELjDnsncS0ayiKB0v/uapvp4PbFaiuIybrvskWAp\n\tzjlXzjvJ1/iBduAYULZF6cfz/WkF+pqutUNvVy9V8684eTeJfNsfN9qD7jo5cFv/7H\n\tIIIGj3mWchf+57FjY6DlpzlSdZysgVSEldAbuZt6xgesI4AomOCXTDT6lNL3uao3+5\n\tWJ6eNlwxg/Q5Q==","To":"Jacopo Mondi <jacopo@jmondi.org>,\n\t\"open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)\"\n\t<linux-media@vger.kernel.org>, libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab <mchehab@kernel.org>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tRob Herring <robh@kernel.org>","Cc":"tfiga@google.com, pavel@ucw.cz, devicetree@vger.kernel.org","References":"<20200509090456.3496481-1-jacopo@jmondi.org>\n\t<20200509090456.3496481-14-jacopo@jmondi.org>","From":"Hans Verkuil <hverkuil-cisco@xs4all.nl>","Message-ID":"<6a8add4e-c1f6-bd08-8928-3c8884eeda2c@xs4all.nl>","Date":"Mon, 11 May 2020 09:27:57 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200509090456.3496481-14-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-CMAE-Envelope":"MS4wfIeiB9Ead4aZl4KJTvWnhlmpMLPgM5Y3oDscyguEHliG8TMHRc+79DqIOQIikfhxtqF8mmh9MxNnSzGbmrkDtuKJBTo4F80Syfrv/3oVnt+t1ZzwwMA6\n\tEMboqN0CJ2H9jq4dMyli6kanivlpzNiIz+T+RGRmyTVW37v+vJ4e+Ve6SCqR3uKvzs2EFYs9vtCCJqX/H1ISq3zuAje05mTQxHBH3Rt51YgAABYcGcDShuat\n\tnQsXe9JROuF70Im1EtTcOzmXxufCEFDBDnXaLy3wOPkMgu/wtk7LDYImzMCbUwZ8nrSwwtIJz1ZiTovOoUkrIdks4ZEDsb5X/bKQ0r/0egOSRivS9kgAl1ew\n\tvuw6FJR5XXdqikrrbExfo6YYpPLKNd6vcELdo7Oj7cprEGTgG/oeQi+lQvvuNdS4s+TFZqTHcSu4DlxJlfPmDDLFtvqLjTtGAvycbYJgzVJmTK/ggjY77YYh\n\tud7eDe8O9pDpalSr/l14CQOKrrYlwhkhq23XGdVKcGs83czbXNJNefpe/D/vWNriJ6VVKeCDXvrw0Cn74JwkTTVUJ1C1MNutBvKFf3B9wnjU6JG1GnV52dSG\n\tpmyHoojaLSWJHbdCxBlxFycc","Subject":"Re: [libcamera-devel] [PATCH v11 13/13] dt-bindings: Add media\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 11 May 2020 07:28:00 -0000"}},{"id":4842,"web_url":"https://patchwork.libcamera.org/comment/4842/","msgid":"<20200518182118.GA24090@bogus>","date":"2020-05-18T18:21:18","subject":"Re: [libcamera-devel] [PATCH v11 13/13] dt-bindings: Add media\n\tproperties","submitter":{"id":40,"url":"https://patchwork.libcamera.org/api/people/40/","name":"Rob Herring","email":"robh@kernel.org"},"content":"On Sat, May 09, 2020 at 11:04:56AM +0200, Jacopo Mondi wrote:\n> Add a DT header file to contain definitions for standard media properties.\n> \n> The file is named after:\n> Documentation/devicetree/bindings/media/video-interfaces.txt\n> which contains the standard media properties definitions.\n> \n> Initially add three macros to define the supported 'orientation'\n> property values.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n> \n> I currently don't have users in mainline for this, I understand this implies\n> this is probably not going to be accepted. At the same time we don't have a\n> common place for media-related definitions, which support properties defined in\n> video-interfaces.txt\n\nFine for me with no users if values already defined in binding.\n\n> \n> I leave it here at the end of the series for discussions, but I'm fine dropping\n> it from the series.\n> \n> Thanks\n>   j\n> \n> ---\n>  include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++\n>  1 file changed, 15 insertions(+)\n>  create mode 100644 include/dt-bindings/media/video-interfaces.h\n> \n> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h\n> new file mode 100644\n> index 0000000000000..404c697d6bd6e\n> --- /dev/null\n> +++ b/include/dt-bindings/media/video-interfaces.h\n> @@ -0,0 +1,15 @@\n> +/* SPDX-License-Identifier: GPL-2.0-only */\n\nDual license please.\n\n> +/*\n> + * include/dt-bindings/media/video-interfaces.h\n> + *\n> + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org>\n> + */\n> +\n> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> +\n> +#define FRONT_CAMERA\t\t<0>\n> +#define BACK_CAMERA\t\t<1>\n> +#define EXTERNAL_CAMERA\t\t<2>\n> +\n> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */\n> --\n> 2.26.1\n>","headers":{"Return-Path":"<robherring2@gmail.com>","Received":["from mail-io1-f66.google.com (mail-io1-f66.google.com\n\t[209.85.166.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58981603DB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 May 2020 20:21:21 +0200 (CEST)","by mail-io1-f66.google.com with SMTP id k6so11719388iob.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 May 2020 11:21:21 -0700 (PDT)","from rob-hp-laptop ([64.188.179.252])\n\tby smtp.gmail.com with ESMTPSA id\n\tm17sm5062222ilh.51.2020.05.18.11.21.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 May 2020 11:21:19 -0700 (PDT)","(nullmailer pid 27724 invoked by uid 1000);\n\tMon, 18 May 2020 18:21:18 -0000"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=G+w12N+B2PiHESokDoCntmAJD2nRnefuc3D2jDiR3h8=;\n\tb=px01uMlsTc3qeTa6L9MgN3pPaj4yU0z93HjYiuirXnYDHo5/+IDXSp/TvbKenbf7Vk\n\tS5AaJX+kbeGfjWLRIJWTSxy5GXBNmSIeVru95knxRZQ+a+27Dcs2zzomPfuv99dXGkQC\n\tG8aI7+JLLnTZBdqaNOVduuV0oU1fP2B0NbaXvi2nY4baMJ49jfXMR1SJFS+wz2xwQhWh\n\tLjJ5fnYEuXI5lShajSaHwOvR3ulPHU0Pgc48qxLGAm9AShXyVQVYeEfmjujTPqgjtcr7\n\tj/hj37TxyTVgftqJ08NqyVTQFJzKsPB4eSodSQJVuMKEZXVsPyO4pViQ5pi1R1eRI49A\n\tusuw==","X-Gm-Message-State":"AOAM533sSFeHBWjA8MoxkqwCvBFTrFEsx0Uqhg5D603Iy8My9qjS8gMt\n\tAVShI8vPP1G8wIgJ3w63Ow==","X-Google-Smtp-Source":"ABdhPJx72FnMnqBhY0ES/xdixMmYlsaeGaOPaJzpYhhzZYE1ew/CeuMZ+1kDJ3srj1k4VHm7DIoKMA==","X-Received":"by 2002:a6b:dc11:: with SMTP id\n\ts17mr15908502ioc.42.1589826079993; \n\tMon, 18 May 2020 11:21:19 -0700 (PDT)","Date":"Mon, 18 May 2020 12:21:18 -0600","From":"Rob Herring <robh@kernel.org>","To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"\"open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)\"\n\t<linux-media@vger.kernel.org>, libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab <mchehab@kernel.org>,\n\tHans Verkuil <hverkuil-cisco@xs4all.nl>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>, tfiga@google.com,\n\tpavel@ucw.cz, devicetree@vger.kernel.org","Message-ID":"<20200518182118.GA24090@bogus>","References":"<20200509090456.3496481-1-jacopo@jmondi.org>\n\t<20200509090456.3496481-14-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20200509090456.3496481-14-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v11 13/13] dt-bindings: Add media\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 18 May 2020 18:21:21 -0000"}},{"id":4872,"web_url":"https://patchwork.libcamera.org/comment/4872/","msgid":"<20200520075217.zxpirx5migumekwx@uno.localdomain>","date":"2020-05-20T07:52:17","subject":"Re: [libcamera-devel] [PATCH v11 13/13] dt-bindings: Add media\n\tproperties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hans,\n\nOn Mon, May 11, 2020 at 09:27:57AM +0200, Hans Verkuil wrote:\n> On 09/05/2020 11:04, Jacopo Mondi wrote:\n> > Add a DT header file to contain definitions for standard media properties.\n> >\n> > The file is named after:\n> > Documentation/devicetree/bindings/media/video-interfaces.txt\n> > which contains the standard media properties definitions.\n> >\n> > Initially add three macros to define the supported 'orientation'\n> > property values.\n> >\n> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> > ---\n> >\n> > I currently don't have users in mainline for this, I understand this implies\n> > this is probably not going to be accepted. At the same time we don't have a\n> > common place for media-related definitions, which support properties defined in\n> > video-interfaces.txt\n> >\n> > I leave it here at the end of the series for discussions, but I'm fine dropping\n> > it from the series.\n> >\n> > Thanks\n> >   j\n> >\n> > ---\n> >  include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++\n> >  1 file changed, 15 insertions(+)\n> >  create mode 100644 include/dt-bindings/media/video-interfaces.h\n> >\n> > diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h\n> > new file mode 100644\n> > index 0000000000000..404c697d6bd6e\n> > --- /dev/null\n> > +++ b/include/dt-bindings/media/video-interfaces.h\n> > @@ -0,0 +1,15 @@\n> > +/* SPDX-License-Identifier: GPL-2.0-only */\n> > +/*\n> > + * include/dt-bindings/media/video-interfaces.h\n> > + *\n> > + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org>\n> > + */\n> > +\n> > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> > +\n> > +#define FRONT_CAMERA\t\t<0>\n> > +#define BACK_CAMERA\t\t<1>\n> > +#define EXTERNAL_CAMERA\t\t<2>\n>\n> Uh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ?\n\nI used that notation to be able to write\n        orientation = FRONT_CAMERA\nin place of\n        orientation = <FRONT_CAMERA>\n\nDo you think it's wrong ?\n\nThanks\n  j\n\n>\n> I'm skipping this patch for the PR.\n>\n> Regards,\n>\n> \tHans\n>\n> > +\n> > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */\n> > --\n> > 2.26.1\n> >\n>","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32663603D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 May 2020 09:49:01 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 82797FF813;\n\tWed, 20 May 2020 07:48:57 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 20 May 2020 09:52:17 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Hans Verkuil <hverkuil-cisco@xs4all.nl>","Cc":"\"open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)\"\n\t<linux-media@vger.kernel.org>, libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab <mchehab@kernel.org>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tRob Herring <robh@kernel.org>, tfiga@google.com, pavel@ucw.cz,\n\tdevicetree@vger.kernel.org","Message-ID":"<20200520075217.zxpirx5migumekwx@uno.localdomain>","References":"<20200509090456.3496481-1-jacopo@jmondi.org>\n\t<20200509090456.3496481-14-jacopo@jmondi.org>\n\t<6a8add4e-c1f6-bd08-8928-3c8884eeda2c@xs4all.nl>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<6a8add4e-c1f6-bd08-8928-3c8884eeda2c@xs4all.nl>","Subject":"Re: [libcamera-devel] [PATCH v11 13/13] dt-bindings: Add media\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 20 May 2020 07:49:01 -0000"}},{"id":10801,"web_url":"https://patchwork.libcamera.org/comment/10801/","msgid":"<982aab4d-3214-564e-467f-087ecc9241d8@xs4all.nl>","date":"2020-06-24T13:46:21","subject":"Re: [libcamera-devel] [PATCH v11 13/13] dt-bindings: Add media\n\tproperties","submitter":{"id":43,"url":"https://patchwork.libcamera.org/api/people/43/","name":"Hans Verkuil","email":"hverkuil-cisco@xs4all.nl"},"content":"On 20/05/2020 09:52, Jacopo Mondi wrote:\n> Hi Hans,\n> \n> On Mon, May 11, 2020 at 09:27:57AM +0200, Hans Verkuil wrote:\n>> On 09/05/2020 11:04, Jacopo Mondi wrote:\n>>> Add a DT header file to contain definitions for standard media properties.\n>>>\n>>> The file is named after:\n>>> Documentation/devicetree/bindings/media/video-interfaces.txt\n>>> which contains the standard media properties definitions.\n>>>\n>>> Initially add three macros to define the supported 'orientation'\n>>> property values.\n>>>\n>>> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n>>> ---\n>>>\n>>> I currently don't have users in mainline for this, I understand this implies\n>>> this is probably not going to be accepted. At the same time we don't have a\n>>> common place for media-related definitions, which support properties defined in\n>>> video-interfaces.txt\n>>>\n>>> I leave it here at the end of the series for discussions, but I'm fine dropping\n>>> it from the series.\n>>>\n>>> Thanks\n>>>   j\n>>>\n>>> ---\n>>>  include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++\n>>>  1 file changed, 15 insertions(+)\n>>>  create mode 100644 include/dt-bindings/media/video-interfaces.h\n>>>\n>>> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h\n>>> new file mode 100644\n>>> index 0000000000000..404c697d6bd6e\n>>> --- /dev/null\n>>> +++ b/include/dt-bindings/media/video-interfaces.h\n>>> @@ -0,0 +1,15 @@\n>>> +/* SPDX-License-Identifier: GPL-2.0-only */\n>>> +/*\n>>> + * include/dt-bindings/media/video-interfaces.h\n>>> + *\n>>> + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org>\n>>> + */\n>>> +\n>>> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n>>> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n>>> +\n>>> +#define FRONT_CAMERA\t\t<0>\n>>> +#define BACK_CAMERA\t\t<1>\n>>> +#define EXTERNAL_CAMERA\t\t<2>\n>>\n>> Uh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ?\n> \n> I used that notation to be able to write\n>         orientation = FRONT_CAMERA\n> in place of\n>         orientation = <FRONT_CAMERA>\n> \n> Do you think it's wrong ?\n\nYes, I think that's wrong :-)\n\n>From what I can see in existing device tree files you do not hide the '<>'.\n\nRegards,\n\n\tHans\n\n> \n> Thanks\n>   j\n> \n>>\n>> I'm skipping this patch for the PR.\n>>\n>> Regards,\n>>\n>> \tHans\n>>\n>>> +\n>>> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */\n>>> --\n>>> 2.26.1\n>>>\n>>","headers":{"Return-Path":"<hverkuil-cisco@xs4all.nl>","Received":["from lb1-smtp-cloud8.xs4all.net (lb1-smtp-cloud8.xs4all.net\n\t[194.109.24.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 130B460103\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Jun 2020 15:46:26 +0200 (CEST)","from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d])\n\tby smtp-cloud8.xs4all.net with ESMTPA\n\tid o5jJjhY5wNb6lo5jMjtarX; Wed, 24 Jun 2020 15:46:25 +0200"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=xs4all.nl header.i=@xs4all.nl\n\theader.b=\"HjKIqEjr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1;\n\tt=1593006385; bh=ZuV4OmcavInlJN2jxK6OSIjKBVUQtZBJPsSNmNf4VtE=;\n\th=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From:\n\tSubject;\n\tb=HjKIqEjrG/WADHDRB48Q5wBZwrHcFhHpvNLciTynquKm5yE6KvY+jk7CyoRme4jb8\n\tgaJT3ok7Z4BifCV3Jwn5eynDB2z56kl+urp+ayU0Qm5OK7bydZG+wrDbF2BEx7W7gw\n\tJVnaEvVZzasnlU/EXmjvnhS3KMy/ZUYLKw0Idrbj54dlYr6DJVc99wRnbEoBFSNorA\n\tjbf5jmDAYSlHRD/da9yTJbPPp5OfF6lfD6ktENp6VRQFd/sYf7lIkwRyRPU198A6oU\n\tFDlg6Zr5tQuO9GpJ9I3pF8P4D/PgrrQwPpz/hVQqTYNySLo6byf1J1Ww6SrZtgu9PC\n\tHmYaDnNC96neA==","To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"\"open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)\"\n\t<linux-media@vger.kernel.org>, libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab <mchehab@kernel.org>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tRob Herring <robh@kernel.org>, tfiga@google.com, pavel@ucw.cz,\n\tdevicetree@vger.kernel.org","References":"<20200509090456.3496481-1-jacopo@jmondi.org>\n\t<20200509090456.3496481-14-jacopo@jmondi.org>\n\t<6a8add4e-c1f6-bd08-8928-3c8884eeda2c@xs4all.nl>\n\t<20200520075217.zxpirx5migumekwx@uno.localdomain>","From":"Hans Verkuil <hverkuil-cisco@xs4all.nl>","Message-ID":"<982aab4d-3214-564e-467f-087ecc9241d8@xs4all.nl>","Date":"Wed, 24 Jun 2020 15:46:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.9.0","MIME-Version":"1.0","In-Reply-To":"<20200520075217.zxpirx5migumekwx@uno.localdomain>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-CMAE-Envelope":"MS4wfLP9AbVPTh4Suhogb0uTVq+ZuTuA/ufGXSNoJyr4fqOfZjF0kpircmmzUWD6iQ/mBwGJm0eliL0JazH4sqFiQZLHq3k26TeMP1ZSOVMF9TAuCtoX/fNe\n\te1OCMTKkBLmTLJt5ZTezPCq6wEqg7+4R1rOwL1Dapz+V3D41XWWMMwmqbkj3ck/E4g2uve8gNmRIlujBxNTIaJGuibYK6qlpG1/QJelvdzOHH8/t6ehOIRtI\n\t4oEIZzCdItuaC/RFhJ8PVsHop+k4Lh9WHcS519m+Yo1Jl5W6O6her+vAMQwdWRXvCXBBzI2v9Cr6OfJrkRTlKk6hFzJ8crsq+0FDoKV0qBylgf3hkVYRAo8p\n\tLL3+uwJx2QNjHEswX4XANMYHrYzvNLypj/aJ2oge4WBlQGXRqpA+pEALd8WuO8Q4GdaERg3bgjaRJpwA88AT4u6Ny/pu2o8Tm8kiUbtTgnn9Fngo/WIhv65/\n\twZiWd2KsWJ6VVvi8Q/txkcgmjkVH++ZdtY9peQ==","X-Mailman-Approved-At":"Wed, 24 Jun 2020 16:10:33 +0200","Subject":"Re: [libcamera-devel] [PATCH v11 13/13] dt-bindings: Add media\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 24 Jun 2020 13:46:26 -0000"}}]