{"id":3736,"url":"https://patchwork.libcamera.org/api/patches/3736/?format=json","web_url":"https://patchwork.libcamera.org/patch/3736/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200509090456.3496481-12-jacopo@jmondi.org>","date":"2020-05-09T09:04:54","name":"[libcamera-devel,v11,11/13] media: i2c: ov13858: Parse and register properties","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"b38aa91922ef16048b9cea6b08cb86b5d3852ff0","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/3736/mbox/","series":[{"id":889,"url":"https://patchwork.libcamera.org/api/series/889/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=889","date":"2020-05-09T09:04:43","name":"media: report camera properties","version":11,"mbox":"https://patchwork.libcamera.org/series/889/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3736/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3736/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51625603E2\n\tfor ;\n\tSat, 9 May 2020 11:02:24 +0200 (CEST)","from uno.homenet.telecomitalia.it (a-ur1-85.tin.it\n\t[212.216.150.148]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 43A1F1C0003;\n\tSat, 9 May 2020 09:02:22 +0000 (UTC)"],"X-Originating-IP":"212.216.150.148","From":"Jacopo Mondi ","To":"linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE\n\t(V4L/DVB)), libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab ,\n\tHans Verkuil ,\n\tSakari Ailus ,\n\tLaurent Pinchart ","Cc":"Jacopo Mondi ,\n\ttfiga@google.com,\n\tpavel@ucw.cz","Date":"Sat, 9 May 2020 11:04:54 +0200","Message-Id":"<20200509090456.3496481-12-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.26.1","In-Reply-To":"<20200509090456.3496481-1-jacopo@jmondi.org>","References":"<20200509090456.3496481-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v11 11/13] media: i2c: ov13858: Parse and\n\tregister properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 09 May 2020 09:02:24 -0000"},"content":"Parse device properties and register controls for them using the newly\nintroduced helpers.\n\nSigned-off-by: Jacopo Mondi \n---\n drivers/media/i2c/ov13858.c | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c\nindex aac6f77afa0f4..236ad2c816b70 100644\n--- a/drivers/media/i2c/ov13858.c\n+++ b/drivers/media/i2c/ov13858.c\n@@ -7,6 +7,7 @@\n #include \n #include \n #include \n+#include \n \n #define OV13858_REG_VALUE_08BIT\t\t1\n #define OV13858_REG_VALUE_16BIT\t\t2\n@@ -1589,6 +1590,7 @@ static const struct v4l2_subdev_internal_ops ov13858_internal_ops = {\n static int ov13858_init_controls(struct ov13858 *ov13858)\n {\n \tstruct i2c_client *client = v4l2_get_subdevdata(&ov13858->sd);\n+\tstruct v4l2_fwnode_device_properties props;\n \tstruct v4l2_ctrl_handler *ctrl_hdlr;\n \ts64 exposure_max;\n \ts64 vblank_def;\n@@ -1600,7 +1602,7 @@ static int ov13858_init_controls(struct ov13858 *ov13858)\n \tint ret;\n \n \tctrl_hdlr = &ov13858->ctrl_handler;\n-\tret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);\n+\tret = v4l2_ctrl_handler_init(ctrl_hdlr, 10);\n \tif (ret)\n \t\treturn ret;\n \n@@ -1666,6 +1668,15 @@ static int ov13858_init_controls(struct ov13858 *ov13858)\n \t\tgoto error;\n \t}\n \n+\tret = v4l2_fwnode_device_parse(&client->dev, &props);\n+\tif (ret)\n+\t\tgoto error;\n+\n+\tret = v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &ov13858_ctrl_ops,\n+\t\t\t\t\t &props);\n+\tif (ret)\n+\t\tgoto error;\n+\n \tov13858->sd.ctrl_handler = ctrl_hdlr;\n \n \treturn 0;\n","prefixes":["libcamera-devel","v11","11/13"]}