{"id":3735,"url":"https://patchwork.libcamera.org/api/patches/3735/?format=json","web_url":"https://patchwork.libcamera.org/patch/3735/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200509090456.3496481-11-jacopo@jmondi.org>","date":"2020-05-09T09:04:53","name":"[libcamera-devel,v11,10/13] media: i2c: ov5670: Parse and register properties","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"2cca5ea5721beab64bff0205fb8a3220f8c02f6a","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/3735/mbox/","series":[{"id":889,"url":"https://patchwork.libcamera.org/api/series/889/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=889","date":"2020-05-09T09:04:43","name":"media: report camera properties","version":11,"mbox":"https://patchwork.libcamera.org/series/889/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3735/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3735/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13B6F603E2\n\tfor ;\n\tSat, 9 May 2020 11:02:22 +0200 (CEST)","from uno.homenet.telecomitalia.it (a-ur1-85.tin.it\n\t[212.216.150.148]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id B063E1C0004;\n\tSat, 9 May 2020 09:02:19 +0000 (UTC)"],"X-Originating-IP":"212.216.150.148","From":"Jacopo Mondi ","To":"linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE\n\t(V4L/DVB)), libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab ,\n\tHans Verkuil ,\n\tSakari Ailus ,\n\tLaurent Pinchart ","Cc":"Jacopo Mondi ,\n\ttfiga@google.com,\n\tpavel@ucw.cz","Date":"Sat, 9 May 2020 11:04:53 +0200","Message-Id":"<20200509090456.3496481-11-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.26.1","In-Reply-To":"<20200509090456.3496481-1-jacopo@jmondi.org>","References":"<20200509090456.3496481-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v11 10/13] media: i2c: ov5670: Parse and\n\tregister properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 09 May 2020 09:02:22 -0000"},"content":"Parse device properties and register controls for them using the newly\nintroduced helpers.\n\nSigned-off-by: Jacopo Mondi \n---\n drivers/media/i2c/ov5670.c | 14 +++++++++++++-\n 1 file changed, 13 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c\nindex 041fcbb4eebdf..f26252e35e08d 100644\n--- a/drivers/media/i2c/ov5670.c\n+++ b/drivers/media/i2c/ov5670.c\n@@ -7,6 +7,7 @@\n #include \n #include \n #include \n+#include \n \n #define OV5670_REG_CHIP_ID\t\t0x300a\n #define OV5670_CHIP_ID\t\t\t0x005670\n@@ -2059,6 +2060,8 @@ static const struct v4l2_ctrl_ops ov5670_ctrl_ops = {\n /* Initialize control handlers */\n static int ov5670_init_controls(struct ov5670 *ov5670)\n {\n+\tstruct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd);\n+\tstruct v4l2_fwnode_device_properties props;\n \tstruct v4l2_ctrl_handler *ctrl_hdlr;\n \ts64 vblank_max;\n \ts64 vblank_def;\n@@ -2067,7 +2070,7 @@ static int ov5670_init_controls(struct ov5670 *ov5670)\n \tint ret;\n \n \tctrl_hdlr = &ov5670->ctrl_handler;\n-\tret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);\n+\tret = v4l2_ctrl_handler_init(ctrl_hdlr, 10);\n \tif (ret)\n \t\treturn ret;\n \n@@ -2129,6 +2132,15 @@ static int ov5670_init_controls(struct ov5670 *ov5670)\n \t\tgoto error;\n \t}\n \n+\tret = v4l2_fwnode_device_parse(&client->dev, &props);\n+\tif (ret)\n+\t\tgoto error;\n+\n+\tret = v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &ov5670_ctrl_ops,\n+\t\t\t\t\t &props);\n+\tif (ret)\n+\t\tgoto error;\n+\n \tov5670->sd.ctrl_handler = ctrl_hdlr;\n \n \treturn 0;\n","prefixes":["libcamera-devel","v11","10/13"]}