[{"id":4764,"web_url":"https://patchwork.libcamera.org/comment/4764/","msgid":"","date":"2020-05-08T11:02:27","subject":"Re: [libcamera-devel] [PATCH v10 04/13] media: v4l2-ctrl: Document\n\tV4L2_CID_CAMERA_ORIENTATION","submitter":{"id":43,"url":"https://patchwork.libcamera.org/api/people/43/","name":"Hans Verkuil","email":"hverkuil-cisco@xs4all.nl"},"content":"On 08/05/2020 12:01, Jacopo Mondi wrote:\n> Add documentation for the V4L2_CID_CAMERA_ORIENTATION camera\n> control. The newly added read-only control reports the camera device\n> orientation relative to the usage orientation of the system the camera\n> is installed on.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> .../media/v4l/ext-ctrls-camera.rst | 30 +++++++++++++++++++\n> 1 file changed, 30 insertions(+)\n> \n> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst\n> index e39f84d2447f8..01e104bab6b3d 100644\n> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst\n> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst\n> @@ -510,6 +510,36 @@ enum v4l2_scene_mode -\n> value down. A value of zero stops the motion if one is in progress\n> and has no effect otherwise.\n> \n> +``V4L2_CID_CAMERA_ORIENTATION (integer)``\n\ninteger -> menu\n\n> + This read-only control describes the camera orientation by reporting\n> + its mounting position on the device where the camera is installed. The\n> + control value is constant and not modifiable by software. This control is\n> + particularly meaningful for devices which have a well defined orientation,\n> + such as phones, laptops and portable devices since the control is expressed\n> + as a position relative to the device's intended usage orientation.\n> + For example, a camera installed on the user-facing side of a phone,\n> + a tablet or a laptop device is said to be have ``V4L2_ORIENTATION_FRONT``\n> + orientation, while a camera installed on the opposite side of the front one\n> + is said to be have ``V4L2_ORIENTATION_BACK`` orientation. Camera sensors not\n> + directly attached to the device, or attached in a way that allows them to\n> + move freely, such as webcams and digital cameras, are said to have the\n> + ``V4L2_ORIENTATION_EXTERNAL`` orientation.\n> +\n> +\n> +\n> +.. flat-table::\n> + :header-rows: 0\n> + :stub-columns: 0\n> +\n> + * - ``V4L2_ORIENTATION_FRONT``\n\nThis really should be V4L2_CAMERA_ORIENTATION_FRONT. Yes, it is long, but just\n'ORIENTATION' doesn't tell you which orientation is meant, that's too generic.\n\nRegards,\n\n\tHans\n\n> + - The camera is oriented towards the user facing side of the device.\n> + * - ``V4L2_ORIENTATION_BACK``\n> + - The camera is oriented towards the back facing side of the device.\n> + * - ``V4L2_ORIENTATION_EXTERNAL``\n> + - The camera is not directly attached to the device and is freely movable.\n> +\n> +\n> +\n> .. [#f1]\n> This control may be changed to a menu control in the future, if more\n> options are required.\n>","headers":{"Return-Path":"","Received":["from lb3-smtp-cloud7.xs4all.net (lb3-smtp-cloud7.xs4all.net\n\t[194.109.24.31])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B24F600EA\n\tfor ;\n\tFri, 8 May 2020 13:02:31 +0200 (CEST)","from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d])\n\tby smtp-cloud7.xs4all.net with ESMTPA\n\tid X0lvjdrhStKAsX0lyje6yc; Fri, 08 May 2020 13:02:31 +0200"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=xs4all.nl header.i=@xs4all.nl\n\theader.b=\"H45apuXe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1;\n\tt=1588935751; bh=sfB+F30dZUB3AukYrPqyY23lRcTjzwmtOAAxkiLjgLE=;\n\th=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From:\n\tSubject;\n\tb=H45apuXesIGCWiuk9E/4xRY/li2fIB1JnV2ICZ73zdabA48jcDeiFGCdBw45VAX0U\n\tLoP6uEHuqrUzAHTNu5WluheHsstedxEJd2kiYggQbY6q4U94jtJFy76l9haqz6Ac95\n\tj7pfbfR35rFnPiMVDUHePZcQmtbvCaJ5fT6ru6lYJ9o4LVhm5a6s6NpAZsiYPvtTK1\n\tLz6IbrSp0f0ojaomzDR2IYK6afqyMesIPXKJHO/BRENFO+66ILLwMqH0xKITVcQzyD\n\tvXZmjU1vVpcsdMWFGGbZ2k3L4iTbHTX9kGdMvsc2N5jQxVWwtC4hNg7dUkgulnlzNE\n\tXI5qynN0xk2Fg==","To":"Jacopo Mondi ,\n\t\"open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)\"\n\t, libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab ,\n\tSakari Ailus ,\n\tLaurent Pinchart ","Cc":"tfiga@google.com, pavel@ucw.cz","References":"<20200508100158.3437161-1-jacopo@jmondi.org>\n\t<20200508100158.3437161-5-jacopo@jmondi.org>","From":"Hans Verkuil ","Message-ID":"","Date":"Fri, 8 May 2020 13:02:27 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.5.0","MIME-Version":"1.0","In-Reply-To":"<20200508100158.3437161-5-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-CMAE-Envelope":"MS4wfEOHUNdSILVOu0C6r1yF0hqH++4oIPLeUKSiC5k1Id9zV361AsBGojv6FmqjHUzf8scQbVwVK3w6mqCLAG2C8xxuNnt5h+GHE7NgLunU09ox7vfLgPgk\n\tHSEg255j4e8luOOlHHrIJc3Jcv2dc080EH0usmTCMEguD2fhm/WXrPZFgSPBYju8cK6BjxtcUOI/Ram8QKZhlkzkW69fRCH99x/uWxRP0ds/EoFJ791XnIbd\n\tD9DNo0ZtCIo7waMjF54F8qJWxCkK1lyBQ2GGlZNLpFm4H0HOZRlvGvKWJjLXLnnU1JnUrAgMdpwlT1alY794R89Y1d0tKNziuIwc2X0ZXSSn7mE4FITYCd3D\n\tKbNYn6LGZM0BfWUS6i1/vSr8g6izg12IM9timuMoXHrET7lBkLMlNRUyyjcgXZ5B21/vF8O9dc7ZrN7lD1LpilxZYpZJqQ==","Subject":"Re: [libcamera-devel] [PATCH v10 04/13] media: v4l2-ctrl: Document\n\tV4L2_CID_CAMERA_ORIENTATION","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 08 May 2020 11:02:32 -0000"}}]