[{"id":4765,"web_url":"https://patchwork.libcamera.org/comment/4765/","msgid":"","date":"2020-05-08T11:04:24","subject":"Re: [libcamera-devel] [PATCH v10 03/13] dt-bindings: Add media\n\tproperties","submitter":{"id":43,"url":"https://patchwork.libcamera.org/api/people/43/","name":"Hans Verkuil","email":"hverkuil-cisco@xs4all.nl"},"content":"On 08/05/2020 12:01, Jacopo Mondi wrote:\n> Add a DT header file to contain definitions for standard media properties.\n> \n> The file is named after:\n> Documentation/devicetree/bindings/media/video-interfaces.txt\n> which contains the standard media properties definitions.\n> \n> Initially add three macros to define the supported 'orientation'\n> property values.\n> \n> Signed-off-by: Jacopo Mondi \n\nFor v11 just move this to the end of the series since it is an independent\npatch.\n\n> ---\n> include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++\n> 1 file changed, 15 insertions(+)\n> create mode 100644 include/dt-bindings/media/video-interfaces.h\n> \n> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h\n> new file mode 100644\n> index 0000000000000..404c697d6bd6e\n> --- /dev/null\n> +++ b/include/dt-bindings/media/video-interfaces.h\n> @@ -0,0 +1,15 @@\n> +/* SPDX-License-Identifier: GPL-2.0-only */\n> +/*\n> + * include/dt-bindings/media/video-interfaces.h\n> + *\n> + * Copyright (C) 2020 Jacopo Mondi \n> + */\n> +\n> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> +\n> +#define FRONT_CAMERA\t\t<0>\n> +#define BACK_CAMERA\t\t<1>\n> +#define EXTERNAL_CAMERA\t\t<2>\n\nWouldn't it be better to say CAMERA_FRONT (i.e. swap the words) or\neven CAMERA_ORIENTATION_FRONT?\n\nRegards,\n\n\tHans\n\n> +\n> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */\n> --\n> 2.26.1\n>","headers":{"Return-Path":"","Received":["from lb2-smtp-cloud7.xs4all.net (lb2-smtp-cloud7.xs4all.net\n\t[194.109.24.28])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6B44600EA\n\tfor ;\n\tFri, 8 May 2020 13:04:28 +0200 (CEST)","from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d])\n\tby smtp-cloud7.xs4all.net with ESMTPA\n\tid X0nojdsWmtKAsX0nrje7Sw; Fri, 08 May 2020 13:04:28 +0200"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=xs4all.nl header.i=@xs4all.nl\n\theader.b=\"DRzB2sUE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1;\n\tt=1588935868; bh=jWeWN61JQKvTu589M4NfqHuR1nw9CwTDajchbqCtB34=;\n\th=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From:\n\tSubject;\n\tb=DRzB2sUEc5k6d7SvFkx61vTUCoYiWjtG6bW5HDToQscxCFSM0hbuZZvzy1+rBV0ld\n\tS87o3+rZgDysesypnZwBSS5FHWym3GEgp/o20gGCP65w7z+J3aMxJmqX++i6j4282o\n\thvyuVIygqvToOatIkk0mZbO2mOvoSfTJ5YevQ0Q1+8AlFTG89WYI7h9d3iKC1bDWyZ\n\t2cWbcoE3C75rXaukg8Hlpjk4gfVwBbuaemeZChX8a8Zk6wWb8ASoBjAi44SBj1BeXN\n\tRDcyp3+6/T59qMsMijErA/PwUCahgZ5jKNNnQTyDkeY4F+kGeWtiB1VF/LYyJbFRPj\n\tglP0V7nVVlulQ==","To":"Jacopo Mondi ,\n\t\"open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)\"\n\t, libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab ,\n\tSakari Ailus ,\n\tLaurent Pinchart ,\n\tRob Herring ","Cc":"tfiga@google.com, pavel@ucw.cz, devicetree@vger.kernel.org","References":"<20200508100158.3437161-1-jacopo@jmondi.org>\n\t<20200508100158.3437161-4-jacopo@jmondi.org>","From":"Hans Verkuil ","Message-ID":"","Date":"Fri, 8 May 2020 13:04:24 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.5.0","MIME-Version":"1.0","In-Reply-To":"<20200508100158.3437161-4-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-CMAE-Envelope":"MS4wfMrALxKOdEXDZO7irx6rGkiShrXWVzOOpwoMvHzTLPh3kQ0ev1tWbMlaohfEk6YjZ6qCF36EwujPyQ4ko9GDEnrgTNGXaaS3jUFdJlzPa96SerwotLOf\n\tC6UPX3mYCAjB8j2Kl6z1GBZi7Fd16A4veUFX9Aapei0bG1UoCZMXNMSNQdQVPC2kOzSpaJf58H18bm4udRMmaaqvGWqzQF9YG/CAwTRuZFf3fpaHFhD/Gp0P\n\t/l4QC6e1Eo3h3dBW/mSHxdv0H5ZVws3bt3y2QNCl26+ZwWNWhBnUbt+jJDBhwF9EolBU0Xyvh8cDFZKvd6TEiaNCANAjbOs3LVUKdAy/ORt0ikD71nOnpUOb\n\tXT7g7oS9DGEozQ6on002ogJDCSMoIZWreqn8rt1DpAuwS9HQS8SfSdyQnY4fFdM+uYoD+BZZl0SgxzjeHEfvBTO2WocdUf4RKHZV5Cf8c+jDN2bnEeQcbbv0\n\t7vvvN8XrxoYlVipnJJTwlFM5xno96ijD2yYPaw==","Subject":"Re: [libcamera-devel] [PATCH v10 03/13] dt-bindings: Add media\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 08 May 2020 11:04:29 -0000"}},{"id":4770,"web_url":"https://patchwork.libcamera.org/comment/4770/","msgid":"<20200509082132.zpojrdqcleb2dgp2@uno.localdomain>","date":"2020-05-09T08:21:32","subject":"Re: [libcamera-devel] [PATCH v10 03/13] dt-bindings: Add media\n\tproperties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hans,\n\nOn Fri, May 08, 2020 at 01:04:24PM +0200, Hans Verkuil wrote:\n> On 08/05/2020 12:01, Jacopo Mondi wrote:\n> > Add a DT header file to contain definitions for standard media properties.\n> >\n> > The file is named after:\n> > Documentation/devicetree/bindings/media/video-interfaces.txt\n> > which contains the standard media properties definitions.\n> >\n> > Initially add three macros to define the supported 'orientation'\n> > property values.\n> >\n> > Signed-off-by: Jacopo Mondi \n>\n> For v11 just move this to the end of the series since it is an independent\n> patch.\n\nAck, I can leave it out as well, since I have no users if not a local\none for testing.\n\n>\n> > ---\n> > include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++\n> > 1 file changed, 15 insertions(+)\n> > create mode 100644 include/dt-bindings/media/video-interfaces.h\n> >\n> > diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h\n> > new file mode 100644\n> > index 0000000000000..404c697d6bd6e\n> > --- /dev/null\n> > +++ b/include/dt-bindings/media/video-interfaces.h\n> > @@ -0,0 +1,15 @@\n> > +/* SPDX-License-Identifier: GPL-2.0-only */\n> > +/*\n> > + * include/dt-bindings/media/video-interfaces.h\n> > + *\n> > + * Copyright (C) 2020 Jacopo Mondi \n> > + */\n> > +\n> > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> > +\n> > +#define FRONT_CAMERA\t\t<0>\n> > +#define BACK_CAMERA\t\t<1>\n> > +#define EXTERNAL_CAMERA\t\t<2>\n>\n> Wouldn't it be better to say CAMERA_FRONT (i.e. swap the words) or\n> even CAMERA_ORIENTATION_FRONT?\n\nOnce I wrote\n orientation = CAMERA_FRONT;\n\nI realized that it was nicer to have\n\n orientation = FRONT_CAMERA:\n\nI'll stop bikeshedding though and wait for other comments to see if\nthis can be included or not.\n\n>\n> Regards,\n>\n> \tHans\n>\n> > +\n> > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */\n> > --\n> > 2.26.1\n> >\n>","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03898603E2\n\tfor ;\n\tSat, 9 May 2020 10:18:23 +0200 (CEST)","from uno.localdomain (a-ur1-85.tin.it [212.216.150.148])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id BFCD140002;\n\tSat, 9 May 2020 08:18:19 +0000 (UTC)"],"X-Originating-IP":"212.216.150.148","Date":"Sat, 9 May 2020 10:21:32 +0200","From":"Jacopo Mondi ","To":"Hans Verkuil ","Cc":"\"open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)\"\n\t, libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab ,\n\tSakari Ailus ,\n\tLaurent Pinchart ,\n\tRob Herring , tfiga@google.com, pavel@ucw.cz,\n\tdevicetree@vger.kernel.org","Message-ID":"<20200509082132.zpojrdqcleb2dgp2@uno.localdomain>","References":"<20200508100158.3437161-1-jacopo@jmondi.org>\n\t<20200508100158.3437161-4-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v10 03/13] dt-bindings: Add media\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 09 May 2020 08:18:23 -0000"}},{"id":4774,"web_url":"https://patchwork.libcamera.org/comment/4774/","msgid":"<20200511072114.GC11272@paasikivi.fi.intel.com>","date":"2020-05-11T07:21:14","subject":"Re: [libcamera-devel] [PATCH v10 03/13] dt-bindings: Add media\n\tproperties","submitter":{"id":37,"url":"https://patchwork.libcamera.org/api/people/37/","name":"Sakari Ailus","email":"sakari.ailus@linux.intel.com"},"content":"Hi Jacopo, Hans,\n\nOn Sat, May 09, 2020 at 10:21:32AM +0200, Jacopo Mondi wrote:\n> Hi Hans,\n> \n> On Fri, May 08, 2020 at 01:04:24PM +0200, Hans Verkuil wrote:\n> > On 08/05/2020 12:01, Jacopo Mondi wrote:\n> > > Add a DT header file to contain definitions for standard media properties.\n> > >\n> > > The file is named after:\n> > > Documentation/devicetree/bindings/media/video-interfaces.txt\n> > > which contains the standard media properties definitions.\n> > >\n> > > Initially add three macros to define the supported 'orientation'\n> > > property values.\n> > >\n> > > Signed-off-by: Jacopo Mondi \n> >\n> > For v11 just move this to the end of the series since it is an independent\n> > patch.\n> \n> Ack, I can leave it out as well, since I have no users if not a local\n> one for testing.\n> \n> >\n> > > ---\n> > > include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++\n> > > 1 file changed, 15 insertions(+)\n> > > create mode 100644 include/dt-bindings/media/video-interfaces.h\n> > >\n> > > diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h\n> > > new file mode 100644\n> > > index 0000000000000..404c697d6bd6e\n> > > --- /dev/null\n> > > +++ b/include/dt-bindings/media/video-interfaces.h\n> > > @@ -0,0 +1,15 @@\n> > > +/* SPDX-License-Identifier: GPL-2.0-only */\n> > > +/*\n> > > + * include/dt-bindings/media/video-interfaces.h\n> > > + *\n> > > + * Copyright (C) 2020 Jacopo Mondi \n> > > + */\n> > > +\n> > > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> > > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__\n> > > +\n> > > +#define FRONT_CAMERA\t\t<0>\n> > > +#define BACK_CAMERA\t\t<1>\n> > > +#define EXTERNAL_CAMERA\t\t<2>\n> >\n> > Wouldn't it be better to say CAMERA_FRONT (i.e. swap the words) or\n> > even CAMERA_ORIENTATION_FRONT?\n> \n> Once I wrote\n> orientation = CAMERA_FRONT;\n> \n> I realized that it was nicer to have\n> \n> orientation = FRONT_CAMERA:\n> \n> I'll stop bikeshedding though and wait for other comments to see if\n> this can be included or not.\n\nI'd be in favour of having \"CAMERA\" first. That gives it a nice prefix.","headers":{"Return-Path":"","Received":["from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49407603E0\n\tfor ;\n\tMon, 11 May 2020 09:21:25 +0200 (CEST)","from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t11 May 2020 00:21:20 -0700","from paasikivi.fi.intel.com ([10.237.72.42])\n\tby orsmga006-auth.jf.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 00:21:17 -0700","by paasikivi.fi.intel.com (Postfix, from userid 1000)\n\tid D505D207FE; Mon, 11 May 2020 10:21:14 +0300 (EEST)"],"IronPort-SDR":["SmpjwCDgqfw4ohJ8Zmyz/rfFT0iEb0WMdwmgdLeB69z/8ogXSzyr7JbftxWgjlQuynPYFddUlj\n\tCjbAyvd1MiYg==","q/E831QAP5/ndS2HAoNAZCjSs9P5FqSUd95vcbenzQjRGUN9N3dbSMKwhqxOUcuyKEsTMos/VF\n\t930gvM8uvOxQ=="],"X-Amp-Result":"SKIPPED(no attachment in message)","X-Amp-File-Uploaded":"False","X-IronPort-AV":"E=Sophos;i=\"5.73,378,1583222400\"; d=\"scan'208\";a=\"265068343\"","Date":"Mon, 11 May 2020 10:21:14 +0300","From":"Sakari Ailus ","To":"Jacopo Mondi ","Cc":"Hans Verkuil ,\n\t\"open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)\"\n\t, libcamera-devel@lists.libcamera.org,\n\tMauro Carvalho Chehab ,\n\tLaurent Pinchart ,\n\tRob Herring , tfiga@google.com, pavel@ucw.cz,\n\tdevicetree@vger.kernel.org","Message-ID":"<20200511072114.GC11272@paasikivi.fi.intel.com>","References":"<20200508100158.3437161-1-jacopo@jmondi.org>\n\t<20200508100158.3437161-4-jacopo@jmondi.org>\n\t\n\t<20200509082132.zpojrdqcleb2dgp2@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20200509082132.zpojrdqcleb2dgp2@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v10 03/13] dt-bindings: Add media\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 11 May 2020 07:21:26 -0000"}}]