[{"id":4772,"web_url":"https://patchwork.libcamera.org/comment/4772/","msgid":"<20200510195931.GC1354180@oden.dyn.berto.se>","date":"2020-05-10T19:59:31","subject":"Re: [libcamera-devel] [PATCH] Documentation: coding-style: Fix\n\tordered lists","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your fix.\n\nOn 2020-05-06 23:29:21 +0300, Laurent Pinchart wrote:\n> The syntax used for ordered lists is incorrect. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> Documentation/coding-style.rst | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst\n> index 95ca04f6150f..dfbbf28df8e7 100644\n> --- a/Documentation/coding-style.rst\n> +++ b/Documentation/coding-style.rst\n> @@ -72,10 +72,10 @@ self-contained.\n> \n> The headers shall be grouped and ordered as follows.\n> \n> - # The header declaring the API being implemented (if any)\n> - # The C and C++ system and standard library headers\n> - # Other libraries' headers, with one group per library\n> - # Other project's headers\n> +1. The header declaring the API being implemented (if any)\n> +2. The C and C++ system and standard library headers\n> +3. Other libraries' headers, with one group per library\n> +4. Other project's headers\n> \n> Groups of headers shall be separated by a single blank line. Headers within\n> each group shall be sorted alphabetically.\n> @@ -118,7 +118,7 @@ reference means using a reference passed by a caller without ownership transfer\n> based on the assumption that the caller guarantees the validity of the\n> reference for the duration of the operation that borrows it.\n> \n> -#. Single Owner Objects\n> +1. Single Owner Objects\n> \n> * By default an object has a single owner at any time.\n> * Storage of single owner objects varies depending on how the object\n> @@ -155,7 +155,7 @@ reference for the duration of the operation that borrows it.\n> otherwise specified, pointers passed to functions are considered as\n> borrowed references valid for the duration of the function only.\n> \n> -#. Shared Objects\n> +2. Shared Objects\n> \n> * Objects that may have multiple owners at a given time are called shared\n> objects. They are reference-counted and live as long as any references to\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 328F9603F7\n\tfor ;\n\tSun, 10 May 2020 21:59:33 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id l19so7222749lje.10\n\tfor ;\n\tSun, 10 May 2020 12:59:33 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tb2sm8160498lfi.14.2020.05.10.12.59.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 10 May 2020 12:59:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"0wUuHkEQ\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=DG180i3UyBghcQRst5sVgOtrwJIQOsMqMJzv4189UO4=;\n\tb=0wUuHkEQgBCsaN5sFoVGKuDVO8/eUtQuV/vJjzHozRtLInhXnMopOej2urQy2KsO/p\n\tGowR1py2cZlYxbmKmehiFb+tJ7ahBI8LDhODzcXUsacFlsIqj66ONDUmINpZhgCEVqJd\n\txu0kzX4Bbdc84QA1eJXWcPf5flL3vfP46tlwHOUoiwSd+tW/D606n1I2W48g2xXZzb5n\n\tecw1q+9x6KymynTt96MZE58VVzqbDGkANRA/1Ibwj4jpn9laiEPuyyWR7h+KomAdQSYG\n\tHbR46D4ZBe6Aib7wdCrYM1LLqPbf/93UH5l/rF/ROOHu1Ayqk96OTAQG0df6YK4Q/UZP\n\tQAxQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=DG180i3UyBghcQRst5sVgOtrwJIQOsMqMJzv4189UO4=;\n\tb=LpB9GaZGRu2SKIYFE07Hsl7xMTUMYnX308rNBZIELdELl54TXyIDaYUv5t+5kPkiQ5\n\t+13E15u3TjW8+zb3Q9O1TGg0GkO74u5XRpBGmd/WY06YbRmqCXKPdjxtWTloOciL1oS3\n\tB2HRLzGWn7r8gROAknfJFHw9ZCTzkqVqYpZBES8RLJYFAU+7GFfLUnhrxFF63mcgNCl6\n\tT7iebygNKrkKnityvUW0JAjKna+zDmDgboXLsQeXLX8bUbtNYAWkbAW3DEcwKXImJ58T\n\tPPO8QDWzLslAGsUnKXq6M0wCZom06ACS3qhSFJuSwwWxruvhudHZJc4ffMMa+CiykO3y\n\t/q9g==","X-Gm-Message-State":"AOAM533g4zDx9Ln9OWehwrYyuXPs5Gf5V+QGtjywFB8mxSw1n2Jv4ckB\n\ty4psHcqcP2xnAaqJOGtbQH++EA==","X-Google-Smtp-Source":"ABdhPJyHopQOOpoWPwkbalc6St2N1IfP8lAu6GhDtiqM9PoGBh0p30T5FJwUhEV+iIVLn757Fn9dyg==","X-Received":"by 2002:a2e:88d8:: with SMTP id\n\ta24mr8101461ljk.224.1589140772541; \n\tSun, 10 May 2020 12:59:32 -0700 (PDT)","Date":"Sun, 10 May 2020 21:59:31 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200510195931.GC1354180@oden.dyn.berto.se>","References":"<20200506202921.23731-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200506202921.23731-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] Documentation: coding-style: Fix\n\tordered lists","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 10 May 2020 19:59:33 -0000"}},{"id":4776,"web_url":"https://patchwork.libcamera.org/comment/4776/","msgid":"<4fa17dbf-ce66-c230-14f0-2fa4e9110e6d@ideasonboard.com>","date":"2020-05-11T08:10:09","subject":"Re: [libcamera-devel] [PATCH] Documentation: coding-style: Fix\n\tordered lists","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 06/05/2020 21:29, Laurent Pinchart wrote:\n> The syntax used for ordered lists is incorrect. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> Documentation/coding-style.rst | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst\n> index 95ca04f6150f..dfbbf28df8e7 100644\n> --- a/Documentation/coding-style.rst\n> +++ b/Documentation/coding-style.rst\n\nWow, I actually didn't realise/forgot this page existed because it has\nso little visibility.\n\nI'll try to work on improving the global site map so content can be\nidentified easily rather than being hidden through small links in other\npages.\n\n> @@ -72,10 +72,10 @@ self-contained.\n> \n> The headers shall be grouped and ordered as follows.\n> \n> - # The header declaring the API being implemented (if any)\n> - # The C and C++ system and standard library headers\n> - # Other libraries' headers, with one group per library\n> - # Other project's headers\n> +1. The header declaring the API being implemented (if any)\n> +2. The C and C++ system and standard library headers\n> +3. Other libraries' headers, with one group per library\n> +4. Other project's headers\n\nThat indentation has been changed. The formatting of the website doesn't\nupdate correctly, but that could be due to the CSS styles over the\nindentation, so I'll validate that next.\n\nOther than that,\n\nReviewed-by: Kieran Bingham \n\n> \n> Groups of headers shall be separated by a single blank line. Headers within\n> each group shall be sorted alphabetically.\n> @@ -118,7 +118,7 @@ reference means using a reference passed by a caller without ownership transfer\n> based on the assumption that the caller guarantees the validity of the\n> reference for the duration of the operation that borrows it.\n> \n> -#. Single Owner Objects\n> +1. Single Owner Objects\n> \n> * By default an object has a single owner at any time.\n> * Storage of single owner objects varies depending on how the object\n> @@ -155,7 +155,7 @@ reference for the duration of the operation that borrows it.\n> otherwise specified, pointers passed to functions are considered as\n> borrowed references valid for the duration of the function only.\n> \n> -#. Shared Objects\n> +2. Shared Objects\n> \n> * Objects that may have multiple owners at a given time are called shared\n> objects. They are reference-counted and live as long as any references to\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19DEE603E0\n\tfor ;\n\tMon, 11 May 2020 10:10:14 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EE92304;\n\tMon, 11 May 2020 10:10:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DHxv6hL5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1589184613;\n\tbh=mQs6GhyO09/tkW236PCY42I3/AKRDGMJHNp+jQjq6Ro=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=DHxv6hL5NyLqTz5leQotR42ZgzWyJvHxZzX4AVOUF/y+FOSeSb1JuJX0iC3QIygO6\n\tHV4kHSSWrZsDfzeKonKgenqxXxJ8ZXQ9Tu48phyBq95zGooFCIJF3WzmEtbm968n32\n\tgpbd8NaAjeN/94r5OHxTEa2YF1PqnAedI6+QqDnI=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200506202921.23731-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<4fa17dbf-ce66-c230-14f0-2fa4e9110e6d@ideasonboard.com>","Date":"Mon, 11 May 2020 09:10:09 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200506202921.23731-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] Documentation: coding-style: Fix\n\tordered lists","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 11 May 2020 08:10:14 -0000"}}]