[{"id":4723,"web_url":"https://patchwork.libcamera.org/comment/4723/","msgid":"<20200503003102.GC25636@pendragon.ideasonboard.com>","date":"2020-05-03T00:31:02","subject":"Re: [libcamera-devel] [PATCH] qcam: dng_writer: Remove colon from\n\t\\todo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sun, May 03, 2020 at 02:27:23AM +0200, Niklas Söderlund wrote:\n> Todo statements should not end with a colon, remove it.\n> \n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/qcam/dng_writer.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\n> index 7d51965dc2ea3201..f0d6f5f473e3d680 100644\n> --- a/src/qcam/dng_writer.cpp\n> +++ b/src/qcam/dng_writer.cpp\n> @@ -47,7 +47,7 @@ void packScanlineSBGGR12P(void *output, const void *input, unsigned int width)\n>  \tconst uint8_t *in = static_cast<const uint8_t *>(input);\n>  \tuint8_t *out = static_cast<uint8_t *>(output);\n>  \n> -\t/* \\todo: Can this be made more efficient? */\n> +\t/* \\todo Can this be made more efficient? */\n>  \tfor (unsigned int i = 0; i < width; i += 2) {\n>  \t\t*out++ = in[0];\n>  \t\t*out++ = (in[2] & 0x0f) << 4 | in[1] >> 4;","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A33E603F1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun,  3 May 2020 02:31:06 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB7F2304;\n\tSun,  3 May 2020 02:31:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"avT3ty6e\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588465865;\n\tbh=GRAk4hGgFIJVTlTcdvXaQ9cu0ful4R7Prgccq4Eoo0g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=avT3ty6eF/qEdWt0Px/pUlhx+3hkw3q8UkOXnpelglDECk4jBLFDtJiaqG1lk8Ceb\n\tS8wcRDiku8HblovfRiiF1dAdZO3w0//pRzPgAnuaBCaWDaQNuUAtGpuFJuRDVUsvVu\n\t80leh/E9K3xUihvz8aYQGSrf2essvCeCigP/hPzk=","Date":"Sun, 3 May 2020 03:31:02 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200503003102.GC25636@pendragon.ideasonboard.com>","References":"<20200503002723.1367196-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200503002723.1367196-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] qcam: dng_writer: Remove colon from\n\t\\todo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 03 May 2020 00:31:06 -0000"}}]