[{"id":4726,"web_url":"https://patchwork.libcamera.org/comment/4726/","msgid":"<20200503005047.GB3012491@oden.dyn.berto.se>","date":"2020-05-03T00:50:47","subject":"Re: [libcamera-devel] [PATCH 2/5] qcam: dng_writer: Name arguments\n\tto packScanline()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-05-03 01:57:01 +0300, Laurent Pinchart wrote:\n> Name arguments to the FormatInfo::packScanline function pointer to make\n> it easier to understand its usage when reading the function declaration.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/qcam/dng_writer.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\n> index b1984c6647dd..d5270323abd4 100644\n> --- a/src/qcam/dng_writer.cpp\n> +++ b/src/qcam/dng_writer.cpp\n> @@ -23,7 +23,8 @@ enum CFAPatternColour : uint8_t {\n> struct FormatInfo {\n> \tuint8_t bitsPerSample;\n> \tCFAPatternColour pattern[4];\n> -\tvoid (*packScanline)(void *, const void *, unsigned int);\n> +\tvoid (*packScanline)(void *output, const void *input,\n> +\t\t\t unsigned int width);\n> };\n> \n> void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37835603F1\n\tfor ;\n\tSun, 3 May 2020 02:50:49 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id j14so6713241lfg.9\n\tfor ;\n\tSat, 02 May 2020 17:50:49 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tv8sm5443433lfp.85.2020.05.02.17.50.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 02 May 2020 17:50:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"nNHh52BZ\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=/gRlUuF3jYD4l+0yM+Bbuof06GQdW2Mf6okqhz2/aZ0=;\n\tb=nNHh52BZCaTDjTXDWWMUGKYX/LVyBpvZVUXX41xzeeCnocfWYPZStqj67unYEHb73l\n\tpLJ/T47VJoR6iGhz6tbsoQ1qiRMLThE2lUYIojb4oV3sb3jK78uXM+jjuWD1yfSZW7Jl\n\tgGo/vhh22txal2ABYLD0woloD43+iSa9xz+1o9xQZ0hA58z8SVkbRrXDCoYMHfsk13r9\n\tlW5wlveAaHle5iKiP36bSLhnNswG8jiINHFTNrGYZZV3u357SRM+EEZTpDMlY9FYjOMZ\n\t3J5mb4XDhAI0FKVy8hJm/OoafJR8ll196+AxI484ECX3dqP4Gyn7wywpO0h1xUlHbEtA\n\tHCzw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=/gRlUuF3jYD4l+0yM+Bbuof06GQdW2Mf6okqhz2/aZ0=;\n\tb=cAny+KFqZUBZ30xHq7UmimptlpZLKRQHli0cDoJeW1HFR19I7sDgitjZK5CDP4nhP7\n\twSv4XurmEWjGpaQ5DdZxTm34SMwJ3OBh0uWpDZbeb1/Kjx8OeoVlsLJ8khxK5dV4Brpn\n\tYdlJ4P464m9xiwz5Izn06bD0A5oHu19gfAj3vzteDGErsrnpRy6Bv+0EARqRrlWv+mRF\n\tt8Xsxy8dBnc1hWNZKIRpvBcVutOBfMHtgW4t+br1Q0PdSzj9gKcGYw5GgilPRV4uzSNp\n\tOdi0lVGCRFXPg8yuMyVRTm7IWKlPZknsyGjMhewIX+7OtuBMfGAcyfjdtg7b7swnFKcH\n\thgWw==","X-Gm-Message-State":"AGi0Pub78ouJnbr+fkUXcTPS4v8h4f8D33cOx+XUkX+0UyaQOKkvRE5P\n\tcChvzgJGVxGBon90oSyE9zAgrkfdFPs=","X-Google-Smtp-Source":"APiQypLRHK85lQG985TXB/7iqEKGrsEZy0yVdDVW+8WR78Xd1EDTRr8FzrEnX9bogV6s5e86v7Y/vQ==","X-Received":"by 2002:ac2:5a11:: with SMTP id q17mr1876214lfn.44.1588467048656;\n\tSat, 02 May 2020 17:50:48 -0700 (PDT)","Date":"Sun, 3 May 2020 02:50:47 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200503005047.GB3012491@oden.dyn.berto.se>","References":"<20200502225704.2911-1-laurent.pinchart@ideasonboard.com>\n\t<20200502225704.2911-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200502225704.2911-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/5] qcam: dng_writer: Name arguments\n\tto packScanline()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 03 May 2020 00:50:49 -0000"}}]