[{"id":4722,"web_url":"https://patchwork.libcamera.org/comment/4722/","msgid":"<20200502215229.GA25636@pendragon.ideasonboard.com>","date":"2020-05-02T21:52:29","subject":"Re: [libcamera-devel] [PATCH] qcam: DNGWriter: Fix missing field\n\tname","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sat, May 02, 2020 at 11:26:43PM +0200, Niklas Söderlund wrote:\n> While reformatting the table the field name was missed for one entry,\n> add it.\n> \n> Fixes: db7235b7141aa4e2 (\"qcam: Add DNGWriter\")\n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nI have the same fix in my tree :-)\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/qcam/dng_writer.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\n> index 08078369529bb780..7d51965dc2ea3201 100644\n> --- a/src/qcam/dng_writer.cpp\n> +++ b/src/qcam/dng_writer.cpp\n> @@ -65,7 +65,7 @@ static const std::map<PixelFormat, FormatInfo> formatInfo = {\n>  \t{ PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n>  \t\t.bitsPerSample = 10,\n>  \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n> -\t\tpackScanlineSBGGR10P,\n> +\t\t.packScanline = packScanlineSBGGR10P,\n>  \t} },\n>  \t{ PixelFormat(DRM_FORMAT_SGRBG10, MIPI_FORMAT_MOD_CSI2_PACKED), {\n>  \t\t.bitsPerSample = 10,","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C90FB603FD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat,  2 May 2020 23:52:33 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF0D0521;\n\tSat,  2 May 2020 23:52:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XQYz8hur\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588456353;\n\tbh=0WDlBtbPHPRETEeifxjLfMSsWR4T5gPv5efLnS+kNag=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XQYz8hurfvrlgoYItwgNVENSuFCYXArPdZ2oIh5ELzM3DjxjXmu76pYJ2k0uVOKQC\n\ty2AKKjQsrsFvdGOBJcz3GhOA3Nh2Ob0YpQvQNrGtWLeTWHGnXaz4g30Zq/TL5J/G6P\n\t7R2X/y2pjEl2RtXgqgRyd6rmbeIsgSk6lc66sIHs=","Date":"Sun, 3 May 2020 00:52:29 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200502215229.GA25636@pendragon.ideasonboard.com>","References":"<20200502212643.1281485-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200502212643.1281485-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] qcam: DNGWriter: Fix missing field\n\tname","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 02 May 2020 21:52:34 -0000"}}]