[{"id":4731,"web_url":"https://patchwork.libcamera.org/comment/4731/","msgid":"<20200503012925.GG3012491@oden.dyn.berto.se>","date":"2020-05-03T01:29:25","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: camera_sensor: Store\n\tsubdevice in std::unique_ptr","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-05-02 16:53:54 +0300, Laurent Pinchart wrote:\n> Avoid the need for a manual delete in the destructor by using a unique\n> pointer.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera_sensor.cpp | 5 ++---\n> src/libcamera/include/camera_sensor.h | 3 ++-\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index ab2bed561cc6..9cfb3847dda6 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -133,7 +133,6 @@ LOG_DEFINE_CATEGORY(CameraSensor);\n> CameraSensor::CameraSensor(const MediaEntity *entity)\n> \t: entity_(entity), properties_(properties::properties)\n> {\n> -\tsubdev_ = new V4L2Subdevice(entity);\n> }\n> \n> /**\n> @@ -141,7 +140,6 @@ CameraSensor::CameraSensor(const MediaEntity *entity)\n> */\n> CameraSensor::~CameraSensor()\n> {\n> -\tdelete subdev_;\n> }\n> \n> /**\n> @@ -197,7 +195,8 @@ int CameraSensor::init()\n> \telse\n> \t\tmodel_ = entityName;\n> \n> -\t/* Open the subdev. */\n> +\t/* Create and open the subdev. */\n> +\tsubdev_ = std::make_unique(entity_);\n> \tret = subdev_->open();\n> \tif (ret < 0)\n> \t\treturn ret;\n> diff --git a/src/libcamera/include/camera_sensor.h b/src/libcamera/include/camera_sensor.h\n> index f39ea96dc77a..92cd90353e72 100644\n> --- a/src/libcamera/include/camera_sensor.h\n> +++ b/src/libcamera/include/camera_sensor.h\n> @@ -7,6 +7,7 @@\n> #ifndef __LIBCAMERA_CAMERA_SENSOR_H__\n> #define __LIBCAMERA_CAMERA_SENSOR_H__\n> \n> +#include \n> #include \n> #include \n> \n> @@ -68,7 +69,7 @@ protected:\n> \n> private:\n> \tconst MediaEntity *entity_;\n> -\tV4L2Subdevice *subdev_;\n> +\tstd::unique_ptr subdev_;\n> \tstd::string model_;\n> \n> \tstd::vector mbusCodes_;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E707603F0\n\tfor ;\n\tSun, 3 May 2020 03:29:27 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id l11so6753474lfc.5\n\tfor ;\n\tSat, 02 May 2020 18:29:27 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tf10sm5566292lfl.82.2020.05.02.18.29.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 02 May 2020 18:29:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"nj2lRWjs\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=TbFNRAa43YPyNVKaLS998R69z3ctF86MQCYlkzyBG/c=;\n\tb=nj2lRWjspuL3BzyMyrIabjPyS8etQMWGqdhxVWoLiVwlJGTeDhzJE834jzvE1YXnJC\n\t9BXfs/sv7ffjB23tE0+DuMMHZ9Mc175c9+D87jPsC3ePSoH3SbvT2I+sceDpNZuH7EdJ\n\tBL26eB1Gac0WKt5HsUcfoWfUxCKQE9nlGK+iEY3uGHLr2gVR/xOthdyocpFBdCbXiRJr\n\tjwSUZwP/TyeUMNtUu+HQkdeULURtsR6V14c8324TTYPLm1GtPpMM83KA/Cnx4J7uAIyw\n\ts4J2ySaqn4HzkPJTYVscSLCrc2JSv+PC+JlJ5gYEew0QomfmCZyJCFyo0YAvBJRNGGfH\n\tEifA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=TbFNRAa43YPyNVKaLS998R69z3ctF86MQCYlkzyBG/c=;\n\tb=kM1g+JoBtl2p6jMVhDCQAlDN/1Q+HqUjX+11ILbKiF9HvZNACbxUIo2GvowwuSy05c\n\tEDQkJcbt3SY4z0oPyrCgZp+Kdgf/QjQvl1vl3kOdwPbJhwqu1eglaZZIe4KEwu3tmh65\n\tA7U5NeUGfhYgaLfE9RpeD2u5dbOB/pWq5U1c8kWpqVeEAOSIUUcPIKlKGw/NiNMZ/4nk\n\tvmQiZ9GljVjOzjjpAB6yJmctjf3A3OTchNeXTiA8GrYos8fpCIBLXXBOcp9RoKIHMSZf\n\tDFm+zo6uCwLoblbM0zYgVKAzBToRvDnoT1IQAAYXnCUFl3KWmWTseUE7BTXQziv2/AnP\n\tQ+lA==","X-Gm-Message-State":"AGi0PuZ+Fn8QY+82h3BEhvD9u0vmc4442smzj9qcFcvwEhJvhl0p5dtc\n\tyzph1j8jYU2/MFWTZng0QIJzjQ==","X-Google-Smtp-Source":"APiQypJ2/lVDDDramOAsG5wSegA2Oj10cpso+5TIlNBISzAQaONaLaQ4GHmJVpQJIoWgQS+bsum92w==","X-Received":"by 2002:a05:6512:1111:: with SMTP id\n\tl17mr6960942lfg.206.1588469366494; \n\tSat, 02 May 2020 18:29:26 -0700 (PDT)","Date":"Sun, 3 May 2020 03:29:25 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200503012925.GG3012491@oden.dyn.berto.se>","References":"<20200502135355.22757-1-laurent.pinchart@ideasonboard.com>\n\t<20200502135355.22757-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200502135355.22757-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: camera_sensor: Store\n\tsubdevice in std::unique_ptr","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 03 May 2020 01:29:27 -0000"}}]