[{"id":4730,"web_url":"https://patchwork.libcamera.org/comment/4730/","msgid":"<20200503012802.GF3012491@oden.dyn.berto.se>","date":"2020-05-03T01:28:02","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Access\n\tentity directly","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-05-02 16:53:53 +0300, Laurent Pinchart wrote:\n> The CameraSensor::logPrefix() function accesses the entity from the\n> subdev. Remove the level of indirection as we stored a pointer to the\n> entity internally.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera_sensor.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index d7e11cdae7f0..ab2bed561cc6 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -539,7 +539,7 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const\n> \n> std::string CameraSensor::logPrefix() const\n> {\n> -\treturn \"'\" + subdev_->entity()->name() + \"'\";\n> +\treturn \"'\" + entity_->name() + \"'\";\n> }\n> \n> } /* namespace libcamera */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4021D603F0\n\tfor ;\n\tSun, 3 May 2020 03:28:04 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id j14so6744322lfg.9\n\tfor ;\n\tSat, 02 May 2020 18:28:04 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tt16sm4871495ljo.6.2020.05.02.18.28.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 02 May 2020 18:28:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"kAzpDt5b\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=KQoticd4/7YbBzt/3J/sqfiibuDyC6n7sHG/e3S82Q8=;\n\tb=kAzpDt5bohTF3bc9DU0unj6boq7cUbprRG5RaG1p4zEhIW7GBGbpRVDmMglNLscxQT\n\t/bww5AkeePWQxmNWUrve/rTHg+6uMZdWz7xSqQ42cSXK3iRusDy6fIPVLaPsoW1cZ1AW\n\tLUQJDNymJDdKh4O97GbVtuMzGixZu1jf7mKfYELgjZyL+KcVqk2l2biP87Tx0KIEi6KS\n\tWvKodkVNsF82lkijGDl4u/WSKCnDp8UOuhME8VqGLZfNBf5wDjYQMiHLWwE/SoFU09MQ\n\tkK8evCJIb+MHDOwFUi1xQQ5ZvW5ObL/600sPsscjS2gPq6xT1nJbhXxhyGxrWLCXjmNH\n\t+IlQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=KQoticd4/7YbBzt/3J/sqfiibuDyC6n7sHG/e3S82Q8=;\n\tb=PCnv9esgh5d10hs+Qd1AAq1vW8/Gldv5I850Ky1RP5/0PWJh4tgmRManBWd1ptlkB8\n\tpGdrtkuViQN06b0go6uuhbq6/VMGPaR+bKSSQ4YOYbnFKC1wf7j/KUf4EEaiEgZ3Z65P\n\tYBcuqypwm43+yn0p6hQVpDRv+sbj5Zf91D3KfG5TUvDDAYmamPrhdWefm5Tt5cAH6GtL\n\tdA/Hnciw0LD6aRzMa5ttwyTajGn/VOuQyY5Hbv4yE7jccc1NXXjtOrYEhdNpWlfaWmlp\n\t5SSUq2fEazPtsh2WmFOuljlhNy0BFs0dQYGTwh5Gip+ZjFQqVJhcIoMjASohGG7OGy0O\n\tMl8Q==","X-Gm-Message-State":"AGi0PuaKTBlwX0igRH+ae58qvqWElAyPX/M7OKNMKco5GqljGog58gbF\n\tAMKmlBGjG5sQMBsbp9CJIMSadw==","X-Google-Smtp-Source":"APiQypI1gAqZA7Tbg7x8bzptQHExEP8viPuOiC795OMcLnZecgE14ic/L3+LNh1VkLxSgZr2cur93Q==","X-Received":"by 2002:a05:6512:53a:: with SMTP id\n\to26mr7019178lfc.111.1588469283674; \n\tSat, 02 May 2020 18:28:03 -0700 (PDT)","Date":"Sun, 3 May 2020 03:28:02 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200503012802.GF3012491@oden.dyn.berto.se>","References":"<20200502135355.22757-1-laurent.pinchart@ideasonboard.com>\n\t<20200502135355.22757-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200502135355.22757-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Access\n\tentity directly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 03 May 2020 01:28:04 -0000"}}]