{"id":3648,"url":"https://patchwork.libcamera.org/api/patches/3648/?format=json","web_url":"https://patchwork.libcamera.org/patch/3648/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200501023432.90032-7-niklas.soderlund@ragnatech.se>","date":"2020-05-01T02:34:32","name":"[libcamera-devel,v3,6/6] qcam: Check that camera can generate configuration from roles","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"84cc640d44d93b86f6424952c80d0eafe4fc6500","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3648/mbox/","series":[{"id":864,"url":"https://patchwork.libcamera.org/api/series/864/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=864","date":"2020-05-01T02:34:27","name":"{cam, qcam}: Unify stream option parsing","version":3,"mbox":"https://patchwork.libcamera.org/series/864/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3648/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3648/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D47606148D\n\tfor ;\n\tFri, 1 May 2020 04:34:45 +0200 (CEST)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 50ba9d6b-8b54-11ea-89d0-0050569116f7;\n\tFri, 01 May 2020 04:34:43 +0200 (CEST)"],"X-Halon-ID":"50ba9d6b-8b54-11ea-89d0-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 1 May 2020 04:34:32 +0200","Message-Id":"<20200501023432.90032-7-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.26.2","In-Reply-To":"<20200501023432.90032-1-niklas.soderlund@ragnatech.se>","References":"<20200501023432.90032-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 6/6] qcam: Check that camera can\n\tgenerate configuration from roles","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 01 May 2020 02:34:46 -0000"},"content":"If the camera can not generate a configuration from the requested roles\nit returns a nullptr which leads to a nullptr dereference. Fix this by\nadding a check that the camera generated a configuration before trying\nto access it.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n src/qcam/main_window.cpp | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 74427592ea47de28..b9348111dfa28914 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -296,6 +296,10 @@ int MainWindow::startCapture()\n \n \t/* Configure the camera. */\n \tconfig_ = camera_->generateConfiguration(roles);\n+\tif (!config_) {\n+\t\tqWarning() << \"Failed to generate configuration from roles\";\n+\t\treturn -EINVAL;\n+\t}\n \n \tStreamConfiguration &cfg = config_->at(0);\n \n","prefixes":["libcamera-devel","v3","6/6"]}