[{"id":559,"web_url":"https://patchwork.libcamera.org/comment/559/","msgid":"<20190124180655.GA4127@bigcity.dyn.berto.se>","date":"2019-01-24T18:06:55","subject":"Re: [libcamera-devel] [PATCH 09/10] libcamera: pipeline: uvc: Mark\n\tthe media device as hotpluggable","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your efforts.\n\nOn 2019-01-24 12:16:50 +0200, Laurent Pinchart wrote:\n> UVC devices can be hot-unplugged. Mark the corresponding media device as\n> hotpluggable to ensure proper disconnection support.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/uvcvideo.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n> index c8f1bf553bfe..f84fa41515f1 100644\n> --- a/src/libcamera/pipeline/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo.cpp\n> @@ -49,6 +49,7 @@ bool PipelineHandlerUVC::match(DeviceEnumerator *enumerator)\n> \n> \tstd::shared_ptr camera = Camera::create(this, dev_->model());\n> \tregisterCamera(std::move(camera));\n> +\thotplugMediaDevice(dev_.get());\n> \n> \treturn true;\n> }\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82C2960C82\n\tfor ;\n\tThu, 24 Jan 2019 19:06:57 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id k19-v6so6048304lji.11\n\tfor ;\n\tThu, 24 Jan 2019 10:06:57 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\t67-v6sm1120782ljc.26.2019.01.24.10.06.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 24 Jan 2019 10:06:56 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=6wao3g9t1cbJRQ6Qpv1FjwnKjbbsC24SXJ7E7wsQ0Ls=;\n\tb=an8m0pNXGJdSntv4qQWVOdj3EvMixpCltPQ66iLK6Ib8bF0Q992uk1WRKXm4Gah1IU\n\tfBICjmjfVWSVWGfd1AMYcrfNEDa0xaWBTCeV/fan0o8zA+P0HauvqIPNdyxiF0TnFV2g\n\tKQPfNkKleKqw0Sa5eTYr/obAi5nzGVtm1DGZAPHHU3C/6FwQp9nhpmb3jtVL7Iqk8oy+\n\trGtpjAIvWrtkMkJu5vTbBWjsTZvHYOpDpfokJEiMs4V8lu0H91CFFyTW6QTyfcqWRpEt\n\tdf2ZoDzZG6WL6JjjarUUM4dQIvedLFmpu8h5fLqJaYorY52taPFqym/B5fnd3TK1Hh90\n\tuxQg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=6wao3g9t1cbJRQ6Qpv1FjwnKjbbsC24SXJ7E7wsQ0Ls=;\n\tb=DlkH3blYKNxfDEeDR9Pm7btRixJlyLTw3vl9WNeiemiIynrInGoXoJ7SfkaM92W7wR\n\tx1rwaBmL0CuVOpslBfNpxKCQq1ccNYpzV4Ip+ZE5af2v9ZqIhapRVnGoDeNa9/8l9b9T\n\tM01andvNZiTx1FYFJdbqecQc2gFhrNADF7TwrPBvXOI2dG8BmOzwWfmCpnnAGLB5WzlF\n\tDepEKh7pWdzpRHjrhsmnlkFBobQCYSI/oYxup3hQg6+UrrpLowTPoj72JO0OGAWcGb/W\n\tKPbLbkgwMCdi1z5E5tFMEm+W0XiLRk2JoWmYM4fUIjOS7OU/tBfYOJZp7WStQm/lsFcD\n\tkTqQ==","X-Gm-Message-State":"AJcUukfXuQR1MANz2SGZNF42zpHaEQyBP6+R6ZRX3QHb2asDPlPgVBe2\n\tXvrZs4djuXYR3AFe52Va2nBgxdDDcDM=","X-Google-Smtp-Source":"ALg8bN6LJ+c6A+E9Hp4ZC5Y0gEOxvYX0DzviPxCcvj7LpUmek994cpk/bWMRobXty2V0l0qRGg6dpQ==","X-Received":"by 2002:a2e:9944:: with SMTP id\n\tr4-v6mr6341472ljj.185.1548353216756; \n\tThu, 24 Jan 2019 10:06:56 -0800 (PST)","Date":"Thu, 24 Jan 2019 19:06:55 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190124180655.GA4127@bigcity.dyn.berto.se>","References":"<20190124101651.9993-1-laurent.pinchart@ideasonboard.com>\n\t<20190124101651.9993-10-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190124101651.9993-10-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 09/10] libcamera: pipeline: uvc: Mark\n\tthe media device as hotpluggable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 24 Jan 2019 18:06:57 -0000"}}]