[{"id":4673,"web_url":"https://patchwork.libcamera.org/comment/4673/","msgid":"<20200430141622.GA2124335@oden.dyn.berto.se>","date":"2020-04-30T14:16:22","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_pixelformat: Fix\n\tV4L2_PIX_FMT_SBGGR10P format","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-04-30 17:01:49 +0300, Laurent Pinchart wrote:\n> The V4L2_PIX_FMT_SBGGR10P format was misspecified as\n> V4L2_PIX_FMT_SBGGR10. Fix it.\n> \n> Fixes: 00d639d951e7 (\"libcamera: formats: Add support for 8-, 10- and 12-bit Bayer formats\")\n> Reported-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThis solves my issue,\n\nTested-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  src/libcamera/v4l2_pixelformat.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index fd7e2d286f3f..561f9327780a 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -77,7 +77,7 @@ const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n>  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10), PixelFormat(DRM_FORMAT_SGBRG10) },\n>  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10), PixelFormat(DRM_FORMAT_SGRBG10) },\n>  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10), PixelFormat(DRM_FORMAT_SRGGB10) },\n> -\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10),\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10P),\n>  \t  PixelFormat(DRM_FORMAT_SBGGR10, MIPI_FORMAT_MOD_CSI2_PACKED) },\n>  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10P),\n>  \t  PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED) },\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3388613A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 16:16:24 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id g4so6694577ljl.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 07:16:24 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tj15sm4353087lja.71.2020.04.30.07.16.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 30 Apr 2020 07:16:23 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"ITwI0S/l\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=YhSq4zHFJ+b54sWJrmZjL1ujBG7BMgX1ZjisfszMopU=;\n\tb=ITwI0S/lsWGAPph71XeB8MhnS6ZHznBIgyiTc1OjLWD0pP7GtrZ9r5FRhvyFSmtOsx\n\t8J1ajdhWE5IXLrB8k1bhKtw/TaOYn9w/JZdUdZV163FVL9jyLrzB2Y1TfSk3uwrFf5jQ\n\tkqEhsot1ksURYKkGC1uODh0fibuF4Sdhd5MAjBH2dkdJrlspSYxK3ubcMlX8PDJPN7MJ\n\tWFwcPjILFftgCazK4Uvh6fq+f889hVwvd2e+duwhRUFlD963dsX/BAfV3qBheeL/rwuK\n\tmnbC5Xp42bJjyxk2+cGMlHN5xI3QpMujOAnAYViKvB/hWbMA2vAKqn0okJ8w89gtDxU1\n\to57g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=YhSq4zHFJ+b54sWJrmZjL1ujBG7BMgX1ZjisfszMopU=;\n\tb=khlCf8t4oQWF1nRgDKqrDc6l/8FLMBMrmoW6sRFzTgXDFwdIXwqve44Ey96RsbrGYD\n\tbEfuzpap5o8Ds30Rk9yOmNEQJ9Bicv5oIMNpGUPweQQifW3LTVODTzomXSzJO7y2feix\n\tXc6HgwN1ro1Yu89Q5lslpc3ewqEARTgJaROYG05O/qS3AhDkc9Ca0ZRPITzl460fvLIh\n\t1VHNR8dKk44Ai693skWCAY5bDCQXtY8DCum8mYvXR3XK/XxBNEewmSrwzj1Zb16KKrkJ\n\tm7rMFcF87AqyKmIKPgzU3aAGK5lJGePTbiIbJvcboEqB8PZ9tD3G0Mydr2HWxB2D2bhy\n\t/eAw==","X-Gm-Message-State":"AGi0Puaiu+zxuD2ONvrHQ6xd2gXofBO0wCkzQRctN2VTrv9h9shb0NBh\n\tWsbf2C6+36hn0WvlFgcB02XoG/Bbfbs=","X-Google-Smtp-Source":"APiQypIPDiP8DwDcMax4n633y8+LpbOvhH3B3j2VzlYPPdjLP9qBUpCxvWab6N7sutoQEKrE9n1cmw==","X-Received":"by 2002:a2e:5847:: with SMTP id x7mr2359693ljd.61.1588256183991; \n\tThu, 30 Apr 2020 07:16:23 -0700 (PDT)","Date":"Thu, 30 Apr 2020 16:16:22 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200430141622.GA2124335@oden.dyn.berto.se>","References":"<20200430140149.785-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200430140149.785-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_pixelformat: Fix\n\tV4L2_PIX_FMT_SBGGR10P format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 30 Apr 2020 14:16:25 -0000"}},{"id":4674,"web_url":"https://patchwork.libcamera.org/comment/4674/","msgid":"<a4859541-2ad8-3523-49bb-afd28355c71e@ideasonboard.com>","date":"2020-04-30T14:26:27","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_pixelformat: Fix\n\tV4L2_PIX_FMT_SBGGR10P format","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 30/04/2020 15:01, Laurent Pinchart wrote:\n> The V4L2_PIX_FMT_SBGGR10P format was misspecified as\n> V4L2_PIX_FMT_SBGGR10. Fix it.\n> \n> Fixes: 00d639d951e7 (\"libcamera: formats: Add support for 8-, 10- and 12-bit Bayer formats\")\n> Reported-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nOoops.\n\nI'm sure I even looked through matching the {SGBR}s in both parts. Must\nhave missed checking/matching the Ps :-(\n\n<don't say it ... don't say it ...>\n  Maybe it would have been more visible in a table as the alignment\nwould be off ..\n<I said don't say it...> :-D\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n> ---\n>  src/libcamera/v4l2_pixelformat.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index fd7e2d286f3f..561f9327780a 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -77,7 +77,7 @@ const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n>  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10), PixelFormat(DRM_FORMAT_SGBRG10) },\n>  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10), PixelFormat(DRM_FORMAT_SGRBG10) },\n>  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10), PixelFormat(DRM_FORMAT_SRGGB10) },\n> -\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10),\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10P),\n>  \t  PixelFormat(DRM_FORMAT_SBGGR10, MIPI_FORMAT_MOD_CSI2_PACKED) },\n>  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10P),\n>  \t  PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED) },\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F1AE613A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 16:26:31 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F55D321;\n\tThu, 30 Apr 2020 16:26:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ryQ5podH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588256790;\n\tbh=w8kWuqrC4AeYtdfQ7KaPKu++C2BOBWyRW4g1lEEWpc4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ryQ5podHyCxSIVPRKCAOBBX55GnVitB5YRZ6opSY75w5p0NEBzZl6VJP5eqFBc3Kr\n\tQZLsIMRVVcuQWzokjhnYoc1Y6b0Y4Bm6yNFQfiZoSLYDbipMW9cmMEyu+pG8cMfUiJ\n\twlkJ+DB+5+qO0NzqqLB8mBfQ3LY9hxm+RfbqUzm4=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200430140149.785-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<a4859541-2ad8-3523-49bb-afd28355c71e@ideasonboard.com>","Date":"Thu, 30 Apr 2020 15:26:27 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200430140149.785-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_pixelformat: Fix\n\tV4L2_PIX_FMT_SBGGR10P format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 30 Apr 2020 14:26:31 -0000"}},{"id":4675,"web_url":"https://patchwork.libcamera.org/comment/4675/","msgid":"<20200430142718.GB2124335@oden.dyn.berto.se>","date":"2020-04-30T14:27:18","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_pixelformat: Fix\n\tV4L2_PIX_FMT_SBGGR10P format","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"On 2020-04-30 16:16:24 +0200, Niklas Söderlund wrote:\n> Hi Laurent,\n> \n> Thanks for your work.\n> \n> On 2020-04-30 17:01:49 +0300, Laurent Pinchart wrote:\n> > The V4L2_PIX_FMT_SBGGR10P format was misspecified as\n> > V4L2_PIX_FMT_SBGGR10. Fix it.\n> > \n> > Fixes: 00d639d951e7 (\"libcamera: formats: Add support for 8-, 10- and 12-bit Bayer formats\")\n> > Reported-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> This solves my issue,\n> \n> Tested-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> \n> > ---\n> >  src/libcamera/v4l2_pixelformat.cpp | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> > index fd7e2d286f3f..561f9327780a 100644\n> > --- a/src/libcamera/v4l2_pixelformat.cpp\n> > +++ b/src/libcamera/v4l2_pixelformat.cpp\n> > @@ -77,7 +77,7 @@ const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n> >  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10), PixelFormat(DRM_FORMAT_SGBRG10) },\n> >  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10), PixelFormat(DRM_FORMAT_SGRBG10) },\n> >  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10), PixelFormat(DRM_FORMAT_SRGGB10) },\n> > -\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10),\n> > +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10P),\n> >  \t  PixelFormat(DRM_FORMAT_SBGGR10, MIPI_FORMAT_MOD_CSI2_PACKED) },\n> >  \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10P),\n> >  \t  PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED) },\n> > -- \n> > Regards,\n> > \n> > Laurent Pinchart\n> > \n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n> \n> -- \n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD6D8613A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 16:27:20 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id u15so6734339ljd.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 07:27:20 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tt19sm5124756lfl.53.2020.04.30.07.27.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 30 Apr 2020 07:27:19 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"pJarczQh\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=WUbt4vVFvtLDD6g+9nJdhngCgsloXhsP5LuPjKSLI3c=;\n\tb=pJarczQhCBCEhyl6Im10cskKXF/4R7cp+V4uekEkdpd/xoin6lnuZV4GTaf4yDqdsZ\n\tsZ5Zs9sBdC0GY9mY5DSNL8P2b+OOMoVUCkiW7PRUY4PhXQs/3EEK13WmGzI1oGwFaC4n\n\tr1dOETrxRu3/rsUsVBvXXBT6kDs/FTRT9FNyOHPo+xM6aODg+ZkDN7Up9HFZIt1tbYPx\n\t5YQGbeCy8giWb4Mbxsmm81Ll4Wvm8nX+dqC17mzkBklYGeZKVe1svgwQ0k3Hw3Fg1ABt\n\t8OIWv1icjKvQUekvJYLC3x5ZA0MXZT/sXyXnF3PuXRO1gopWMeolo4pFg0puJZU8RL61\n\txZ1g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=WUbt4vVFvtLDD6g+9nJdhngCgsloXhsP5LuPjKSLI3c=;\n\tb=d2gBYFSTRXrcBgP6G++nZjvmqZaUiq0rCNFSU0HjqdKjFvVxO6P65vJZ4ZySr1QorJ\n\tD4iaMPE7JxCIuFZwWPw0SnYjtuBXzNvt72HnzCe7ldtRGeD5ySNmgDnVO2tX9cfn3UZf\n\tZrYw0nP9UY6Quk4fG/WGLnDg3t7nHgT3oS+KG4qUimIY/FDbGAT4rnCCkZf9rjiNeOOe\n\tBgErhbA/z8pDHqWo0zP15Zvp5tmQXprGe5ag0/I1hnMkmC2idM+XEEBWXuX3REUqkmcs\n\tU1Ikpa092Ups4hyMraMDk6E+m7d5Gys+1NBtlzs83vQqgXOIvejdZ+dXrGNn5ZzqH2x2\n\tcwVA==","X-Gm-Message-State":"AGi0PuZWjlrin72GYL1lISxgxXWp2V/+qqdxkgEuRB9DRRIkD6swhiTh\n\tMQxT/pvuV0bCvQ7PLpIuveHgLA==","X-Google-Smtp-Source":"APiQypL7XsXdEOgGoiN2YSSqJVCYG8sASk8wCx48KI6VkHsJrzgtPyCjk+ICGqS5PJBHyHit1H4cjA==","X-Received":"by 2002:a2e:b248:: with SMTP id n8mr2306986ljm.207.1588256840112;\n\tThu, 30 Apr 2020 07:27:20 -0700 (PDT)","Date":"Thu, 30 Apr 2020 16:27:18 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200430142718.GB2124335@oden.dyn.berto.se>","References":"<20200430140149.785-1-laurent.pinchart@ideasonboard.com>\n\t<20200430141622.GA2124335@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200430141622.GA2124335@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_pixelformat: Fix\n\tV4L2_PIX_FMT_SBGGR10P format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 30 Apr 2020 14:27:20 -0000"}}]