{"id":3633,"url":"https://patchwork.libcamera.org/api/patches/3633/?format=json","web_url":"https://patchwork.libcamera.org/patch/3633/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200430140149.785-1-laurent.pinchart@ideasonboard.com>","date":"2020-04-30T14:01:49","name":"[libcamera-devel] libcamera: v4l2_pixelformat: Fix V4L2_PIX_FMT_SBGGR10P format","commit_ref":"81ac45ba6855f5a4a9a71bbda615770c1b2046b5","pull_url":null,"state":"accepted","archived":false,"hash":"9046ceb119e609963c37e7328065da4e2d045498","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3633/mbox/","series":[{"id":859,"url":"https://patchwork.libcamera.org/api/series/859/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=859","date":"2020-04-30T14:01:49","name":"[libcamera-devel] libcamera: v4l2_pixelformat: Fix V4L2_PIX_FMT_SBGGR10P format","version":1,"mbox":"https://patchwork.libcamera.org/series/859/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3633/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3633/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F23F6613A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 16:01:53 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 744CE321\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 16:01:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"aqR9Uo/c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588255313;\n\tbh=qFgsHnOuEo3xmDIMuuqtSRDSQOIX0GG5682VS9/BOvI=;\n\th=From:To:Subject:Date:From;\n\tb=aqR9Uo/ciQnt7bUYyJjYAoPrBhMb7rjv5BEQ3uSK7YFL838xmv7pSNVC/FIk5ZS0E\n\tqojiPv5wmfURoQ+ATfDUc3bPpD0f0/+VUiX1JTkeBI89r97fv4EjLcMJaUU/aemJQG\n\ttHSEWbEqVKXd9F9ipLxVMlOo4+OdyTOq21TnU17g=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Apr 2020 17:01:49 +0300","Message-Id":"<20200430140149.785-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.25.3","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_pixelformat: Fix\n\tV4L2_PIX_FMT_SBGGR10P format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 30 Apr 2020 14:01:54 -0000"},"content":"The V4L2_PIX_FMT_SBGGR10P format was misspecified as\nV4L2_PIX_FMT_SBGGR10. Fix it.\n\nFixes: 00d639d951e7 (\"libcamera: formats: Add support for 8-, 10- and 12-bit Bayer formats\")\nReported-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/v4l2_pixelformat.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex fd7e2d286f3f..561f9327780a 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -77,7 +77,7 @@ const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10), PixelFormat(DRM_FORMAT_SGBRG10) },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG10), PixelFormat(DRM_FORMAT_SGRBG10) },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB10), PixelFormat(DRM_FORMAT_SRGGB10) },\n-\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10),\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR10P),\n \t  PixelFormat(DRM_FORMAT_SBGGR10, MIPI_FORMAT_MOD_CSI2_PACKED) },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG10P),\n \t  PixelFormat(DRM_FORMAT_SGBRG10, MIPI_FORMAT_MOD_CSI2_PACKED) },\n","prefixes":["libcamera-devel"]}