[{"id":4662,"web_url":"https://patchwork.libcamera.org/comment/4662/","msgid":"<8c5e6b73-f756-802d-470a-bfcfd658742b@ideasonboard.com>","date":"2020-04-30T08:43:46","subject":"Re: [libcamera-devel] [PATCH] libcamera: Build IPA module\n\tsignatures by default","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 30/04/2020 02:17, Laurent Pinchart wrote:\n> Commit 7206035ee609 (\"libcamera: Regenerate IPA module signatures at\n> install time\") replaced installation of the IPA module signatures with\n> an install script that signs all modules. While doing so, it\n> inadvertently also disabled generation of the signature at build time by\n> default. This breaks running libcamera binaries from the build\n> directory. Fix it.\n\nArgh, Is that because they only default to be built if they are going to\nbe installed?\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> Fixes: 7206035ee609 (\"libcamera: Regenerate IPA module signatures at install time\")\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  src/ipa/rkisp1/meson.build | 3 ++-\n>  src/ipa/vimc/meson.build   | 3 ++-\n>  2 files changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index 6c6aa82f3b29..d7127ea8d1e9 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -14,5 +14,6 @@ if ipa_sign_module\n>                    input : mod,\n>                    output : ipa_name + '.so.sign',\n>                    command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> -                  install : false)\n> +                  install : false,\n> +                  build_by_default : true)\n>  endif\n> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> index 253847e19d6b..22296a029642 100644\n> --- a/src/ipa/vimc/meson.build\n> +++ b/src/ipa/vimc/meson.build\n> @@ -14,7 +14,8 @@ if ipa_sign_module\n>                    input : mod,\n>                    output : ipa_name + '.so.sign',\n>                    command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> -                  install : false)\n> +                  install : false,\n> +                  build_by_default : true)\n>  endif\n>  \n>  subdir('data')\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1226C613A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 10:43:50 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 864D6503;\n\tThu, 30 Apr 2020 10:43:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PVb+Pe8Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588236229;\n\tbh=Bc9SViw2GwelGXn4hFy8qZuBfSBhVzVmMLvEk/yK7eQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=PVb+Pe8YZx7IqpY+2/USw9LDFazcGXFb5MC1sxilai7UIOJD5TmfIHKiWZNz5bzLq\n\t1oIUy5bgWQG8yPBcV5bJkIZlxaOJV+MNmJsBUCvhg9W8yZ0/e6KJQDUkhQo7loDHvX\n\tsdXI78jx8jTToDVoCjPaC6xK5xVra1xB6IUMR3lI=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200430011709.22801-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<8c5e6b73-f756-802d-470a-bfcfd658742b@ideasonboard.com>","Date":"Thu, 30 Apr 2020 09:43:46 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200430011709.22801-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Build IPA module\n\tsignatures by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 30 Apr 2020 08:43:50 -0000"}},{"id":4664,"web_url":"https://patchwork.libcamera.org/comment/4664/","msgid":"<20200430093553.GA2092124@oden.dyn.berto.se>","date":"2020-04-30T09:35:53","subject":"Re: [libcamera-devel] [PATCH] libcamera: Build IPA module\n\tsignatures by default","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-04-30 04:17:09 +0300, Laurent Pinchart wrote:\n> Commit 7206035ee609 (\"libcamera: Regenerate IPA module signatures at\n> install time\") replaced installation of the IPA module signatures with\n> an install script that signs all modules. While doing so, it\n> inadvertently also disabled generation of the signature at build time by\n> default. This breaks running libcamera binaries from the build\n> directory. Fix it.\n> \n> Fixes: 7206035ee609 (\"libcamera: Regenerate IPA module signatures at install time\")\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n>  src/ipa/rkisp1/meson.build | 3 ++-\n>  src/ipa/vimc/meson.build   | 3 ++-\n>  2 files changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index 6c6aa82f3b29..d7127ea8d1e9 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -14,5 +14,6 @@ if ipa_sign_module\n>                    input : mod,\n>                    output : ipa_name + '.so.sign',\n>                    command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> -                  install : false)\n> +                  install : false,\n> +                  build_by_default : true)\n>  endif\n> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> index 253847e19d6b..22296a029642 100644\n> --- a/src/ipa/vimc/meson.build\n> +++ b/src/ipa/vimc/meson.build\n> @@ -14,7 +14,8 @@ if ipa_sign_module\n>                    input : mod,\n>                    output : ipa_name + '.so.sign',\n>                    command : [ ipa_sign, ipa_priv_key, '@INPUT@', '@OUTPUT@' ],\n> -                  install : false)\n> +                  install : false,\n> +                  build_by_default : true)\n>  endif\n>  \n>  subdir('data')\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2290603F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 11:35:55 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id y3so661167lfy.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 02:35:55 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t137sm4363327lfa.48.2020.04.30.02.35.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 30 Apr 2020 02:35:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"TN+sPKpQ\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=ht3kv4fPnxW92oJyxlzPbWHB5TxAncLZlmggpuYdeF4=;\n\tb=TN+sPKpQZ+kV+bDlG3mNO+jeqnrVHpJHB3UF8Z5fJLAzuF8Txxa0ihiEdhSSZOp+LX\n\toriQ/fX4xnanw4Y++7BeHHGk6He+77Kx/hnLPT8wiMf17vz0lM9Xo3fnYpplHSqnJZGq\n\tDHdEYtFGR1wBAznppgNrmeP/S1xp6r2/C6FuYYiuA6R1CN6BBN1IOYkp9+nYVUW85SkV\n\toxZGaRl64ypymj1yNDvCDC/3QQcah9z7kmhdZrK/A+82WLQd4hAVC+IB/orqDipnt8mc\n\tfe50ZUI/Qvo8iWqlnvakr3GOOGwokkN6S6ZeLX6KX8v6aDLWBG2slnSXOu/3D3cILfXV\n\tSwJw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=ht3kv4fPnxW92oJyxlzPbWHB5TxAncLZlmggpuYdeF4=;\n\tb=lN+4ObnSLxsE7aQiUjJ/60GPXkx7XaX1Dsnx/rrL/mwqcv7Sp5fVF0zP4FLySkhUs/\n\t5WU6slcJBlXuLjMyRZWqfnOgc1N+XIlPqXdHLW/h6BG02Q3Xbpp1GTMFQ7RDk+W1eMyi\n\tC15Yz3eqHIfk+roy64oUlts3XMrS6MSOqs2+r6ZZn+ChtgGKcquQfYnLpO5SA/eZej3r\n\trwuuFOpGvMmlqPUQeXa4tBZ0bjX/dPB4h4p+7fwSf99rt2bXo3DZPdacSwx2yUWikm/P\n\tLJjWN+4ribH8mtgEsXZsbAcXyTT2Lp+qGVnLSxaznTVXxltRoc9/fahLxMZzEJxRoU0R\n\tUUMQ==","X-Gm-Message-State":"AGi0PuZpf6A6PHSsf9mHQXbvZ8CBqGKq51V5BRQA+CQdZYFAaM9Tokr7\n\tgK0iCXWoOaqi35PT6nfsBI0wiQ==","X-Google-Smtp-Source":"APiQypIlJE40ZGaC/Vonr1rRYMU5PkarXtjIeTcuDGT3EGu0hi8CeMCuC9J4SrJ8P4zeV7vvOqWeYg==","X-Received":"by 2002:a19:e041:: with SMTP id g1mr1518773lfj.70.1588239354909; \n\tThu, 30 Apr 2020 02:35:54 -0700 (PDT)","Date":"Thu, 30 Apr 2020 11:35:53 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200430093553.GA2092124@oden.dyn.berto.se>","References":"<20200430011709.22801-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200430011709.22801-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Build IPA module\n\tsignatures by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 30 Apr 2020 09:35:56 -0000"}}]