[{"id":4660,"web_url":"https://patchwork.libcamera.org/comment/4660/","msgid":"<82e0c590-85a2-9593-1c14-be1eebebeb96@ideasonboard.com>","date":"2020-04-30T08:15:39","subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: v4l2_pixelformat: Use\n\tmaps to convert between DRM and V4L2","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 30/04/2020 01:52, Laurent Pinchart wrote:\n> Replace the two big manual switch...case with maps. This should not just\n> improve efficiency when we will have a larger number of formats, but\n> also paves the way to storing more format information to create\n> additional helpers.\n> \n\nGreat, I quite disliked those switches.\n\nDo you foresee a common shared table between V4L2PixelFormat and\nPixelFormat at all? Or should all the common components be obtained by\nreferencing them from the PixelFormat?\n\nIn fact, reading below - PixelFormatInfo is in fact that part, but here\nit's living in v4l2_pixelformat.cpp rather than pixel_format.cpp .. hrmm\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  src/libcamera/v4l2_pixelformat.cpp | 204 +++++++++++++++--------------\n>  1 file changed, 106 insertions(+), 98 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 876f5de321f6..e1c96b9862c3 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -41,6 +41,103 @@ LOG_DECLARE_CATEGORY(V4L2)\n>   * explicit value() and implicit uint32_t conversion operators may be used.\n>   */\n>  \n> +namespace {\n> +\n> +struct PixelFormatInfo {\n> +\t/* \\todo Add support for non-contiguous memory planes */\n> +\tV4L2PixelFormat v4l2Format;\n> +};\n> +\n> +const std::map<PixelFormat, PixelFormatInfo> pf2vpf{\n> +\t/* RGB formats. */\n> +\t{ PixelFormat(DRM_FORMAT_BGR888), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGB24),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_RGB888), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_BGR24),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_ABGR8888), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGBA32),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_ARGB8888), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_ABGR32),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_BGRA8888), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_ARGB32),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_RGBA8888), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_BGRA32),\n> +\t} },\n> +\n> +\t/* YUV packed formats. */\n> +\t{ PixelFormat(DRM_FORMAT_YUYV), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YUYV),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_YVYU), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YVYU),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_UYVY), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_UYVY),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_VYUY), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_VYUY),\n> +\t} },\n> +\n> +\t/* YUV planar formats. */\n> +\t{ PixelFormat(DRM_FORMAT_NV16), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV16),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_NV61), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV61),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_NV12), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV12),\n> +\t} },\n> +\t{ PixelFormat(DRM_FORMAT_NV21), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_NV21),\n> +\t} },\n> +\n> +\t/* Greyscale formats. */\n> +\t{ PixelFormat(DRM_FORMAT_R8), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_GREY),\n> +\t} },\n> +\n> +\t/* Compressed formats. */\n> +\t{ PixelFormat(DRM_FORMAT_MJPEG), {\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_MJPEG),\n> +\t} },\n> +};\n> +\n> +const std::map<V4L2PixelFormat, PixelFormat> vpf2pf{\n> +\t/* RGB formats. */\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), PixelFormat(DRM_FORMAT_BGR888) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), PixelFormat(DRM_FORMAT_RGB888) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), PixelFormat(DRM_FORMAT_ABGR8888) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), PixelFormat(DRM_FORMAT_ARGB8888) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_ARGB32), PixelFormat(DRM_FORMAT_BGRA8888) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_BGRA32), PixelFormat(DRM_FORMAT_RGBA8888) },\n> +\n> +\t/* YUV packed formats. */\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_YUYV), PixelFormat(DRM_FORMAT_YUYV) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_YVYU), PixelFormat(DRM_FORMAT_YVYU) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_UYVY), PixelFormat(DRM_FORMAT_UYVY) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_VYUY), PixelFormat(DRM_FORMAT_VYUY) },\n\nI was concerned that this was a lot of duplication, and that we could\ninstead do this all in one table, but I think this is correct because we\nneed to be able to do many-to-one VPF->PF conversion to cater for the\nmultiplanar formats also going to the DRM format with a modifier or such...\n\nSo ... carry on ...\n\n> +\n> +\t/* YUV planar formats. */\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_NV16), PixelFormat(DRM_FORMAT_NV16) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_NV61), PixelFormat(DRM_FORMAT_NV61) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_NV12), PixelFormat(DRM_FORMAT_NV12) },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_NV21), PixelFormat(DRM_FORMAT_NV21) },\n> +\n> +\t/* Greyscale formats. */\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_GREY), PixelFormat(DRM_FORMAT_R8) },\n> +\n> +\t/* Compressed formats. */\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_MJPEG), PixelFormat(DRM_FORMAT_MJPEG) },\n> +};\n> +\n> +} /* namespace */\n> +\n>  /**\n>   * \\fn V4L2PixelFormat::V4L2PixelFormat()\n>   * \\brief Construct a V4L2PixelFormat with an invalid format\n> @@ -109,60 +206,15 @@ std::string V4L2PixelFormat::toString() const\n>   */\n>  PixelFormat V4L2PixelFormat::toPixelFormat() const\n>  {\n> -\tswitch (fourcc_) {\n> -\t/* RGB formats. */\n> -\tcase V4L2_PIX_FMT_RGB24:\n> -\t\treturn PixelFormat(DRM_FORMAT_BGR888);\n> -\tcase V4L2_PIX_FMT_BGR24:\n> -\t\treturn PixelFormat(DRM_FORMAT_RGB888);\n> -\tcase V4L2_PIX_FMT_RGBA32:\n> -\t\treturn PixelFormat(DRM_FORMAT_ABGR8888);\n> -\tcase V4L2_PIX_FMT_ABGR32:\n> -\t\treturn PixelFormat(DRM_FORMAT_ARGB8888);\n> -\tcase V4L2_PIX_FMT_ARGB32:\n> -\t\treturn PixelFormat(DRM_FORMAT_BGRA8888);\n> -\tcase V4L2_PIX_FMT_BGRA32:\n> -\t\treturn PixelFormat(DRM_FORMAT_RGBA8888);\n> -\n> -\t/* YUV packed formats. */\n> -\tcase V4L2_PIX_FMT_YUYV:\n> -\t\treturn PixelFormat(DRM_FORMAT_YUYV);\n> -\tcase V4L2_PIX_FMT_YVYU:\n> -\t\treturn PixelFormat(DRM_FORMAT_YVYU);\n> -\tcase V4L2_PIX_FMT_UYVY:\n> -\t\treturn PixelFormat(DRM_FORMAT_UYVY);\n> -\tcase V4L2_PIX_FMT_VYUY:\n> -\t\treturn PixelFormat(DRM_FORMAT_VYUY);\n> -\n> -\t/* YUY planar formats. */\n> -\tcase V4L2_PIX_FMT_NV16:\n> -\tcase V4L2_PIX_FMT_NV16M:\n> -\t\treturn PixelFormat(DRM_FORMAT_NV16);\n> -\tcase V4L2_PIX_FMT_NV61:\n> -\tcase V4L2_PIX_FMT_NV61M:\n> -\t\treturn PixelFormat(DRM_FORMAT_NV61);\n> -\tcase V4L2_PIX_FMT_NV12:\n> -\tcase V4L2_PIX_FMT_NV12M:\n> -\t\treturn PixelFormat(DRM_FORMAT_NV12);\n> -\tcase V4L2_PIX_FMT_NV21:\n> -\tcase V4L2_PIX_FMT_NV21M:\n> -\t\treturn PixelFormat(DRM_FORMAT_NV21);\n> -\n> -\t/* Greyscale formats. */\n> -\tcase V4L2_PIX_FMT_GREY:\n> -\t\treturn PixelFormat(DRM_FORMAT_R8);\n> -\n> -\t/* Compressed formats. */\n> -\tcase V4L2_PIX_FMT_MJPEG:\n> -\t\treturn PixelFormat(DRM_FORMAT_MJPEG);\n> -\n> -\t/* V4L2 formats not yet supported by DRM. */\n> -\tdefault:\n> +\tconst auto iter = vpf2pf.find(*this);\n> +\tif (iter == vpf2pf.end()) {\n>  \t\tLOG(V4L2, Warning)\n>  \t\t\t<< \"Unsupported V4L2 pixel format \"\n>  \t\t\t<< toString();\n>  \t\treturn PixelFormat();\n>  \t}\n> +\n> +\treturn iter->second;\n>  }\n>  \n>  /**\n> @@ -181,60 +233,16 @@ PixelFormat V4L2PixelFormat::toPixelFormat() const\n>  V4L2PixelFormat V4L2PixelFormat::fromPixelFormat(const PixelFormat &pixelFormat,\n>  \t\t\t\t\t\t bool multiplanar)\n>  {\n> -\tswitch (pixelFormat) {\n> -\t/* RGB formats. */\n> -\tcase DRM_FORMAT_BGR888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_RGB24);\n> -\tcase DRM_FORMAT_RGB888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_BGR24);\n> -\tcase DRM_FORMAT_ABGR8888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_RGBA32);\n> -\tcase DRM_FORMAT_ARGB8888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_ABGR32);\n> -\tcase DRM_FORMAT_BGRA8888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_ARGB32);\n> -\tcase DRM_FORMAT_RGBA8888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_BGRA32);\n> -\n> -\t/* YUV packed formats. */\n> -\tcase DRM_FORMAT_YUYV:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_YUYV);\n> -\tcase DRM_FORMAT_YVYU:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_YVYU);\n> -\tcase DRM_FORMAT_UYVY:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_UYVY);\n> -\tcase DRM_FORMAT_VYUY:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_VYUY);\n> -\n> -\t/*\n> -\t * YUY planar formats.\n> -\t * \\todo Add support for non-contiguous memory planes\n> -\t * \\todo Select the format variant not only based on \\a multiplanar but\n> -\t * also take into account the formats supported by the device.\n\nThis todo is dropped, but indeed the generic V4L2PixelFormat class\nshouldn't care too much about the capabilities of the device.\n\n> -\t */\n> -\tcase DRM_FORMAT_NV16:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV16);\n> -\tcase DRM_FORMAT_NV61:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV61);\n> -\tcase DRM_FORMAT_NV12:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV12);\n> -\tcase DRM_FORMAT_NV21:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV21);\n> -\n> -\t/* Greyscale formats. */\n> -\tcase DRM_FORMAT_R8:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_GREY);\n> -\n> -\t/* Compressed formats. */\n> -\tcase DRM_FORMAT_MJPEG:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_MJPEG);\n> -\n> -\tdefault:\n> +\tconst auto iter = pf2vpf.find(pixelFormat);\n> +\tif (iter == pf2vpf.end()) {\n>  \t\tLOG(V4L2, Warning)\n>  \t\t\t<< \"Unsupported pixel format \"\n>  \t\t\t<< pixelFormat.toString();\n>  \t\treturn V4L2PixelFormat();\n>  \t}\n> +\n> +\tconst PixelFormatInfo &info = iter->second;\n> +\treturn info.v4l2Format;\n>  }\n>  \n>  } /* namespace libcamera */\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C70C613A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 10:15:42 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3BD3503;\n\tThu, 30 Apr 2020 10:15:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nhkkClg5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588234542;\n\tbh=FVIRL/VPSTo5trvlPF9WM3P4oGJ/bZ9q6rIK9UwotDg=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=nhkkClg5kK4J1wYZY09t5Ka2+oVLMWmnCrlBzvommPDJJtA6FC7ogBEOQherQISB9\n\tXZtc1taM36V/Sw2BQLs0M4iPH+v0bYlKLiEMygSfvkWKNZzAVnrPTjEw3wzvldsaCz\n\t8hTrd6svi4QDyg/xReh5CBZ6Biq858gQxAju6xk4=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200430005226.18162-1-laurent.pinchart@ideasonboard.com>\n\t<20200430005226.18162-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<82e0c590-85a2-9593-1c14-be1eebebeb96@ideasonboard.com>","Date":"Thu, 30 Apr 2020 09:15:39 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200430005226.18162-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 3/4] libcamera: v4l2_pixelformat: Use\n\tmaps to convert between DRM and V4L2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 30 Apr 2020 08:15:42 -0000"}}]