[{"id":4659,"web_url":"https://patchwork.libcamera.org/comment/4659/","msgid":"<289b5217-0476-676c-db7d-95f35cd0c74c@ideasonboard.com>","date":"2020-04-30T08:05:01","subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: v4l2_pixelformat: Move\n\tDRM/V4L2 format conversion","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 30/04/2020 01:52, Laurent Pinchart wrote:\n> Move the DRM/V4L2 format conversion code from V4L2VideoDevice to\n> V4L2PixelFormat. This is a more natural home for the code.\n> \n\nOn 30/04/2020 08:55, Kieran Bingham wrote:\n> Quite happy to see this in fact.\n\n- Particularly because of this.\n\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  src/libcamera/include/v4l2_pixelformat.h     |   4 +\n>  src/libcamera/include/v4l2_videodevice.h     |   3 -\n>  src/libcamera/pipeline/uvcvideo/uvcvideo.cpp |   2 +-\n>  src/libcamera/v4l2_pixelformat.cpp           | 134 +++++++++++++++++\n>  src/libcamera/v4l2_videodevice.cpp           | 147 +------------------\n>  test/libtest/buffer_source.cpp               |   4 +-\n>  6 files changed, 143 insertions(+), 151 deletions(-)\n> \n> diff --git a/src/libcamera/include/v4l2_pixelformat.h b/src/libcamera/include/v4l2_pixelformat.h\n> index 4d277569cb8c..0fe8a017de34 100644\n> --- a/src/libcamera/include/v4l2_pixelformat.h\n> +++ b/src/libcamera/include/v4l2_pixelformat.h\n> @@ -36,6 +36,10 @@ public:\n>  \n>  \tstd::string toString() const;\n>  \n> +\tPixelFormat toPixelFormat() const;\n> +\tstatic V4L2PixelFormat fromPixelFormat(const PixelFormat &pixelFormat,\n> +\t\t\t\t\t       bool multiplanar);\n> +\n>  private:\n>  \tuint32_t fourcc_;\n>  };\n> diff --git a/src/libcamera/include/v4l2_videodevice.h b/src/libcamera/include/v4l2_videodevice.h\n> index ff64bb357c7e..982fee6bf740 100644\n> --- a/src/libcamera/include/v4l2_videodevice.h\n> +++ b/src/libcamera/include/v4l2_videodevice.h\n> @@ -210,10 +210,7 @@ public:\n>  \tstatic V4L2VideoDevice *fromEntityName(const MediaDevice *media,\n>  \t\t\t\t\t       const std::string &entity);\n>  \n> -\tstatic PixelFormat toPixelFormat(V4L2PixelFormat v4l2Fourcc);\n>  \tV4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat);\n> -\tstatic V4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat,\n> -\t\t\t\t\t\t bool multiplanar);\n>  \n>  protected:\n>  \tstd::string logPrefix() const;\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 030ac6864752..455693264c2e 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -166,7 +166,7 @@ CameraConfiguration *PipelineHandlerUVC::generateConfiguration(Camera *camera,\n>  \t\t       std::inserter(deviceFormats, deviceFormats.begin()),\n>  \t\t       [&](const decltype(v4l2Formats)::value_type &format) {\n>  \t\t\t       return decltype(deviceFormats)::value_type{\n> -\t\t\t\t       data->video_->toPixelFormat(format.first),\n> +\t\t\t\t       format.first.toPixelFormat(),\n>  \t\t\t\t       format.second\n>  \t\t\t       };\n>  \t\t       });\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 57d65c380b0d..876f5de321f6 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -103,4 +103,138 @@ std::string V4L2PixelFormat::toString() const\n>  \treturn ss;\n>  }\n>  \n> +/**\n> + * \\brief Convert the V4L2 pixel format to the corresponding PixelFormat\n> + * \\return The PixelFormat corresponding to the V4L2 pixel format\n> + */\n> +PixelFormat V4L2PixelFormat::toPixelFormat() const\n> +{\n> +\tswitch (fourcc_) {\n> +\t/* RGB formats. */\n> +\tcase V4L2_PIX_FMT_RGB24:\n> +\t\treturn PixelFormat(DRM_FORMAT_BGR888);\n> +\tcase V4L2_PIX_FMT_BGR24:\n> +\t\treturn PixelFormat(DRM_FORMAT_RGB888);\n> +\tcase V4L2_PIX_FMT_RGBA32:\n> +\t\treturn PixelFormat(DRM_FORMAT_ABGR8888);\n> +\tcase V4L2_PIX_FMT_ABGR32:\n> +\t\treturn PixelFormat(DRM_FORMAT_ARGB8888);\n> +\tcase V4L2_PIX_FMT_ARGB32:\n> +\t\treturn PixelFormat(DRM_FORMAT_BGRA8888);\n> +\tcase V4L2_PIX_FMT_BGRA32:\n> +\t\treturn PixelFormat(DRM_FORMAT_RGBA8888);\n> +\n> +\t/* YUV packed formats. */\n> +\tcase V4L2_PIX_FMT_YUYV:\n> +\t\treturn PixelFormat(DRM_FORMAT_YUYV);\n> +\tcase V4L2_PIX_FMT_YVYU:\n> +\t\treturn PixelFormat(DRM_FORMAT_YVYU);\n> +\tcase V4L2_PIX_FMT_UYVY:\n> +\t\treturn PixelFormat(DRM_FORMAT_UYVY);\n> +\tcase V4L2_PIX_FMT_VYUY:\n> +\t\treturn PixelFormat(DRM_FORMAT_VYUY);\n> +\n> +\t/* YUY planar formats. */\n> +\tcase V4L2_PIX_FMT_NV16:\n> +\tcase V4L2_PIX_FMT_NV16M:\n> +\t\treturn PixelFormat(DRM_FORMAT_NV16);\n> +\tcase V4L2_PIX_FMT_NV61:\n> +\tcase V4L2_PIX_FMT_NV61M:\n> +\t\treturn PixelFormat(DRM_FORMAT_NV61);\n> +\tcase V4L2_PIX_FMT_NV12:\n> +\tcase V4L2_PIX_FMT_NV12M:\n> +\t\treturn PixelFormat(DRM_FORMAT_NV12);\n> +\tcase V4L2_PIX_FMT_NV21:\n> +\tcase V4L2_PIX_FMT_NV21M:\n> +\t\treturn PixelFormat(DRM_FORMAT_NV21);\n> +\n> +\t/* Greyscale formats. */\n> +\tcase V4L2_PIX_FMT_GREY:\n> +\t\treturn PixelFormat(DRM_FORMAT_R8);\n> +\n> +\t/* Compressed formats. */\n> +\tcase V4L2_PIX_FMT_MJPEG:\n> +\t\treturn PixelFormat(DRM_FORMAT_MJPEG);\n> +\n> +\t/* V4L2 formats not yet supported by DRM. */\n> +\tdefault:\n> +\t\tLOG(V4L2, Warning)\n> +\t\t\t<< \"Unsupported V4L2 pixel format \"\n> +\t\t\t<< toString();\n> +\t\treturn PixelFormat();\n> +\t}\n> +}\n> +\n> +/**\n> + * \\brief Convert \\a pixelFormat to its corresponding V4L2PixelFormat\n> + * \\param[in] pixelFormat The PixelFormat to convert\n> + * \\param[in] multiplanar V4L2 Multiplanar API support flag\n> + *\n> + * Multiple V4L2 formats may exist for one PixelFormat when the format uses\n> + * multiple planes, as V4L2 defines separate 4CCs for contiguous and separate\n> + * planes formats. Set the \\a multiplanar parameter to false to select a format\n> + * with contiguous planes, or to true to select a format with non-contiguous\n> + * planes.\n> + *\n> + * \\return The V4L2PixelFormat corresponding to \\a pixelFormat\n> + */\n> +V4L2PixelFormat V4L2PixelFormat::fromPixelFormat(const PixelFormat &pixelFormat,\n> +\t\t\t\t\t\t bool multiplanar)\n> +{\n> +\tswitch (pixelFormat) {\n> +\t/* RGB formats. */\n> +\tcase DRM_FORMAT_BGR888:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_RGB24);\n> +\tcase DRM_FORMAT_RGB888:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_BGR24);\n> +\tcase DRM_FORMAT_ABGR8888:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_RGBA32);\n> +\tcase DRM_FORMAT_ARGB8888:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_ABGR32);\n> +\tcase DRM_FORMAT_BGRA8888:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_ARGB32);\n> +\tcase DRM_FORMAT_RGBA8888:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_BGRA32);\n> +\n> +\t/* YUV packed formats. */\n> +\tcase DRM_FORMAT_YUYV:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_YUYV);\n> +\tcase DRM_FORMAT_YVYU:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_YVYU);\n> +\tcase DRM_FORMAT_UYVY:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_UYVY);\n> +\tcase DRM_FORMAT_VYUY:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_VYUY);\n> +\n> +\t/*\n> +\t * YUY planar formats.\n> +\t * \\todo Add support for non-contiguous memory planes\n> +\t * \\todo Select the format variant not only based on \\a multiplanar but\n> +\t * also take into account the formats supported by the device.\n> +\t */\n> +\tcase DRM_FORMAT_NV16:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV16);\n> +\tcase DRM_FORMAT_NV61:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV61);\n> +\tcase DRM_FORMAT_NV12:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV12);\n> +\tcase DRM_FORMAT_NV21:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV21);\n> +\n> +\t/* Greyscale formats. */\n> +\tcase DRM_FORMAT_R8:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_GREY);\n> +\n> +\t/* Compressed formats. */\n> +\tcase DRM_FORMAT_MJPEG:\n> +\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_MJPEG);\n> +\n> +\tdefault:\n> +\t\tLOG(V4L2, Warning)\n> +\t\t\t<< \"Unsupported pixel format \"\n> +\t\t\t<< pixelFormat.toString();\n> +\t\treturn V4L2PixelFormat();\n> +\t}\n> +}\n> +\n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 21df4f524212..e95b0c01cc85 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -18,7 +18,6 @@\n>  #include <unistd.h>\n>  #include <vector>\n>  \n> -#include <linux/drm_fourcc.h>\n>  #include <linux/version.h>\n>  \n>  #include <libcamera/event_notifier.h>\n> @@ -1634,74 +1633,6 @@ V4L2VideoDevice *V4L2VideoDevice::fromEntityName(const MediaDevice *media,\n>  \treturn new V4L2VideoDevice(mediaEntity);\n>  }\n>  \n> -/**\n> - * \\brief Convert a \\a v4l2Fourcc to the corresponding PixelFormat\n> - * \\param[in] v4l2Fourcc The V4L2 pixel format (V4L2_PIX_FORMAT_*)\n> - * \\return The PixelFormat corresponding to \\a v4l2Fourcc\n> - */\n> -PixelFormat V4L2VideoDevice::toPixelFormat(V4L2PixelFormat v4l2Fourcc)\n> -{\n> -\tswitch (v4l2Fourcc) {\n> -\t/* RGB formats. */\n> -\tcase V4L2_PIX_FMT_RGB24:\n> -\t\treturn PixelFormat(DRM_FORMAT_BGR888);\n> -\tcase V4L2_PIX_FMT_BGR24:\n> -\t\treturn PixelFormat(DRM_FORMAT_RGB888);\n> -\tcase V4L2_PIX_FMT_RGBA32:\n> -\t\treturn PixelFormat(DRM_FORMAT_ABGR8888);\n> -\tcase V4L2_PIX_FMT_ABGR32:\n> -\t\treturn PixelFormat(DRM_FORMAT_ARGB8888);\n> -\tcase V4L2_PIX_FMT_ARGB32:\n> -\t\treturn PixelFormat(DRM_FORMAT_BGRA8888);\n> -\tcase V4L2_PIX_FMT_BGRA32:\n> -\t\treturn PixelFormat(DRM_FORMAT_RGBA8888);\n> -\n> -\t/* YUV packed formats. */\n> -\tcase V4L2_PIX_FMT_YUYV:\n> -\t\treturn PixelFormat(DRM_FORMAT_YUYV);\n> -\tcase V4L2_PIX_FMT_YVYU:\n> -\t\treturn PixelFormat(DRM_FORMAT_YVYU);\n> -\tcase V4L2_PIX_FMT_UYVY:\n> -\t\treturn PixelFormat(DRM_FORMAT_UYVY);\n> -\tcase V4L2_PIX_FMT_VYUY:\n> -\t\treturn PixelFormat(DRM_FORMAT_VYUY);\n> -\n> -\t/* YUY planar formats. */\n> -\tcase V4L2_PIX_FMT_NV16:\n> -\tcase V4L2_PIX_FMT_NV16M:\n> -\t\treturn PixelFormat(DRM_FORMAT_NV16);\n> -\tcase V4L2_PIX_FMT_NV61:\n> -\tcase V4L2_PIX_FMT_NV61M:\n> -\t\treturn PixelFormat(DRM_FORMAT_NV61);\n> -\tcase V4L2_PIX_FMT_NV12:\n> -\tcase V4L2_PIX_FMT_NV12M:\n> -\t\treturn PixelFormat(DRM_FORMAT_NV12);\n> -\tcase V4L2_PIX_FMT_NV21:\n> -\tcase V4L2_PIX_FMT_NV21M:\n> -\t\treturn PixelFormat(DRM_FORMAT_NV21);\n> -\n> -\t/* Greyscale formats. */\n> -\tcase V4L2_PIX_FMT_GREY:\n> -\t\treturn PixelFormat(DRM_FORMAT_R8);\n> -\n> -\t/* Compressed formats. */\n> -\tcase V4L2_PIX_FMT_MJPEG:\n> -\t\treturn PixelFormat(DRM_FORMAT_MJPEG);\n> -\n> -\t/* V4L2 formats not yet supported by DRM. */\n> -\tdefault:\n> -\t\t/*\n> -\t\t * \\todo We can't use LOG() in a static method of a Loggable\n> -\t\t * class. Until we fix the logger, work around it.\n> -\t\t */\n> -\t\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n> -\t\t\t\tLogWarning).stream()\n\nAha, nice this all gets tidied up.\n\n> -\t\t\t<< \"Unsupported V4L2 pixel format \"\n> -\t\t\t<< v4l2Fourcc.toString();\n> -\t\treturn PixelFormat();\n> -\t}\n> -}\n> -\n>  /**\n>   * \\brief Convert \\a PixelFormat to its corresponding V4L2 FourCC\n>   * \\param[in] pixelFormat The PixelFormat to convert\n> @@ -1715,82 +1646,8 @@ PixelFormat V4L2VideoDevice::toPixelFormat(V4L2PixelFormat v4l2Fourcc)\n>   */\n>  V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelFormat)\n>  {\n> -\treturn toV4L2PixelFormat(pixelFormat, caps_.isMultiplanar());\n> -}\n> -\n> -/**\n> - * \\brief Convert \\a pixelFormat to its corresponding V4L2 FourCC\n> - * \\param[in] pixelFormat The PixelFormat to convert\n> - * \\param[in] multiplanar V4L2 Multiplanar API support flag\n> - *\n> - * Multiple V4L2 formats may exist for one PixelFormat when the format uses\n> - * multiple planes, as V4L2 defines separate 4CCs for contiguous and separate\n> - * planes formats. Set the \\a multiplanar parameter to false to select a format\n> - * with contiguous planes, or to true to select a format with non-contiguous\n> - * planes.\n> - *\n> - * \\return The V4L2_PIX_FMT_* pixel format code corresponding to \\a pixelFormat\n> - */\n> -V4L2PixelFormat V4L2VideoDevice::toV4L2PixelFormat(const PixelFormat &pixelFormat,\n> -\t\t\t\t\t\t   bool multiplanar)\n> -{\n> -\tswitch (pixelFormat) {\n> -\t/* RGB formats. */\n> -\tcase DRM_FORMAT_BGR888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_RGB24);\n> -\tcase DRM_FORMAT_RGB888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_BGR24);\n> -\tcase DRM_FORMAT_ABGR8888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_RGBA32);\n> -\tcase DRM_FORMAT_ARGB8888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_ABGR32);\n> -\tcase DRM_FORMAT_BGRA8888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_ARGB32);\n> -\tcase DRM_FORMAT_RGBA8888:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_BGRA32);\n> -\n> -\t/* YUV packed formats. */\n> -\tcase DRM_FORMAT_YUYV:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_YUYV);\n> -\tcase DRM_FORMAT_YVYU:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_YVYU);\n> -\tcase DRM_FORMAT_UYVY:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_UYVY);\n> -\tcase DRM_FORMAT_VYUY:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_VYUY);\n> -\n> -\t/*\n> -\t * YUY planar formats.\n> -\t * \\todo Add support for non-contiguous memory planes\n> -\t * \\todo Select the format variant not only based on \\a multiplanar but\n> -\t * also take into account the formats supported by the device.\n> -\t */\n> -\tcase DRM_FORMAT_NV16:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV16);\n> -\tcase DRM_FORMAT_NV61:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV61);\n> -\tcase DRM_FORMAT_NV12:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV12);\n> -\tcase DRM_FORMAT_NV21:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_NV21);\n> -\n> -\t/* Greyscale formats. */\n> -\tcase DRM_FORMAT_R8:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_GREY);\n> -\n> -\t/* Compressed formats. */\n> -\tcase DRM_FORMAT_MJPEG:\n> -\t\treturn V4L2PixelFormat(V4L2_PIX_FMT_MJPEG);\n> -\t}\n> -\n> -\t/*\n> -\t * \\todo We can't use LOG() in a static method of a Loggable\n> -\t * class. Until we fix the logger, work around it.\n> -\t */\n> -\tlibcamera::_log(__FILE__, __LINE__, _LOG_CATEGORY(V4L2)(),\n> -\t\t\tLogWarning).stream()\n> -\t\t<< \"Unsupported V4L2 pixel format \" << pixelFormat.toString();\n> -\treturn {};\n> +\treturn V4L2PixelFormat::fromPixelFormat(pixelFormat,\n> +\t\t\t\t\t\tcaps_.isMultiplanar());\n>  }\n>  \n>  /**\n> diff --git a/test/libtest/buffer_source.cpp b/test/libtest/buffer_source.cpp\n> index dae3cb9f7a6c..d1dad2a0f8cf 100644\n> --- a/test/libtest/buffer_source.cpp\n> +++ b/test/libtest/buffer_source.cpp\n> @@ -70,8 +70,8 @@ int BufferSource::allocate(const StreamConfiguration &config)\n>  \t}\n>  \n>  \tformat.size = config.size;\n> -\tformat.fourcc = V4L2VideoDevice::toV4L2PixelFormat(config.pixelFormat,\n> -\t\t\t\t\t\t\t   false);\n> +\tformat.fourcc = V4L2PixelFormat::fromPixelFormat(config.pixelFormat,\n> +\t\t\t\t\t\t\t false);\n>  \tif (video->setFormat(&format)) {\n>  \t\tstd::cout << \"Failed to set format on output device\" << std::endl;\n>  \t\treturn TestFail;\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89507613A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Apr 2020 10:05:06 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D43FE503;\n\tThu, 30 Apr 2020 10:05:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ShZMBt/7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588233905;\n\tbh=l/6rfRQDVc69vhaGmLdna3Su3gTKDtnynsNqJ7LreBs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ShZMBt/7J8berUlWHaLoFLCqugpePwX9CkU6AcBwS58t4ZKVI3K6uuaT4vBE1GBOg\n\tvjMFOv/SnQg0iaUwcch2QpJnzXPviml4+CIDgbYpToiZu7qJZ8vg/6u/pNpnvj0f49\n\t3aStC1q7D9y7yl/3C7+h0+5CdgAccAuerRx7voKo=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200430005226.18162-1-laurent.pinchart@ideasonboard.com>\n\t<20200430005226.18162-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<289b5217-0476-676c-db7d-95f35cd0c74c@ideasonboard.com>","Date":"Thu, 30 Apr 2020 09:05:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200430005226.18162-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 2/4] libcamera: v4l2_pixelformat: Move\n\tDRM/V4L2 format conversion","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 30 Apr 2020 08:05:06 -0000"}}]