[{"id":4652,"web_url":"https://patchwork.libcamera.org/comment/4652/","msgid":"<20200429215137.GS5956@pendragon.ideasonboard.com>","date":"2020-04-29T21:51:37","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: don't\n\tfail if sensorInfo fails","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dafna,\n\nThank you for the patch.\n\nOn Wed, Apr 29, 2020 at 11:44:50PM +0200, Dafna Hirschfeld wrote:\n> When starting the streaming, it might be that the call\n> to sensorInfo fails. This does not mean that the camera can't\n> stream so set 'ret' to 0\n\nOops :-/ I've added\n\nFixes: fd554f9dba31 (\"libcamera: ipa: Add support for CameraSensorInfo\")\n\n(and a period after the last sentence of the commit message) and pushed\nthe patch. Thank you.\n\n> Signed-off-by: Dafna Hirschfeld \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 1a34ffe..6aa3178 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -828,6 +828,7 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n> \t\t/* \\todo Turn this in an hard failure. */\n> \t\tLOG(RkISP1, Warning) << \"Camera sensor information not available\";\n> \t\tsensorInfo = {};\n> +\t\tret = 0;\n> \t}\n> \n> \tstd::map streamConfig;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEBA0603F5\n\tfor ;\n\tWed, 29 Apr 2020 23:51:38 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CEA8521;\n\tWed, 29 Apr 2020 23:51:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"osJY4iha\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588197098;\n\tbh=29b0vyi6GEr0hn1zfqp41Ro66fqvg96D2TwTGAE22fc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=osJY4ihatqe8FFe+LXXAbbNFK6QIGmHHqrbMgF82RTKrXzXzCDOrsKT5Z282adXT9\n\tE+HjnExNSqclN9zM2xB+NZZYNSho7qlA+sP6dl8SbZ8ZDml5Xp0OeV2Ifk5x9YiUQZ\n\t2cC6xOgQI9Qw1fIi2BViAlqen0MJI8kz6FeeP4vM=","Date":"Thu, 30 Apr 2020 00:51:37 +0300","From":"Laurent Pinchart ","To":"Dafna Hirschfeld ","Cc":"libcamera-devel@lists.libcamera.org, ezequiel@collabora.com","Message-ID":"<20200429215137.GS5956@pendragon.ideasonboard.com>","References":"<20200429214450.27676-1-dafna.hirschfeld@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200429214450.27676-1-dafna.hirschfeld@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: don't\n\tfail if sensorInfo fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Apr 2020 21:51:39 -0000"}},{"id":4653,"web_url":"https://patchwork.libcamera.org/comment/4653/","msgid":"<20200429215658.ak7j23pc2kjczcmo@uno.localdomain>","date":"2020-04-29T21:56:58","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: don't\n\tfail if sensorInfo fails","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Dafna,\n good catch, my bad!\n\nOn Wed, Apr 29, 2020 at 11:44:50PM +0200, Dafna Hirschfeld wrote:\n> When starting the streaming, it might be that the call\n> to sensorInfo fails. This does not mean that the camera can't\n> stream so set 'ret' to 0\n>\n\nThis might be worth a\nFixes: fd554f9dba31 (\"libcamera: ipa: Add support for CameraSensorInfo\")\n\nwhich can be added when applying though\n\n> Signed-off-by: Dafna Hirschfeld \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 1a34ffe..6aa3178 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -828,6 +828,7 @@ int PipelineHandlerRkISP1::start(Camera *camera)\n> \t\t/* \\todo Turn this in an hard failure. */\n> \t\tLOG(RkISP1, Warning) << \"Camera sensor information not available\";\n> \t\tsensorInfo = {};\n> +\t\tret = 0;\n> \t}\n>\n> \tstd::map streamConfig;\n> --\n> 2.17.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41620603F5\n\tfor ;\n\tWed, 29 Apr 2020 23:53:48 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 8CEB6240009;\n\tWed, 29 Apr 2020 21:53:47 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 29 Apr 2020 23:56:58 +0200","From":"Jacopo Mondi ","To":"Dafna Hirschfeld ","Cc":"libcamera-devel@lists.libcamera.org, ezequiel@collabora.com","Message-ID":"<20200429215658.ak7j23pc2kjczcmo@uno.localdomain>","References":"<20200429214450.27676-1-dafna.hirschfeld@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200429214450.27676-1-dafna.hirschfeld@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: rkisp1: don't\n\tfail if sensorInfo fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Apr 2020 21:53:48 -0000"}}]