[{"id":4649,"web_url":"https://patchwork.libcamera.org/comment/4649/","msgid":"<20200429153829.GG5956@pendragon.ideasonboard.com>","date":"2020-04-29T15:38:29","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Fix build\n\tpath comments","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Apr 29, 2020 at 04:19:10PM +0100, Kieran Bingham wrote:\n> The comments describe functionality before libcameraBuildPath() was\n> adapted from libcameraPath() to return the root of the build, and\n> described having to take a relative path.\n> \n> This is no longer the case, and the comment is inaccurate. Fix it.\n> \n> Fixes: 1b8ac8473c94 (\"libcamera: utils: Adapt libcameraPath to match use cases\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/ipa_manager.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index df3786797010..1faa3dd38188 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -114,10 +114,7 @@ IPAManager::IPAManager()\n> \n> \t/*\n> \t * When libcamera is used before it is installed, load IPAs from the\n> -\t * same build directory as the libcamera library itself. This requires\n> -\t * identifying the path of the libcamera.so, and referencing a relative\n> -\t * path for the IPA from that point. We need to recurse one level of\n> -\t * sub-directories to match the build tree.\n> +\t * same build directory as the libcamera library itself.\n> \t */\n> \tstd::string root = utils::libcameraBuildPath();\n> \tif (!root.empty()) {","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FA53609D6\n\tfor ;\n\tWed, 29 Apr 2020 17:38:31 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F3E3521;\n\tWed, 29 Apr 2020 17:38:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"l6f7nMzq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588174710;\n\tbh=SZeWOfCUDslaq1Jms7FsKNYlqBNLCbLSpIzESMOmDPE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l6f7nMzqcTSq+7uyrH7ghDbu2H/LP/iniSZgK6fCfGd/8TsNWLt6HcO7bfd4591aH\n\telKOARWsmKz9eXUsf2Je6IYD/BulsNVKcbvm2fl91SXvOM1Ur1fUcpMF5sCbYws7ae\n\t6k9wiYCVnZSaUSMWGdcJgVX4yEtx3ySsGASoR52c=","Date":"Wed, 29 Apr 2020 18:38:29 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200429153829.GG5956@pendragon.ideasonboard.com>","References":"<20200429151910.2341468-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200429151910.2341468-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Fix build\n\tpath comments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Apr 2020 15:38:31 -0000"}},{"id":4657,"web_url":"https://patchwork.libcamera.org/comment/4657/","msgid":"<20200430005930.GC1752267@oden.dyn.berto.se>","date":"2020-04-30T00:59:30","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Fix build\n\tpath comments","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2020-04-29 16:19:10 +0100, Kieran Bingham wrote:\n> The comments describe functionality before libcameraBuildPath() was\n> adapted from libcameraPath() to return the root of the build, and\n> described having to take a relative path.\n> \n> This is no longer the case, and the comment is inaccurate. Fix it.\n> \n> Fixes: 1b8ac8473c94 (\"libcamera: utils: Adapt libcameraPath to match use cases\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/ipa_manager.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index df3786797010..1faa3dd38188 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -114,10 +114,7 @@ IPAManager::IPAManager()\n> \n> \t/*\n> \t * When libcamera is used before it is installed, load IPAs from the\n> -\t * same build directory as the libcamera library itself. This requires\n> -\t * identifying the path of the libcamera.so, and referencing a relative\n> -\t * path for the IPA from that point. We need to recurse one level of\n> -\t * sub-directories to match the build tree.\n> +\t * same build directory as the libcamera library itself.\n> \t */\n> \tstd::string root = utils::libcameraBuildPath();\n> \tif (!root.empty()) {\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B03776041C\n\tfor ;\n\tThu, 30 Apr 2020 02:59:32 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id y3so3318818lfy.1\n\tfor ;\n\tWed, 29 Apr 2020 17:59:32 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tz23sm3159762ljm.46.2020.04.29.17.59.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 29 Apr 2020 17:59:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"C3Lst1Q3\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=fq4yL5fP1kRhbtPsjcq8MSHcyWLglxSnSckajo0Kv7U=;\n\tb=C3Lst1Q3N0jyA9sPtHxEfkg3HZxtkoeZlo2VNcF10ubDjKkjWXBNb8Zp2WDOHyLv8h\n\txMPJJQhb4yEBFXmOitOBJ2HeeLKauYd0iC1bevoii0dqqsJscyMiuGSA0Zsu5yCm5uhU\n\t6su6ylU2Udo4Khq7E0KZwn+HAIs0wzvhOAIGeFsbHh+s3jDSscV3UAzMB4TwQcRcVSOa\n\tJuZNHzyfui3Th07ER5O87IzYLzwj58zttUBmQXppQJAR7bA4wd1gSe7rmL4dENfFcfN9\n\tgobe1jUVZGopWkvJc8k96++qoq47lGOvrLr+QpfsNplZhz+M25MHliErYwTQEy0YqOkB\n\tgs6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=fq4yL5fP1kRhbtPsjcq8MSHcyWLglxSnSckajo0Kv7U=;\n\tb=Nc08BicFktMotpmi69pMSBzsNxr3xPi7xqeBCk98y+ZmbYDnfLnysyT3LEdBQwim9k\n\tV0N4RNCK0lpen9PyG1LpinxM5AQOEDPFc6L0Vb7QAeOhQEGv0+3Tv8c3e6Ba616Y2TVf\n\tY4lLPZ6j6W/B1xb/XLWXSuS7DKqryKBX3ZxOMn1mlhWfYKMWA/76ptj2P06Rw0y8yApT\n\t3DjpxqKY5FF71DqAoFV+60PfkvJVZJxyxjcO9Ruk5JOvyKfRL3Fb3vZCs3itLWEeECGa\n\tJlFuphj+PQSxOkE2a1CCcaFtJA0vVIZwRvmCM82hM1Ml/OPdDsJX24zdzOGIPve/EpOO\n\tXnIQ==","X-Gm-Message-State":"AGi0Pub7MHI7DONGnsVpVqryvePrJlgTmdiORr4RnQlkWdumUYjkm8As\n\tFbJndgLMIoCpTOK3LfZBL7+6kw==","X-Google-Smtp-Source":"APiQypLLSVDLsN0+50D6hKuji8nemZWpmAATHv773X43FoITueMEnHW/vBVXbYEO3QkiVvRlyKgosQ==","X-Received":"by 2002:ac2:515d:: with SMTP id q29mr341032lfd.210.1588208372064;\n\tWed, 29 Apr 2020 17:59:32 -0700 (PDT)","Date":"Thu, 30 Apr 2020 02:59:30 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera devel ","Message-ID":"<20200430005930.GC1752267@oden.dyn.berto.se>","References":"<20200429151910.2341468-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200429151910.2341468-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Fix build\n\tpath comments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 30 Apr 2020 00:59:32 -0000"}}]