[{"id":557,"web_url":"https://patchwork.libcamera.org/comment/557/","msgid":"<20190124170105.GY4127@bigcity.dyn.berto.se>","date":"2019-01-24T17:01:05","subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: media_device: Add\n\tdisconnected signal","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-01-24 12:16:46 +0200, Laurent Pinchart wrote:\n> The signal is emitted when the hardware device corresponding to the\n> media device is unplugged. This will trigger the full unplug handling\n> chain.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/media_device.h | 4 ++++\n> src/libcamera/media_device.cpp | 10 ++++++++++\n> 2 files changed, 14 insertions(+)\n> \n> diff --git a/src/libcamera/include/media_device.h b/src/libcamera/include/media_device.h\n> index 8a7b9489faa9..27a2b46a4392 100644\n> --- a/src/libcamera/include/media_device.h\n> +++ b/src/libcamera/include/media_device.h\n> @@ -14,6 +14,8 @@\n> \n> #include \n> \n> +#include \n> +\n> #include \"media_object.h\"\n> \n> namespace libcamera {\n> @@ -48,6 +50,8 @@ public:\n> \tMediaLink *link(const MediaPad *source, const MediaPad *sink);\n> \tint disableLinks();\n> \n> +\tSignal disconnected;\n> +\n> private:\n> \tstd::string driver_;\n> \tstd::string deviceNode_;\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index 51e5088ebdd9..be81bd8c4c23 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -427,6 +427,16 @@ int MediaDevice::disableLinks()\n> \treturn 0;\n> }\n> \n> +/**\n> + * \\var MediaDevice::disconnected\n> + * \\brief Signal emitted when the media device is disconnected from the system\n> + *\n> + * This signal is emitted when the device enumerator detects that the media\n> + * device has been removed from the system. For hot-pluggable devices this is\n> + * usually caused by physical device disconnection, but can also result from\n> + * driver unloading for most devices. The media device is passed as a parameter.\n> + */\n> +\n> /**\n> * \\var MediaDevice::objects_\n> * \\brief Global map of media objects (entities, pads, links) keyed by their\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0691860C82\n\tfor ;\n\tThu, 24 Jan 2019 18:01:08 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id t9-v6so5879033ljh.6\n\tfor ;\n\tThu, 24 Jan 2019 09:01:07 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tv19sm1027126lfe.69.2019.01.24.09.01.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 24 Jan 2019 09:01:06 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=DIS9oUtABthWT2rNg/+gBz/ToHpTMlRmDxsNQvEhES0=;\n\tb=OKWmjvxonEYgC1XWey0fuOhwYLYZxATO/2W4roKnFGNOF5PZ0DX452w0kleGgAszsu\n\tTzv8EGZFTfAfXMTd1fH59e21rIdTyq3S4R/KoYmTZGeEjKCdGGb2dYRmmiek9zOlWhrx\n\tyl0Sz9/F4EC4+pGar48F8YiF8FQXI6r7/10Fbhyktq1FPlZ+nm6M/kHepdKD0ArAKv6y\n\tzMohAke/1+nTMz/c73SMBDAd+Yt/pGv4ElUUqi0hqr9Subh4FnZTfrAt6fiwIu5s9SZh\n\tBse7oKZYi7rV5GNxyU/9wFEry3LXWvRZUi7EaH3C9FzGNna7sUf74R9zItlEYQN+DVQO\n\tBE3Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=DIS9oUtABthWT2rNg/+gBz/ToHpTMlRmDxsNQvEhES0=;\n\tb=rxIvnd/YmbY/lzdXK3ocdjrF6UljslbyFTc6eNRb1UQgYcJVpei0m0Dc80jqEINi5b\n\tkBuswzPUmXUupCGdBUQeDW1nyuuqw0LB3PrNTuOKEVCJV89elWlOXu1IsXCz0RBoVeW3\n\tCtDqhL0I1Qx8i/iQHcsIuPZ5nRud0pMFBnhx4awMjkXPAiRMWKlcKBBTEE4FD7zXpT/v\n\tIem1ta1IK9xucNIT8EuYUFlm3Db9eVDdm/fivuH+sNpcpgQI6SkYC5QLGgQRaE57n2qN\n\tX0ST1EDEm4nUs9dRm485JFaX9lZz8F92BIc0fK7OPSrMvTvAVCTc5juuIWEHvDs5h4Tn\n\txiCA==","X-Gm-Message-State":"AJcUukcX5CzVJEYIS+Kr7ujGPbVnml2vof7JdRo7GHTi3eey5Qmn0gex\n\tZRpWdBr2O1VaPZOM87U9E12c+TBfsgs=","X-Google-Smtp-Source":"ALg8bN5cNA4JTwITb7JQFvn8CCeib1SK9UFu/bjJ9HNrn9xQ/GHQVYu4Yv+QmXLG/3ToRKaP5JSMZQ==","X-Received":"by 2002:a2e:1b47:: with SMTP id\n\tb68-v6mr6229816ljb.104.1548349267288; \n\tThu, 24 Jan 2019 09:01:07 -0800 (PST)","Date":"Thu, 24 Jan 2019 18:01:05 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190124170105.GY4127@bigcity.dyn.berto.se>","References":"<20190124101651.9993-1-laurent.pinchart@ideasonboard.com>\n\t<20190124101651.9993-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190124101651.9993-6-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 05/10] libcamera: media_device: Add\n\tdisconnected signal","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 24 Jan 2019 17:01:08 -0000"}}]