[{"id":4627,"web_url":"https://patchwork.libcamera.org/comment/4627/","msgid":"<20200428201043.yj4uyd4s6x63tb7w@uno.localdomain>","date":"2020-04-28T20:10:43","subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: pipeline: vimc:\n\tName camera based on sensor model","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Tue, Apr 28, 2020 at 09:16:50PM +0300, Laurent Pinchart wrote:\n> Use the sensor model to create the camera name. The resulting name\n> should still be \"VIMC Sensor B\", but prepares for support of Sensor A.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/vimc/vimc.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 6707c5a07ae6..ccfd7f86d158 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -394,9 +394,9 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n> \t\treturn false;\n>\n> \t/* Create and register the camera. */\n> +\tstd::string name{ \"VIMC \" + data->sensor_->model() };\n> \tstd::set streams{ &data->stream_ };\n> -\tstd::shared_ptr camera = Camera::create(this, \"VIMC Sensor B\",\n> -\t\t\t\t\t\t\tstreams);\n> +\tstd::shared_ptr camera = Camera::create(this, name, streams);\n> \tregisterCamera(std::move(camera), std::move(data));\n>\n> \treturn true;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EDCC960AF4\n\tfor ;\n\tTue, 28 Apr 2020 22:07:31 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 536C64000D;\n\tTue, 28 Apr 2020 20:07:31 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 28 Apr 2020 22:10:43 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200428201043.yj4uyd4s6x63tb7w@uno.localdomain>","References":"<20200428181650.5071-1-laurent.pinchart@ideasonboard.com>\n\t<20200428181650.5071-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200428181650.5071-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: pipeline: vimc:\n\tName camera based on sensor model","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 28 Apr 2020 20:07:32 -0000"}}]