[{"id":4633,"web_url":"https://patchwork.libcamera.org/comment/4633/","msgid":"<20200429005015.GB16978@pendragon.ideasonboard.com>","date":"2020-04-29T00:50:15","subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Add sensor black\n\tlevels reporting through metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Tue, Apr 28, 2020 at 09:11:40AM +0100, Naushir Patuck wrote:\n> From: David Plowman \n> \n> The black levels will be used when saving RAW data in DNG containers.\n> \n> Four values are reported, one for each channel, in the order R, Gr, Gb\n> and B. The values are reported as being out of a 16-bit pixel range\n> (a fully saturated pixel would be 65535), so may need subsequent\n> re-scaling, depending on use.\n> \n> Signed-off-by: David Plowman \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\nAnd pushed to master.\n\n> ---\n> src/libcamera/control_ids.yaml | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index b419f8a7..77ebc3f9 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -230,4 +230,13 @@ controls:\n> Specify a fixed saturation parameter. Normal saturation is given by\n> the value 1.0; larger values produce more saturated colours; 0.0\n> produces a greyscale image.\n> +\n> + - SensorBlackLevels:\n> + type: int32_t\n> + description: |\n> + Reports the sensor black levels used for processing a frame, in the\n> + order R, Gr, Gb, B. These values are returned as numbers out of a 16-bit\n> + pixel range (as if pixels ranged from 0 to 65535). The SensorBlackLevels\n> + control can only be returned in metadata.\n> + size: [4]\n> ...","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 611D860AF5\n\tfor ;\n\tWed, 29 Apr 2020 02:50:17 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C99C6521;\n\tWed, 29 Apr 2020 02:50:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AyzyYAtR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588121417;\n\tbh=qdQp0J4crf4QJp5Q+VnGrt9T3fy05KY4NH4xzGT4Lso=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AyzyYAtR1YQxtiNyUTVfxnix7uybAr/2ioHrg+o9fOBNERf06ynyv89eK2JGPNtPl\n\tZosmwvDxHARLMSOMpNW7cZcjX8DS+TBed7Nh0IqrF6s0c3oc9GEf3pJtSO0iPX+EC3\n\t/5rOaLep1NWE14KJf2t319ZFTD4la/S/sq4+1iqM=","Date":"Wed, 29 Apr 2020 03:50:15 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200429005015.GB16978@pendragon.ideasonboard.com>","References":"<20200428081140.5242-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200428081140.5242-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Add sensor black\n\tlevels reporting through metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 Apr 2020 00:50:17 -0000"}}]