[{"id":4586,"web_url":"https://patchwork.libcamera.org/comment/4586/","msgid":"<20200427223307.GA13402@pendragon.ideasonboard.com>","date":"2020-04-27T22:33:07","subject":"Re: [libcamera-devel] [PATCH v2 1/5] cam: options: Make\n\tKeyValueParser::parse() virtual","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Apr 28, 2020 at 12:05:25AM +0200, Niklas Söderlund wrote:\n> Prepare for sub-classing of the KeyValueParser by making the parse()\n> method virtual.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/cam/options.h | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/cam/options.h b/src/cam/options.h\n> index 5e346b474f765841..5060fee0c26b896f 100644\n> --- a/src/cam/options.h\n> +++ b/src/cam/options.h\n> @@ -71,10 +71,12 @@ public:\n> \t{\n> \t};\n> \n> +\tvirtual ~KeyValueParser(){};\n\ns/{};/ {}/\n\nReviewed-by: Laurent Pinchart \n\n> +\n> \tbool addOption(const char *name, OptionType type, const char *help,\n> \t\t OptionArgument argument = ArgumentNone);\n> \n> -\tOptions parse(const char *arguments);\n> +\tvirtual Options parse(const char *arguments);\n> \tvoid usage(int indent);\n> \n> private:","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A67AE60AF4\n\tfor ;\n\tTue, 28 Apr 2020 00:33:23 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 161D072C;\n\tTue, 28 Apr 2020 00:33:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vrvJVLYX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1588026803;\n\tbh=+nwx9E+woOWP67f8wwDXkpDtdtF7L41a/PlNkBVMrNY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vrvJVLYX/kZtc95HwIAoRICuqsumU9AUtYHb0FOc0q/F+K+IKTGwGjgVrG3ouhgSp\n\twTe4TYwCHGSd5Hfc5Ix/d5zb9mW6IA1wQf+1R1ZpTN20wLtoQEpY2zWpV7CugagnJD\n\tcngsSrouemwGxfCrqiedmgGp7aOD30FUTqGc/58E=","Date":"Tue, 28 Apr 2020 01:33:07 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200427223307.GA13402@pendragon.ideasonboard.com>","References":"<20200427220529.1085074-1-niklas.soderlund@ragnatech.se>\n\t<20200427220529.1085074-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200427220529.1085074-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] cam: options: Make\n\tKeyValueParser::parse() virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 22:33:23 -0000"}}]