{"id":3578,"url":"https://patchwork.libcamera.org/api/patches/3578/?format=json","web_url":"https://patchwork.libcamera.org/patch/3578/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200427220529.1085074-2-niklas.soderlund@ragnatech.se>","date":"2020-04-27T22:05:25","name":"[libcamera-devel,v2,1/5] cam: options: Make KeyValueParser::parse() virtual","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"91a41db6a9ebca018453cd08c868f2e9ecbb302f","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3578/mbox/","series":[{"id":838,"url":"https://patchwork.libcamera.org/api/series/838/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=838","date":"2020-04-27T22:05:24","name":"{cam, qcam}: Unify stream option parsing","version":2,"mbox":"https://patchwork.libcamera.org/series/838/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3578/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3578/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE1F460AFA\n\tfor ;\n\tTue, 28 Apr 2020 00:06:16 +0200 (CEST)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 40684680-88d3-11ea-b7d8-005056917a89;\n\tTue, 28 Apr 2020 00:05:48 +0200 (CEST)"],"X-Halon-ID":"40684680-88d3-11ea-b7d8-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 28 Apr 2020 00:05:25 +0200","Message-Id":"<20200427220529.1085074-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.26.0","In-Reply-To":"<20200427220529.1085074-1-niklas.soderlund@ragnatech.se>","References":"<20200427220529.1085074-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/5] cam: options: Make\n\tKeyValueParser::parse() virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 22:06:17 -0000"},"content":"Prepare for sub-classing of the KeyValueParser by making the parse()\nmethod virtual.\n\nSigned-off-by: Niklas Söderlund \n---\n src/cam/options.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/cam/options.h b/src/cam/options.h\nindex 5e346b474f765841..5060fee0c26b896f 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -71,10 +71,12 @@ public:\n \t{\n \t};\n \n+\tvirtual ~KeyValueParser(){};\n+\n \tbool addOption(const char *name, OptionType type, const char *help,\n \t\t OptionArgument argument = ArgumentNone);\n \n-\tOptions parse(const char *arguments);\n+\tvirtual Options parse(const char *arguments);\n \tvoid usage(int indent);\n \n private:\n","prefixes":["libcamera-devel","v2","1/5"]}