[{"id":555,"web_url":"https://patchwork.libcamera.org/comment/555/","msgid":"<20190124163840.GW4127@bigcity.dyn.berto.se>","date":"2019-01-24T16:38:40","subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: pipeline_handler:\n\tDeclare factory children classes as final","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-24 12:16:43 +0200, Laurent Pinchart wrote:\n> Nothing should inherit from the factory classes created by the\n> REGISTER_PIPELINE_HANDLER() macro. Declare them as final instead of only\n> declaring their create() method final.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/pipeline_handler.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 7bb07d1ec5c7..1da6dc758ca6 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -46,11 +46,11 @@ private:\n> };\n> \n> #define REGISTER_PIPELINE_HANDLER(handler)\t\t\t\t\\\n> -class handler##Factory : public PipelineHandlerFactory\t\t\t\\\n> +class handler##Factory final : public PipelineHandlerFactory\t\t\\\n> {\t\t\t\t\t\t\t\t\t\\\n> public:\t\t\t\t\t\t\t\t\t\\\n> \thandler##Factory() : PipelineHandlerFactory(#handler) {}\t\\\n> -\tPipelineHandler *create(CameraManager *manager) final\t\t\\\n> +\tPipelineHandler *create(CameraManager *manager) \t\t\\\n> \t{\t\t\t\t\t\t\t\t\\\n> \t\treturn new handler(manager);\t\t\t\t\\\n> \t}\t\t\t\t\t\t\t\t\\\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7081E60C82\n\tfor ;\n\tThu, 24 Jan 2019 17:38:43 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id v1-v6so5851518ljd.0\n\tfor ;\n\tThu, 24 Jan 2019 08:38:43 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\to17sm1019205lff.77.2019.01.24.08.38.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 24 Jan 2019 08:38:41 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=AozAoNxBE7+tn5k2uL6NCiqGV5ZIw0fAjH0pgrn5Tas=;\n\tb=j20MAP4CFNC8rBhbV0Bj/ParlbqJokmrOtUvcTd2qu7l5EMmGXwArabJ8io+V1awGS\n\tsJPERkPH5hxWIZTyG3EesS6AuZgqfhB8MqCpz/ijKSSCmJvhmEVOtvKLzPeLTE32w6jv\n\tDmdwrZpl8TblADlQtO9JhfMCuSLyuEoDqizWTSqGG1SIaOHHBLx9LPQrNptChy6XEpsi\n\tnflogg5vzOYZOSOt2osTR7dOCnkOM4ivFYeGl428d4p9W0iFCYNXscLa8ZjYdQeikuf6\n\tTCX+wsK7ZRmXpMQCscYoyx7E7ZfF63KD8XkNbApzImypnyFNBG5KkMotsn/BkpPiwIi8\n\tltHg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=AozAoNxBE7+tn5k2uL6NCiqGV5ZIw0fAjH0pgrn5Tas=;\n\tb=DXpR3ugsJvvxEuN2Off4BYy3nK64grMy4sfsEHUK3EyXCkHeHbRg9b+WZql6CAuGoJ\n\t7VzkAR3i/i9AE03j10sny2h25ehm2nchDUjMNMv96gki/Od4OpfyXkE7ZPUS8Rlq9nlF\n\tJ7RrXuliKUgcf9F8wTg1vDCtCXml+yDVsVwGZrBw7bAXRDrH3o0Cp2BYWy9n0lQ6Syyl\n\tAZDMvaUGy8s0mcQ1+XWFvq5OgYuqdHNVZTTXRuSzu55BxNWbG0a3kX0ddvFukvkzO01B\n\t0RdVcchPrWaN7nASTRYoaqElQiemg61IULTR7JRAWuQsAufdZJeX6f+NkUkPNeYgN24K\n\ts/9w==","X-Gm-Message-State":"AJcUukd8VSqvoCgpy1tnbVsMmUNEY1dPh5uCSV28XlGqHLdsG28XQYKz\n\tvvQSXDVMqQViAj1EfC4POBheibS7Osk=","X-Google-Smtp-Source":"ALg8bN5TDqg9OiRsa5NbtvhGav/bKaAYfFeY6toKtCQFADxyA380RcMghreBYUEFGWr+x6ufKV/DHg==","X-Received":"by 2002:a2e:561d:: with SMTP id\n\tk29-v6mr6274022ljb.91.1548347922514; \n\tThu, 24 Jan 2019 08:38:42 -0800 (PST)","Date":"Thu, 24 Jan 2019 17:38:40 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190124163840.GW4127@bigcity.dyn.berto.se>","References":"<20190124101651.9993-1-laurent.pinchart@ideasonboard.com>\n\t<20190124101651.9993-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190124101651.9993-3-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: pipeline_handler:\n\tDeclare factory children classes as final","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 24 Jan 2019 16:38:43 -0000"}}]