[{"id":4549,"web_url":"https://patchwork.libcamera.org/comment/4549/","msgid":"<20200427085427.3zqn6taklsn5gupx@uno.localdomain>","date":"2020-04-27T08:54:27","subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: ipa_manager: Return\n\tan IPAProxy from createIPA()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Apr 27, 2020 at 06:17:08AM +0300, Laurent Pinchart wrote:\n> In order to provide pipeline handlers with IPA-related helpers on top of\n> IPAInterface, return the IPAProxy instance from IPAManager::createIPA().\n> No change is required in the pipeline handlers as the IPAInterface that\n> was previously returned is implemented by an IPAProxy instance already.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/include/ipa_manager.h | 6 +++---\n> src/libcamera/include/pipeline_handler.h | 5 +++--\n> src/libcamera/ipa_manager.cpp | 14 +++++++-------\n> 3 files changed, 13 insertions(+), 12 deletions(-)\n>\n> diff --git a/src/libcamera/include/ipa_manager.h b/src/libcamera/include/ipa_manager.h\n> index 6165efb8b145..aa6b9adb1f87 100644\n> --- a/src/libcamera/include/ipa_manager.h\n> +++ b/src/libcamera/include/ipa_manager.h\n> @@ -24,9 +24,9 @@ class IPAManager\n> public:\n> \tstatic IPAManager *instance();\n>\n> -\tstd::unique_ptr createIPA(PipelineHandler *pipe,\n> -\t\t\t\t\t\tuint32_t maxVersion,\n> -\t\t\t\t\t\tuint32_t minVersion);\n> +\tstd::unique_ptr createIPA(PipelineHandler *pipe,\n> +\t\t\t\t\t uint32_t maxVersion,\n> +\t\t\t\t\t uint32_t minVersion);\n>\n> private:\n> \tstd::vector modules_;\n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 3fcfeda4bfee..706413fa6e9f 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -15,11 +15,12 @@\n> #include \n> #include \n>\n> -#include \n> #include \n> #include \n> #include \n>\n> +#include \"ipa_proxy.h\"\n> +\n> namespace libcamera {\n>\n> class Camera;\n> @@ -46,7 +47,7 @@ public:\n> \tstd::list queuedRequests_;\n> \tControlInfoMap controlInfo_;\n> \tControlList properties_;\n> -\tstd::unique_ptr ipa_;\n> +\tstd::unique_ptr ipa_;\n>\n> private:\n> \tCameraData(const CameraData &) = delete;\n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 50b6792d6cce..df3786797010 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -247,17 +247,17 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n> }\n>\n> /**\n> - * \\brief Create an IPA interface that matches a given pipeline handler\n> - * \\param[in] pipe The pipeline handler that wants a matching IPA interface\n> + * \\brief Create an IPA proxy that matches a given pipeline handler\n> + * \\param[in] pipe The pipeline handler that wants a matching IPA proxy\n> * \\param[in] minVersion Minimum acceptable version of IPA module\n> * \\param[in] maxVersion Maximum acceptable version of IPA module\n> *\n> - * \\return A newly created IPA interface, or nullptr if no matching\n> - * IPA module is found or if the IPA interface fails to initialize\n> + * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n> + * found or if the IPA proxy fails to initialize\n> */\n> -std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n> -\t\t\t\t\t\t uint32_t maxVersion,\n> -\t\t\t\t\t\t uint32_t minVersion)\n> +std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n> +\t\t\t\t\t\tuint32_t maxVersion,\n> +\t\t\t\t\t\tuint32_t minVersion)\n> {\n> \tIPAModule *m = nullptr;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2948F603F8\n\tfor ;\n\tMon, 27 Apr 2020 10:51:18 +0200 (CEST)","from uno.localdomain (a-ur1-85.tin.it [212.216.150.148])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 14A90E0015;\n\tMon, 27 Apr 2020 08:51:16 +0000 (UTC)"],"X-Originating-IP":"212.216.150.148","Date":"Mon, 27 Apr 2020 10:54:27 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200427085427.3zqn6taklsn5gupx@uno.localdomain>","References":"<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>\n\t<20200427031713.14013-7-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200427031713.14013-7-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: ipa_manager: Return\n\tan IPAProxy from createIPA()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 08:51:18 -0000"}},{"id":4573,"web_url":"https://patchwork.libcamera.org/comment/4573/","msgid":"<32577b01-d782-530b-eccc-361d0941f1d2@ideasonboard.com>","date":"2020-04-27T12:30:51","subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: ipa_manager: Return\n\tan IPAProxy from createIPA()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 27/04/2020 04:17, Laurent Pinchart wrote:\n> In order to provide pipeline handlers with IPA-related helpers on top of\n> IPAInterface, return the IPAProxy instance from IPAManager::createIPA().\n> No change is required in the pipeline handlers as the IPAInterface that\n> was previously returned is implemented by an IPAProxy instance already.\n> \n> Signed-off-by: Laurent Pinchart \n\nI guess we'll see how this gets used in the coming patches...\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/include/ipa_manager.h | 6 +++---\n> src/libcamera/include/pipeline_handler.h | 5 +++--\n> src/libcamera/ipa_manager.cpp | 14 +++++++-------\n> 3 files changed, 13 insertions(+), 12 deletions(-)\n> \n> diff --git a/src/libcamera/include/ipa_manager.h b/src/libcamera/include/ipa_manager.h\n> index 6165efb8b145..aa6b9adb1f87 100644\n> --- a/src/libcamera/include/ipa_manager.h\n> +++ b/src/libcamera/include/ipa_manager.h\n> @@ -24,9 +24,9 @@ class IPAManager\n> public:\n> \tstatic IPAManager *instance();\n> \n> -\tstd::unique_ptr createIPA(PipelineHandler *pipe,\n> -\t\t\t\t\t\tuint32_t maxVersion,\n> -\t\t\t\t\t\tuint32_t minVersion);\n> +\tstd::unique_ptr createIPA(PipelineHandler *pipe,\n> +\t\t\t\t\t uint32_t maxVersion,\n> +\t\t\t\t\t uint32_t minVersion);\n> \n> private:\n> \tstd::vector modules_;\n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index 3fcfeda4bfee..706413fa6e9f 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -15,11 +15,12 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> #include \n> #include \n> \n> +#include \"ipa_proxy.h\"\n> +\n> namespace libcamera {\n> \n> class Camera;\n> @@ -46,7 +47,7 @@ public:\n> \tstd::list queuedRequests_;\n> \tControlInfoMap controlInfo_;\n> \tControlList properties_;\n> -\tstd::unique_ptr ipa_;\n> +\tstd::unique_ptr ipa_;\n> \n> private:\n> \tCameraData(const CameraData &) = delete;\n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 50b6792d6cce..df3786797010 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -247,17 +247,17 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n> }\n> \n> /**\n> - * \\brief Create an IPA interface that matches a given pipeline handler\n> - * \\param[in] pipe The pipeline handler that wants a matching IPA interface\n> + * \\brief Create an IPA proxy that matches a given pipeline handler\n> + * \\param[in] pipe The pipeline handler that wants a matching IPA proxy\n> * \\param[in] minVersion Minimum acceptable version of IPA module\n> * \\param[in] maxVersion Maximum acceptable version of IPA module\n> *\n> - * \\return A newly created IPA interface, or nullptr if no matching\n> - * IPA module is found or if the IPA interface fails to initialize\n> + * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n> + * found or if the IPA proxy fails to initialize\n> */\n> -std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n> -\t\t\t\t\t\t uint32_t maxVersion,\n> -\t\t\t\t\t\t uint32_t minVersion)\n> +std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n> +\t\t\t\t\t\tuint32_t maxVersion,\n> +\t\t\t\t\t\tuint32_t minVersion)\n> {\n> \tIPAModule *m = nullptr;\n> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62276603F9\n\tfor ;\n\tMon, 27 Apr 2020 14:30:55 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7CF1972C;\n\tMon, 27 Apr 2020 14:30:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"a+AJE/dL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587990655;\n\tbh=zmrH5uxXzhoiQIrSvgMxwP24pOZZ4+dFoJjq2Gx9ErU=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=a+AJE/dLH8GDR38dJcnsyJMY/DgmXnW/UZWxoiwARXCT2hPV9z9GUbaK53lxS7dHX\n\tZIPYP1ll+ZvxhEZCH8kFlsCSDojLeAC2V5kJJq+UIaLQJ71U/mvtJie7RhrUKY/h7y\n\tnrzjZGqoL94yzaiJj6QQslaK2qZBQy1BcGdlSPp4=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>\n\t<20200427031713.14013-7-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<32577b01-d782-530b-eccc-361d0941f1d2@ideasonboard.com>","Date":"Mon, 27 Apr 2020 13:30:51 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200427031713.14013-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: ipa_manager: Return\n\tan IPAProxy from createIPA()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 12:30:55 -0000"}}]