[{"id":4544,"web_url":"https://patchwork.libcamera.org/comment/4544/","msgid":"<20200427074635.oogeakfsndtbtg6i@uno.localdomain>","date":"2020-04-27T07:46:35","subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipa_proxy: Add\n\tmissing space in info message","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Apr 27, 2020 at 06:17:05AM +0300, Laurent Pinchart wrote:\n> The message printed when loading a proxy worker from the build directory\n> is missing a space. Add it.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/ipa_proxy.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> index 5fd88a4ba75e..22b246be5797 100644\n> --- a/src/libcamera/ipa_proxy.cpp\n> +++ b/src/libcamera/ipa_proxy.cpp\n> @@ -102,7 +102,7 @@ std::string IPAProxy::resolvePath(const std::string &file) const\n> \t\tstd::string ipaProxyDir = root + \"src/libcamera/proxy/worker\";\n>\n> \t\tLOG(IPAProxy, Info)\n> -\t\t\t<< \"libcamera is not installed. Loading proxy workers from'\"\n> +\t\t\t<< \"libcamera is not installed. Loading proxy workers from '\"\n> \t\t\t<< ipaProxyDir << \"'\";\n>\n> \t\tstd::string proxyPath = ipaProxyDir + proxyFile;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 861B5603F8\n\tfor ;\n\tMon, 27 Apr 2020 09:43:25 +0200 (CEST)","from uno.localdomain (a-ur1-85.tin.it [212.216.150.148])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id E884910000D;\n\tMon, 27 Apr 2020 07:43:24 +0000 (UTC)"],"Date":"Mon, 27 Apr 2020 09:46:35 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200427074635.oogeakfsndtbtg6i@uno.localdomain>","References":"<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>\n\t<20200427031713.14013-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200427031713.14013-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipa_proxy: Add\n\tmissing space in info message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 07:43:25 -0000"}},{"id":4545,"web_url":"https://patchwork.libcamera.org/comment/4545/","msgid":"<20200427080918.kd7q2fkh7hplelvt@uno.localdomain>","date":"2020-04-27T08:09:18","subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipa_proxy: Add\n\tmissing space in info message","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi LAurent,\n\nOn Mon, Apr 27, 2020 at 06:17:05AM +0300, Laurent Pinchart wrote:\n> The message printed when loading a proxy worker from the build directory\n> is missing a space. Add it.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/ipa_proxy.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> index 5fd88a4ba75e..22b246be5797 100644\n> --- a/src/libcamera/ipa_proxy.cpp\n> +++ b/src/libcamera/ipa_proxy.cpp\n> @@ -102,7 +102,7 @@ std::string IPAProxy::resolvePath(const std::string &file) const\n> \t\tstd::string ipaProxyDir = root + \"src/libcamera/proxy/worker\";\n>\n> \t\tLOG(IPAProxy, Info)\n> -\t\t\t<< \"libcamera is not installed. Loading proxy workers from'\"\n> +\t\t\t<< \"libcamera is not installed. Loading proxy workers from '\"\n> \t\t\t<< ipaProxyDir << \"'\";\n>\n> \t\tstd::string proxyPath = ipaProxyDir + proxyFile;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A1F7603F8\n\tfor ;\n\tMon, 27 Apr 2020 10:06:09 +0200 (CEST)","from uno.localdomain (a-ur1-85.tin.it [212.216.150.148])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 124526000A;\n\tMon, 27 Apr 2020 08:06:07 +0000 (UTC)"],"X-Originating-IP":"212.216.150.148","Date":"Mon, 27 Apr 2020 10:09:18 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200427080918.kd7q2fkh7hplelvt@uno.localdomain>","References":"<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>\n\t<20200427031713.14013-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200427031713.14013-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipa_proxy: Add\n\tmissing space in info message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 08:06:09 -0000"}},{"id":4548,"web_url":"https://patchwork.libcamera.org/comment/4548/","msgid":"<20200427084701.a5wlxe45wrgg63vs@uno.localdomain>","date":"2020-04-27T08:47:01","subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipa_proxy: Add\n\tmissing space in info message","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"I really like this patch, I've reviewed it twice!\n\nOn Mon, Apr 27, 2020 at 06:17:05AM +0300, Laurent Pinchart wrote:\n> The message printed when loading a proxy worker from the build directory\n> is missing a space. Add it.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/ipa_proxy.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> index 5fd88a4ba75e..22b246be5797 100644\n> --- a/src/libcamera/ipa_proxy.cpp\n> +++ b/src/libcamera/ipa_proxy.cpp\n> @@ -102,7 +102,7 @@ std::string IPAProxy::resolvePath(const std::string &file) const\n> \t\tstd::string ipaProxyDir = root + \"src/libcamera/proxy/worker\";\n>\n> \t\tLOG(IPAProxy, Info)\n> -\t\t\t<< \"libcamera is not installed. Loading proxy workers from'\"\n> +\t\t\t<< \"libcamera is not installed. Loading proxy workers from '\"\n> \t\t\t<< ipaProxyDir << \"'\";\n>\n> \t\tstd::string proxyPath = ipaProxyDir + proxyFile;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59C10603F8\n\tfor ;\n\tMon, 27 Apr 2020 10:43:52 +0200 (CEST)","from uno.localdomain (a-ur1-85.tin.it [212.216.150.148])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id AF8D31BF215;\n\tMon, 27 Apr 2020 08:43:51 +0000 (UTC)"],"X-Originating-IP":"212.216.150.148","Date":"Mon, 27 Apr 2020 10:47:01 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200427084701.a5wlxe45wrgg63vs@uno.localdomain>","References":"<20200427031713.14013-1-laurent.pinchart@ideasonboard.com>\n\t<20200427031713.14013-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200427031713.14013-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipa_proxy: Add\n\tmissing space in info message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 08:43:52 -0000"}}]