[{"id":4556,"web_url":"https://patchwork.libcamera.org/comment/4556/","msgid":"<5aa09a7d-58c8-2ffe-2843-2a4997d77692@ideasonboard.com>","date":"2020-04-27T09:35:27","subject":"Re: [libcamera-devel] [PATCH] qcam: Don't crash if camera can't be\n\topened","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 26/04/2020 23:31, Laurent Pinchart wrote:\n> If the camera specified on the command line can't be opened, the\n> MainWindow constructor still proceeds to check the startStopAction_,\n> which results in MainWindow::startCapture() being called and trying to\n> use a null camera_ object. Fix this by returning from the constructor as\n> soon as the error is detected.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/main_window.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index cf39ed7aceca..ed0cad417d62 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -70,8 +70,10 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n> \n> \t/* Open the camera and start capture. */\n> \tret = openCamera();\n> -\tif (ret < 0)\n> +\tif (ret < 0) {\n> \t\tquit();\n> +\t\treturn;\n> +\t}\n\nAh indeed, I see otherwise it would start the stream on the Checked action.\n\nI wonder if we fail to start the first camera we shouldn't stay running\n(displaying our invalid stream icon), rather than quit()ing. But that's\na separate patch, and would also require changes in\nMainWindow::switchCamera().\n\n\nReviewed-by: Kieran Bingham \n\n> \n> \tstartStopAction_->setChecked(true);\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 38B8360AF3\n\tfor ;\n\tMon, 27 Apr 2020 11:35:32 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 405BB72C;\n\tMon, 27 Apr 2020 11:35:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XUWPxWAQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587980131;\n\tbh=YwqVLo0uyd6CRXZyQaGfa4Gh2YH/iN0GzfOTe3PbpS0=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=XUWPxWAQbcijncKc45oDmeVtCK2WpEPQmAwhjuxSyNVQvOzYH3NWZZhMLU5ddNYEK\n\t6L3jCrOZ8jg3pzyzygOa/w+N64WRdSFm0VjOLroigp0Sf6QdtbN/Lj4WyTheQu+YTC\n\toHvSGzedXAUBCTA5hUNSvpfbQTuS3SUJy0SaQv3M=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200426223126.17943-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5aa09a7d-58c8-2ffe-2843-2a4997d77692@ideasonboard.com>","Date":"Mon, 27 Apr 2020 10:35:27 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.7.0","MIME-Version":"1.0","In-Reply-To":"<20200426223126.17943-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] qcam: Don't crash if camera can't be\n\topened","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 09:35:32 -0000"}},{"id":4566,"web_url":"https://patchwork.libcamera.org/comment/4566/","msgid":"<4B3G9Q.7BVY8MBC4Q0F3@uajain.com>","date":"2020-04-27T11:45:20","subject":"Re: [libcamera-devel] [PATCH] qcam: Don't crash if camera can't be\n\topened","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi,\n\nOn Mon, Apr 27, 2020 at 01:31, Laurent Pinchart \n wrote:\n> If the camera specified on the command line can't be opened, the\n> MainWindow constructor still proceeds to check the startStopAction_,\n> which results in MainWindow::startCapture() being called and trying to\n> use a null camera_ object. Fix this by returning from the constructor \n> as\n> soon as the error is detected.\n> \n> Signed-off-by: Laurent Pinchart >\n> ---\n> src/qcam/main_window.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index cf39ed7aceca..ed0cad417d62 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -70,8 +70,10 @@ MainWindow::MainWindow(CameraManager *cm, const \n> OptionsParser::Options &options)\n> \n> \t/* Open the camera and start capture. */\n> \tret = openCamera();\n> -\tif (ret < 0)\n> +\tif (ret < 0) {\n> \t\tquit();\n> +\t\treturn;\n> +\t}\n> \n> \tstartStopAction_->setChecked(true);\n> }\n\n\nThis also fixes a segfault when the \"Select Camera\" dialog is closed[x] \nto exit QCam (i.e. no camera is selected).\nThanks.\n\nReviewed-by: Umang Jain \n\n> --\n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org \n> \n> ","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77A41603F9\n\tfor ;\n\tMon, 27 Apr 2020 13:45:22 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-4rnwn with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-4rnwn-19-5EA6C5D0-65\n\t2020-04-27 11:45:20.677865752 +0000 UTC m=+2803075.532577087","from mail.uajain.com (unknown)\n\tby ismtpd0001p1maa1.sendgrid.net (SG) with ESMTP\n\tid dwfdNMYvTXy4zlIvdQUIeg Mon, 27 Apr 2020 11:45:19.980 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"eTR8/PbZ\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:content-type;\n\ts=s1; bh=5x6cqB9NdiCJ+ke2tQrHpAFzDeH5Vt+pc5c3LWcVKoc=;\n\tb=eTR8/PbZdY2edQIz2ovtYfIfFtmAV4DV0ShnQV/B3PNd2tRBiD8Kyp2S818FA1vIy0fs\n\teCUWTdt/7yIRqrqzVAbJkudD/zLONTvVb4XfMJdBBc9gBker3+VwDmGaNQyzmpr9ygnisa\n\tvNT/MCltXQVI5LigtyN51SEYEa21Mb8bY=","Date":"Mon, 27 Apr 2020 11:45:20 +0000 (UTC)","From":"Umang Jain ","Message-Id":"<4B3G9Q.7BVY8MBC4Q0F3@uajain.com>","In-Reply-To":"<20200426223126.17943-1-laurent.pinchart@ideasonboard.com>","References":"<20200426223126.17943-1-laurent.pinchart@ideasonboard.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcO0wIVNwfic3Culi7Uik3l5SoTZnd/bnNNNxkDB1yq2cRDrVFaZYYsfCpA4RPSlRF7a6IdcY6+0al9nak8gRWNbYh2og73OyfiHzAeXEAu5obZhBF2ghI/tEi2deWJTpB8nuJdZwFRh2mYi+AVRPvUcNetrsvYanfL9V9iWMCrxtSK0V4AazLRHtLvpsTJUtkFcUFIKFOstJ+Eph2l29iDQ==","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"=-BEs94mkceAOD+yZddDfL\"","Subject":"Re: [libcamera-devel] [PATCH] qcam: Don't crash if camera can't be\n\topened","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 11:45:23 -0000"}},{"id":4572,"web_url":"https://patchwork.libcamera.org/comment/4572/","msgid":"<20200427122844.GE10040@pendragon.ideasonboard.com>","date":"2020-04-27T12:28:44","subject":"Re: [libcamera-devel] [PATCH] qcam: Don't crash if camera can't be\n\topened","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nOn Mon, Apr 27, 2020 at 11:45:20AM +0000, Umang Jain wrote:\n> On Mon, Apr 27, 2020 at 01:31, Laurent Pinchart wrote:\n> > If the camera specified on the command line can't be opened, the\n> > MainWindow constructor still proceeds to check the startStopAction_,\n> > which results in MainWindow::startCapture() being called and trying to\n> > use a null camera_ object. Fix this by returning from the constructor \n> > as soon as the error is detected.\n> > \n> > Signed-off-by: Laurent Pinchart > >\n> > ---\n> > src/qcam/main_window.cpp | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> > index cf39ed7aceca..ed0cad417d62 100644\n> > --- a/src/qcam/main_window.cpp\n> > +++ b/src/qcam/main_window.cpp\n> > @@ -70,8 +70,10 @@ MainWindow::MainWindow(CameraManager *cm, const \n> > OptionsParser::Options &options)\n> > \n> > \t/* Open the camera and start capture. */\n> > \tret = openCamera();\n> > -\tif (ret < 0)\n> > +\tif (ret < 0) {\n> > \t\tquit();\n> > +\t\treturn;\n> > +\t}\n> > \n> > \tstartStopAction_->setChecked(true);\n> > }\n> \n> This also fixes a segfault when the \"Select Camera\" dialog is closed[x] \n> to exit QCam (i.e. no camera is selected).\n\nGood point. I'll add it to the commit message, thanks for reporting it.\n\n> Thanks.\n> \n> Reviewed-by: Umang Jain ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54BDC603F9\n\tfor ;\n\tMon, 27 Apr 2020 14:29:00 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E30DC72C;\n\tMon, 27 Apr 2020 14:28:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"c/W8+qez\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587990540;\n\tbh=dAQeueeAMJLVy7YKzrx6Nn8zDrHhCoLDvyJk5AFJ+vI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=c/W8+qezp4gtjxtTbfLxV4K6qd6j015Lh8rayD4llDqpGY6+0BZKS+RE6j44Cmx/9\n\t+zJ2/JiCqkYjQo+fF3hZ1jfyhQ6+JC52uJtCzE86yHRDrQnKtWQwKm/ZGQRcbsf9AM\n\tklmR1viDVXKv/QJ8i4ztKqMhSRf6QiZqw6ASNDoo=","Date":"Mon, 27 Apr 2020 15:28:44 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200427122844.GE10040@pendragon.ideasonboard.com>","References":"<20200426223126.17943-1-laurent.pinchart@ideasonboard.com>\n\t<4B3G9Q.7BVY8MBC4Q0F3@uajain.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<4B3G9Q.7BVY8MBC4Q0F3@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH] qcam: Don't crash if camera can't be\n\topened","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 Apr 2020 12:29:00 -0000"}}]