{"id":3541,"url":"https://patchwork.libcamera.org/api/patches/3541/?format=json","web_url":"https://patchwork.libcamera.org/patch/3541/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200425004533.26907-8-laurent.pinchart@ideasonboard.com>","date":"2020-04-25T00:45:33","name":"[libcamera-devel,v5,7/7] libcamera: controls: Add AWB related controls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"af3860b768df814d3d7a3e95b92d709c782006be","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3541/mbox/","series":[{"id":824,"url":"https://patchwork.libcamera.org/api/series/824/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=824","date":"2020-04-25T00:45:26","name":"Patchset for libcamera controls","version":5,"mbox":"https://patchwork.libcamera.org/series/824/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3541/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3541/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 107C462E67\n\tfor ;\n\tSat, 25 Apr 2020 02:45:55 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 90B27A2A;\n\tSat, 25 Apr 2020 02:45:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rXC6WOQi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587775554;\n\tbh=Oi1jVtSGbQr9uMAM40281tGAzsmNj2397nd0PAcwxg0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rXC6WOQiiAG8cEB5IRgzhVjs2qHsjObHI5NEjXkHNnbYeCbsHnNrUgtj+DedUAJUD\n\tJyNArGgls9Ygmtrgc3b/iiJRnrXmre0gSpRV5BcKryyCzFnCfrLWIvv8uh9sAfuAzS\n\tSFVLZq7dSZqyULqXGDIkQp+JwgyVbLDt4fXfFhD0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 25 Apr 2020 03:45:33 +0300","Message-Id":"<20200425004533.26907-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.25.3","In-Reply-To":"<20200425004533.26907-1-laurent.pinchart@ideasonboard.com>","References":"<20200425004533.26907-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 7/7] libcamera: controls: Add AWB\n\trelated controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 25 Apr 2020 00:45:56 -0000"},"content":"From: Naushir Patuck \n\nAwbMode is a new enum type to specify operating mode of the AWB\nalgorithm. All modes may not be supported by all platforms.\n\nColourGains is a new float array type used to specify manual red\nand blue (in that order) colour channel gains when AWB is disabled.\n\nColourTemperature is a new control to return the current estimate of the\ncolour temperature.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Laurent Pinchart \nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/control_ids.yaml | 55 ++++++++++++++++++++++++++++++++++\n 1 file changed, 55 insertions(+)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 0907167fccea..b419f8a78c19 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -169,6 +169,61 @@ controls:\n description: |\n Enable or disable the AWB.\n \n+ \\sa ColourGains\n+\n+ # AwbMode needs further attention:\n+ # - Auto-generate max enum value.\n+ # - Better handling of custom types.\n+ - AwbMode:\n+ type: int32_t\n+ description: |\n+ Specify the range of illuminants to use for the AWB algorithm. The modes\n+ supported are platform specific, and not all modes may be supported.\n+ enum:\n+ - name: AwbAuto\n+ value: 0\n+ description: Search over the whole colour temperature range.\n+ - name: AwbIncandescent\n+ value: 1\n+ description: Incandescent AWB lamp mode.\n+ - name: AwbTungsten\n+ value: 2\n+ description: Tungsten AWB lamp mode.\n+ - name: AwbFluorescent\n+ value: 3\n+ description: Fluorescent AWB lamp mode.\n+ - name: AwbIndoor\n+ value: 4\n+ description: Indoor AWB lighting mode.\n+ - name: AwbDaylight\n+ value: 5\n+ description: Daylight AWB lighting mode.\n+ - name: AwbCloudy\n+ value: 6\n+ description: Cloudy AWB lighting mode.\n+ - name: AwbCustom\n+ value: 7\n+ description: Custom AWB mode.\n+ - name: AwbModeMax\n+ value: 7\n+ description: Maximum allowed value (place any new values above here).\n+\n+ - ColourGains:\n+ type: float\n+ description: |\n+ Pair of gain values for the Red and Blue colour channels, in that\n+ order. ColourGains can only be applied in a Request when the AWB is\n+ disabled.\n+\n+ \\sa AwbEnable\n+ size: [2]\n+\n+ - ColourTemperature:\n+ type: int32_t\n+ description: Report the current estimate of the colour temperature, in\n+ kelvin, for this frame. The ColourTemperature control can only be\n+ returned in metadata.\n+\n - Saturation:\n type: float\n description: |\n","prefixes":["libcamera-devel","v5","7/7"]}