[{"id":4530,"web_url":"https://patchwork.libcamera.org/comment/4530/","msgid":"<20200426145048.3ktjjrfbalcqonig@uno.localdomain>","date":"2020-04-26T14:50:48","subject":"Re: [libcamera-devel] [PATCH 1/2] cam: Rename OptProps to\n\tOptListProperties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sat, Apr 25, 2020 at 02:42:36AM +0300, Laurent Pinchart wrote:\n> The name OptProps is not very clear, spell it out fully. The command\n> line options are not changed.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/cam/main.cpp | 4 ++--\n> src/cam/main.h | 2 +-\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 718740f49762..340849e74ddd 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -182,7 +182,7 @@ int CamApp::parseOptions(int argc, char *argv[])\n> \tparser.addOption(OptInfo, OptionNone,\n> \t\t\t \"Display information about stream(s)\", \"info\");\n> \tparser.addOption(OptList, OptionNone, \"List all cameras\", \"list\");\n> -\tparser.addOption(OptProps, OptionNone, \"List cameras properties\",\n> +\tparser.addOption(OptListProperties, OptionNone, \"List cameras properties\",\n> \t\t\t \"list-properties\");\n>\n> \toptions_ = parser.parse(argc, argv);\n> @@ -339,7 +339,7 @@ int CamApp::run()\n> \t\t}\n> \t}\n>\n> -\tif (options_.isSet(OptProps)) {\n> +\tif (options_.isSet(OptListProperties)) {\n> \t\tret = listProperties();\n> \t\tif (ret)\n> \t\t\treturn ret;\n> diff --git a/src/cam/main.h b/src/cam/main.h\n> index afcad4353b7d..d23c6dfb202e 100644\n> --- a/src/cam/main.h\n> +++ b/src/cam/main.h\n> @@ -14,7 +14,7 @@ enum {\n> \tOptHelp = 'h',\n> \tOptInfo = 'I',\n> \tOptList = 'l',\n> -\tOptProps = 'p',\n> +\tOptListProperties = 'p',\n> \tOptStream = 's',\n> };\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 283EF603FA\n\tfor ;\n\tSun, 26 Apr 2020 16:47:41 +0200 (CEST)","from uno.localdomain\n\t(host170-48-dynamic.3-87-r.retail.telecomitalia.it [87.3.48.170])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 8F7261C0003;\n\tSun, 26 Apr 2020 14:47:39 +0000 (UTC)"],"X-Originating-IP":"87.3.48.170","Date":"Sun, 26 Apr 2020 16:50:48 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200426145048.3ktjjrfbalcqonig@uno.localdomain>","References":"<20200424234237.19604-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200424234237.19604-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] cam: Rename OptProps to\n\tOptListProperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 26 Apr 2020 14:47:41 -0000"}}]