{"id":3532,"url":"https://patchwork.libcamera.org/api/patches/3532/?format=json","web_url":"https://patchwork.libcamera.org/patch/3532/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200424234237.19604-1-laurent.pinchart@ideasonboard.com>","date":"2020-04-24T23:42:36","name":"[libcamera-devel,1/2] cam: Rename OptProps to OptListProperties","commit_ref":"36ab14e12d25ec8277fe44a0f4ebb5402b9df38e","pull_url":null,"state":"accepted","archived":false,"hash":"dd0b5531b03ba0b1e89852443bfa5da8d3148be5","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3532/mbox/","series":[{"id":823,"url":"https://patchwork.libcamera.org/api/series/823/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=823","date":"2020-04-24T23:42:36","name":"[libcamera-devel,1/2] cam: Rename OptProps to OptListProperties","version":1,"mbox":"https://patchwork.libcamera.org/series/823/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3532/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3532/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0064762E45\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 25 Apr 2020 01:42:55 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F9EC4F7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 25 Apr 2020 01:42:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Uo2nfifH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587771775;\n\tbh=2Uf4l/N8DPu6IyyMfy06w3OZaoGbpPm2/glfmJA4Osw=;\n\th=From:To:Subject:Date:From;\n\tb=Uo2nfifHcbKJXFrW2rHq3E1SaBrQXFKKJzJfgoIbxoShzmalikMu6VfhT2wiKihln\n\tJF8HWeqOkFl1EY5coolRJjaMiwHvxiNPxgi//tSX8El2UwnYLvIXG5TfV06vix+fdR\n\thtHwRJFcPnBLTMae7xKWEQ+nk+qGwd0r41Zu4mRE=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 25 Apr 2020 02:42:36 +0300","Message-Id":"<20200424234237.19604-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.25.3","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] cam: Rename OptProps to\n\tOptListProperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 24 Apr 2020 23:42:57 -0000"},"content":"The name OptProps is not very clear, spell it out fully. The command\nline options are not changed.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/main.cpp | 4 ++--\n src/cam/main.h   | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 718740f49762..340849e74ddd 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -182,7 +182,7 @@ int CamApp::parseOptions(int argc, char *argv[])\n \tparser.addOption(OptInfo, OptionNone,\n \t\t\t \"Display information about stream(s)\", \"info\");\n \tparser.addOption(OptList, OptionNone, \"List all cameras\", \"list\");\n-\tparser.addOption(OptProps, OptionNone, \"List cameras properties\",\n+\tparser.addOption(OptListProperties, OptionNone, \"List cameras properties\",\n \t\t\t \"list-properties\");\n \n \toptions_ = parser.parse(argc, argv);\n@@ -339,7 +339,7 @@ int CamApp::run()\n \t\t}\n \t}\n \n-\tif (options_.isSet(OptProps)) {\n+\tif (options_.isSet(OptListProperties)) {\n \t\tret = listProperties();\n \t\tif (ret)\n \t\t\treturn ret;\ndiff --git a/src/cam/main.h b/src/cam/main.h\nindex afcad4353b7d..d23c6dfb202e 100644\n--- a/src/cam/main.h\n+++ b/src/cam/main.h\n@@ -14,7 +14,7 @@ enum {\n \tOptHelp = 'h',\n \tOptInfo = 'I',\n \tOptList = 'l',\n-\tOptProps = 'p',\n+\tOptListProperties = 'p',\n \tOptStream = 's',\n };\n \n","prefixes":["libcamera-devel","1/2"]}