[{"id":4521,"web_url":"https://patchwork.libcamera.org/comment/4521/","msgid":"<20200425210506.GF10975@pendragon.ideasonboard.com>","date":"2020-04-25T21:05:06","subject":"Re: [libcamera-devel] [PATCH v3 12/13] libcamera: v4l2_device:\n\tUpdate documentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Apr 24, 2020 at 11:53:03PM +0200, Jacopo Mondi wrote:\n> Compound controls are now supported, but they're still listed as\n> unsupported in some parts of the V4L2Device class documentation.\n> Fix this by removing those parts.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n(and can be merged already)\n\n> ---\n> src/libcamera/v4l2_device.cpp | 19 +++++++++----------\n> 1 file changed, 9 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 9d67e0f63b1e..da7eb2bc5849 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -153,9 +153,9 @@ void V4L2Device::close()\n> * their values in the corresponding \\a ctrls entry.\n> *\n> * If any control in \\a ctrls is not supported by the device, is disabled (i.e.\n> - * has the V4L2_CTRL_FLAG_DISABLED flag set), is a compound control, or if any\n> - * other error occurs during validation of the requested controls, no control is\n> - * read and this method returns -EINVAL.\n> + * has the V4L2_CTRL_FLAG_DISABLED flag set), or if any other error occurs\n> + * during validation of the requested controls, no control is read and this\n> + * method returns -EINVAL.\n> *\n> * If an error occurs while reading the controls, the index of the first control\n> * that couldn't be read is returned. The value of all controls below that index\n> @@ -262,10 +262,9 @@ int V4L2Device::getControls(ControlList *ctrls)\n> * \\a ctrls entry.\n> *\n> * If any control in \\a ctrls is not supported by the device, is disabled (i.e.\n> - * has the V4L2_CTRL_FLAG_DISABLED flag set), is read-only, is a\n> - * compound control, or if any other error occurs during validation of\n> - * the requested controls, no control is written and this method returns\n> - * -EINVAL.\n> + * has the V4L2_CTRL_FLAG_DISABLED flag set), is read-only, if any other error\n> + * occurs during validation of the requested controls, no control is written and\n> + * this method returns -EINVAL.\n> *\n> * If an error occurs while writing the controls, the index of the first\n> * control that couldn't be written is returned. All controls below that index\n> @@ -395,7 +394,7 @@ void V4L2Device::listControls()\n> \tControlInfoMap::Map ctrls;\n> \tstruct v4l2_query_ext_ctrl ctrl = {};\n> \n> -\t/* \\todo Add support for menu and compound controls. */\n> +\t/* \\todo Add support for menu controls. */\n> \twhile (1) {\n> \t\tctrl.id |= V4L2_CTRL_FLAG_NEXT_CTRL |\n> \t\t\t V4L2_CTRL_FLAG_NEXT_COMPOUND;\n> @@ -468,8 +467,8 @@ void V4L2Device::updateControls(ControlList *ctrls,\n> \n> \t\tdefault:\n> \t\t\t/*\n> -\t\t\t * \\todo To be changed when support for string and\n> -\t\t\t * compound controls will be added.\n> +\t\t\t * \\todo To be changed when support for string controls\n> +\t\t\t * will be added.\n> \t\t\t */\n> \t\t\tvalue.set(v4l2Ctrl->value);\n> \t\t\tbreak;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42D33603FC\n\tfor ;\n\tSat, 25 Apr 2020 23:05:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D1A664F7;\n\tSat, 25 Apr 2020 23:05:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OiKO4fQs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587848722;\n\tbh=besGF26zCSJMESgKz0Nu/3ucIVVqmFgVX7mKUTmhb98=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OiKO4fQsdFJX6dPr8V4m3NSnrTyCwIMlA4k6eA+E2B0lYLw6CHWbafXYJqd7Y5DIX\n\t7cBdOXIDCX4bvw6eVEixbKYz/YxM3Jv6hkJJe8XbE63xOtnlZRIUSkgpdsUamwEx1c\n\t9T1Ebw/xpIUZFNrvEadUE235FmM8RfBHrvVHLcv0=","Date":"Sun, 26 Apr 2020 00:05:06 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200425210506.GF10975@pendragon.ideasonboard.com>","References":"<20200424215304.558317-1-jacopo@jmondi.org>\n\t<20200424215304.558317-13-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200424215304.558317-13-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 12/13] libcamera: v4l2_device:\n\tUpdate documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 25 Apr 2020 21:05:22 -0000"}}]