[{"id":4506,"web_url":"https://patchwork.libcamera.org/comment/4506/","msgid":"<20200425022122.GC19672@pendragon.ideasonboard.com>","date":"2020-04-25T02:21:22","subject":"Re: [libcamera-devel] [PATCH v3 03/13] libcamera: properties:\n\tDefine 'lens' properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nMaybe s/'lens'/lens/ in the subject ?\n\n\nOn Fri, Apr 24, 2020 at 11:52:54PM +0200, Jacopo Mondi wrote:\n> Define properties that describe the optical characteristics of the image\n> sensor.\n> \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/property_ids.yaml | 34 +++++++++++++++++++++++++++++++++\n> 1 file changed, 34 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 8f6797723a9d..0402e317f170 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -541,4 +541,38 @@ controls:\n> The range of supported ISO sensitivities, as documented by the\n> ISO 12232:2006 (or later) standard.\n> \n> + - LensApertures:\n> + type: float\n> + size: [n]\n> + description: |\n> + The available lens apertures, expressed as f numbers (the ratio between\n> + the lens focal distance and the diameter of the pupil aperture).\n> +\n> + If the camera module has a fixed aperture, the property transports a\n\ns/transports/contains/ ?\n\nAssuming a fixed focal length and a variable aperture, what values is\nthis supposed to report ? The available apertures are a continuous range\nfrom min to max, what's the rule to create discrete values ?\n\nEven more complex, what discrete values should be reported when both the\nfocal length and the aperture are variable (and continuous) ?\n\n> + single value.\n> +\n> + - LensFocalLengths:\n> + type: float\n> + size: [n]\n> + description: |\n> + The available lens focal lengths, expressed in millimeters.\n> +\n> + If the camera module supports multiple focal lengths this property\n> + reports the focal lengths associated with each discrete step. For\n> + camera modules with a single focal length, a single value should be\n> + instead reported.\n\nSame question here, how is this made discrete from a continuous range ?\n\n> +\n> + - LensHyperfocalDistances:\n> + type: float\n> + size: [n]\n\nCan a lens have multiple hyperfocal distances ?\n\n> + description: |\n> + The hyperfocal distance of the camera module. The property is\n\nI assume this one is also expressed in millimeters, but that should be\ndocumented.\n\n> + particularly meaningful for modules with a single focal length.\n\nHow so ?\n\n> +\n> + - LensMinimumFocusDistance:\n> + type: float\n> + description: |\n> + The shortest distance in millimeters at which an object could be brought\n> + into sharp focus.\n> +\n> ...","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E3CF603F8\n\tfor ;\n\tSat, 25 Apr 2020 04:21:37 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EECF84F7;\n\tSat, 25 Apr 2020 04:21:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"E+ouijg5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587781297;\n\tbh=OK+k8osUj806fyRoTxixX+rehD7VpT9aM9nkowXxuSM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=E+ouijg5rX1/qxuqVF1XeAo3iVfB8yIJRQqapWSY2BCfVhdN9fDyEqPu4alyqQH98\n\t6tdQUKShAiL2/NWp57L4i2on7qKBaqU1pO5y8ymC/NcLwps/CKTr8W0xHchfInsuCh\n\t2UmEwuJheDPHoarxAwv+I0Dv7VZ7pKnCeyh+iCOc=","Date":"Sat, 25 Apr 2020 05:21:22 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200425022122.GC19672@pendragon.ideasonboard.com>","References":"<20200424215304.558317-1-jacopo@jmondi.org>\n\t<20200424215304.558317-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200424215304.558317-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 03/13] libcamera: properties:\n\tDefine 'lens' properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 25 Apr 2020 02:21:37 -0000"}}]