[{"id":4502,"web_url":"https://patchwork.libcamera.org/comment/4502/","msgid":"<20200424131104.GH5954@pendragon.ideasonboard.com>","date":"2020-04-24T13:11:04","subject":"Re: [libcamera-devel] [PATCH v4 3/5] libcamera: controls: Reorder\n\tand update description of existing controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Apr 24, 2020 at 11:46:58AM +0100, Naushir Patuck wrote:\n> Group AE, AWB, etc. controls together for accessibility.\n> \n> Update descriptions for Contrast, Brightness, and Saturation controls.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids.yaml | 41 ++++++++++++++++++++--------------\n> 1 file changed, 24 insertions(+), 17 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index d8bdb382..f7403081 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -25,23 +25,6 @@ controls:\n> \n> \\sa AeEnable\n> \n> - - AwbEnable:\n> - type: bool\n> - description: |\n> - Enable or disable the AWB.\n> -\n> - - Brightness:\n> - type: int32_t\n> - description: Specify a fixed brightness parameter\n> -\n> - - Contrast:\n> - type: int32_t\n> - description: Specify a fixed contrast parameter\n> -\n> - - Saturation:\n> - type: int32_t\n> - description: Specify a fixed saturation parameter\n> -\n> - ExposureTime:\n> type: int32_t\n> description: |\n> @@ -58,4 +41,28 @@ controls:\n> colour channels. This value cannot be lower than 1.0.\n> \n> \\sa ExposureTime AeEnable\n> +\n> + - Brightness:\n> + type: float\n> + description: |\n> + Specify a fixed brightness parameter. Positive values (up to 65535.0)\n> + produce brighter images; negative values (up to -65536.0) produce darker\n> + images and 0.0 leaves pixels unchanged.\n\nMaybe a bit of a stupid question, but if we use a float, the proposed\nrange seems a bit awkward to me. Should we go for a [-1.0, +1.0] range ?\n\n> +\n> + - Contrast:\n> + type: float\n> + description: |\n> + Specify a fixed contrast parameter. Normal contrast is given by the\n> + value 1.0; larger values produce images with more contrast.\n> +\n> + - AwbEnable:\n> + type: bool\n> + description: |\n> + Enable or disable the AWB.\n> +\n> + - Saturation:\n> + type: float\n> + description: |\n> + Specify a fixed saturation parameter. Normal saturation is given by\n> + the value 1.0; larger values produce more saturated colours.\n\nIs it worth adding that 0.0 produces greyscale images ?\n\nLet's not spend too much time on this, I'm sure we'll have a chance to\nrework these controls later anyway.\n\nWith the above two issues addressed,\n\nReviewed-by: Laurent Pinchart \n\nI can also update the patch when applying if you're fine with the above\nproposals.\n\n> ...","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A426D603FC\n\tfor ;\n\tFri, 24 Apr 2020 15:11:19 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 171A14F7;\n\tFri, 24 Apr 2020 15:11:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kaG4Pgmz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587733879;\n\tbh=2x3cILcfPiLapzCDqUq1up+U3Y4NQxkEoc4Na6Wi9es=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kaG4PgmzkLhC/8LcMN1Oib7M3c1HVE6LCOpaaqir4KKW0rbEljMTMFSkgu/oL22d/\n\ttfbhamnre1wiximA6+iCUYiSWYE3yYXhoRJ4b/vEfLAhCdNv4cqlzlncWc/tE17QEg\n\tSiq612NcKhIFqnUJlnePcgZqxTyJx7kANNte4PZI=","Date":"Fri, 24 Apr 2020 16:11:04 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200424131104.GH5954@pendragon.ideasonboard.com>","References":"<20200424104700.26819-1-naush@raspberrypi.com>\n\t<20200424104700.26819-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200424104700.26819-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v4 3/5] libcamera: controls: Reorder\n\tand update description of existing controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 24 Apr 2020 13:11:19 -0000"}},{"id":4503,"web_url":"https://patchwork.libcamera.org/comment/4503/","msgid":"","date":"2020-04-24T13:32:28","subject":"Re: [libcamera-devel] [PATCH v4 3/5] libcamera: controls: Reorder\n\tand update description of existing controls","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Fri, 24 Apr 2020 at 14:11, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Fri, Apr 24, 2020 at 11:46:58AM +0100, Naushir Patuck wrote:\n> > Group AE, AWB, etc. controls together for accessibility.\n> >\n> > Update descriptions for Contrast, Brightness, and Saturation controls.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/control_ids.yaml | 41 ++++++++++++++++++++--------------\n> > 1 file changed, 24 insertions(+), 17 deletions(-)\n> >\n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index d8bdb382..f7403081 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -25,23 +25,6 @@ controls:\n> >\n> > \\sa AeEnable\n> >\n> > - - AwbEnable:\n> > - type: bool\n> > - description: |\n> > - Enable or disable the AWB.\n> > -\n> > - - Brightness:\n> > - type: int32_t\n> > - description: Specify a fixed brightness parameter\n> > -\n> > - - Contrast:\n> > - type: int32_t\n> > - description: Specify a fixed contrast parameter\n> > -\n> > - - Saturation:\n> > - type: int32_t\n> > - description: Specify a fixed saturation parameter\n> > -\n> > - ExposureTime:\n> > type: int32_t\n> > description: |\n> > @@ -58,4 +41,28 @@ controls:\n> > colour channels. This value cannot be lower than 1.0.\n> >\n> > \\sa ExposureTime AeEnable\n> > +\n> > + - Brightness:\n> > + type: float\n> > + description: |\n> > + Specify a fixed brightness parameter. Positive values (up to 65535.0)\n> > + produce brighter images; negative values (up to -65536.0) produce darker\n> > + images and 0.0 leaves pixels unchanged.\n>\n> Maybe a bit of a stupid question, but if we use a float, the proposed\n> range seems a bit awkward to me. Should we go for a [-1.0, +1.0] range ?\n>\n> > +\n> > + - Contrast:\n> > + type: float\n> > + description: |\n> > + Specify a fixed contrast parameter. Normal contrast is given by the\n> > + value 1.0; larger values produce images with more contrast.\n> > +\n> > + - AwbEnable:\n> > + type: bool\n> > + description: |\n> > + Enable or disable the AWB.\n> > +\n> > + - Saturation:\n> > + type: float\n> > + description: |\n> > + Specify a fixed saturation parameter. Normal saturation is given by\n> > + the value 1.0; larger values produce more saturated colours.\n>\n> Is it worth adding that 0.0 produces greyscale images ?\n>\n> Let's not spend too much time on this, I'm sure we'll have a chance to\n> rework these controls later anyway.\n>\n\nBoth suggestions here are good with us. Please go ahead and make the\nchanges before merging if that's ok.\n\nRegards,\nNaush\n\n> With the above two issues addressed,\n>\n> Reviewed-by: Laurent Pinchart \n>\n> I can also update the patch when applying if you're fine with the above\n> proposals.\n>\n> > ...\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FA4B603FC\n\tfor ;\n\tFri, 24 Apr 2020 15:32:45 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id x23so7714692lfq.1\n\tfor ;\n\tFri, 24 Apr 2020 06:32:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"bvm6Kj8c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=1TWoAtZB8kWqWmtUttn/faJFyg44BO9nEehWyh1GreY=;\n\tb=bvm6Kj8cthhHgol65Cen8tXGH9wBrpijdgQMmAzUDy8QJgBMhhlpUYQUwa5ZsFeHJL\n\toY64IVRlIr5sVb/vpDd/gQyJgOLh5/S5c6sU8C5OMIs8G+nvQZWo56Vl4gLbKja3VjxY\n\tcIIDSuzSqs/tvuDSNwm2kjhvd1o8qKsxDA3xMXTPRQiVffFrBTVWAV6YykqtRF+DBUMa\n\tBJp3LX2luEDfGQepibqjAyclOs1oLg/UTzuV49F9vVHE6JLP42IPOIYQpGGljTUIFj04\n\tqupVlJEmoJDQlMZA4AMEJCQhgWaMvh0u/+GWypIM5mjyA2srDSVk/r0VNd+fYUY8qLJU\n\tVS6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=1TWoAtZB8kWqWmtUttn/faJFyg44BO9nEehWyh1GreY=;\n\tb=goDyHPowc2rGF9Vn0WF2/bgHz39e1S0lFAkXsp3ebDg8PnI6KZ5MDy3tBvzcR0LMy/\n\tCPC/odL4F5HxGzAkhqcaqVXc+hYJmNTruc2HTyMJGD8C8O1IXvob+NwaNKfm/+jXPwqy\n\tua3joBh7ZwpZHbwHNNPgIvJc5snN/hxvIRuCdQDsFwA0XqV/4VTlUKnroxiNVbmIZgpJ\n\ttzkex7mgpWcheEH1qnN8DVkFfP2iTNo0Gab7pSckR7J3xuROtWxBjvK5X0cx9WF5lxZA\n\tvFbwisCzWLJNsgGIKJvI7ohRkIKotC8dWEmpHuLeZzUXPikQf+8VCNh+Rg7a1ixHupAw\n\tVLwA==","X-Gm-Message-State":"AGi0PubkDBBSlvEsbUsZ/0d8jMtvXvXE01ZA5NPwLtKHtMcvWSKwwj6L\n\tg3z0ZVDr3YPTiEA75Nq5aQBbun6dxSBOHhC13u7dUs0PRyY=","X-Google-Smtp-Source":"APiQypKb5dZpwaN1mI+LqWIjtvss+3pmNMeU2lBG4KHTyj4HOqRfqx/NAQsEQfrmfAgO70KVrPsXvnnOQho4BXOEa/M=","X-Received":"by 2002:ac2:5c4e:: with SMTP id s14mr6420515lfp.77.1587735164114;\n\tFri, 24 Apr 2020 06:32:44 -0700 (PDT)","MIME-Version":"1.0","References":"<20200424104700.26819-1-naush@raspberrypi.com>\n\t<20200424104700.26819-4-naush@raspberrypi.com>\n\t<20200424131104.GH5954@pendragon.ideasonboard.com>","In-Reply-To":"<20200424131104.GH5954@pendragon.ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 24 Apr 2020 14:32:28 +0100","Message-ID":"","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v4 3/5] libcamera: controls: Reorder\n\tand update description of existing controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 24 Apr 2020 13:32:45 -0000"}}]