{"id":3515,"url":"https://patchwork.libcamera.org/api/patches/3515/?format=json","web_url":"https://patchwork.libcamera.org/patch/3515/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200424104700.26819-4-naush@raspberrypi.com>","date":"2020-04-24T10:46:58","name":"[libcamera-devel,v4,3/5] libcamera: controls: Reorder and update description of existing controls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8a06fa97c8da54ec36906110688ffc12f52352ca","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3515/mbox/","series":[{"id":821,"url":"https://patchwork.libcamera.org/api/series/821/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=821","date":"2020-04-24T10:46:55","name":"Patchset for libcamera controls","version":4,"mbox":"https://patchwork.libcamera.org/series/821/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3515/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3515/checks/","tags":{},"headers":{"Return-Path":"","Received":["from mail-wm1-x344.google.com (mail-wm1-x344.google.com\n\t[IPv6:2a00:1450:4864:20::344])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0726A62E4D\n\tfor ;\n\tFri, 24 Apr 2020 12:47:15 +0200 (CEST)","by mail-wm1-x344.google.com with SMTP id h2so9922570wmb.4\n\tfor ;\n\tFri, 24 Apr 2020 03:47:15 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tj68sm7884997wrj.32.2020.04.24.03.47.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Apr 2020 03:47:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"KawmfeBS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=T1pRuMpSBIYfzjOqeocQU2uGXm5/J6+ZUKEx+rcA7Go=;\n\tb=KawmfeBSrzCmMpjUS6jzgSEaswBH5yA/Z5zT1WdHzsYPTxxhx5iNPpGdAV+67LEueA\n\thtTnt3e2e31RZYPGzcqoZRFBL197VDnc4jTaW8D46lZnQ4nMj2hRGnsJu4wXFaxTdCkv\n\tcUkLjkcZ3avDYhKcjs4q6FZBkMtcNg2Yf/gorpTJOwoBa3zuqR/xGIc2cMOOFVnhAOEE\n\tvPmJ49oKwsR2CWlBNeTXOAdwRh1tClifgrTJpoQz9Fj4sImFjCkNcup/xGd3MNj2iD0E\n\txcAZABvq+UbFnWBfPd0S0BY+3oFUFDd3yvIIX/EgR0dGbv2NERWWu8kNK5K7NeNj6hg4\n\ticzw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=T1pRuMpSBIYfzjOqeocQU2uGXm5/J6+ZUKEx+rcA7Go=;\n\tb=pTbwZCipkXjrfTwB618IhQnYvZhD5rP2A1SBCm/Sq3SFRtKQplrpa/sJIFI4JDm5L/\n\tfDCGGe5lc6J7putguMnXfzfuE7J7r2ECdzNTu9aQccNFtNLIi+I5EdcIIZ1Z0jBLAhHK\n\taW1Wq/i8rrA4v2wDKZMCut9T1NVel/pV3waNRb5MoW7GKWpHGVmLaY2R21KgnS+vRqRn\n\tolzbcDmbsoAqQNNR+n38tCKZjsvPl66VDMVY92pzcXd3kr/eLPEFQsaE877KMmDnhP/8\n\tK2ZRCf9ddexlLprGZnwlVX5GH1aKj0oADAzZzQd+P3ob7O1LkJDZObf3BxrUhp8j5DzV\n\tMZtg==","X-Gm-Message-State":"AGi0PuaVVdE1dylJ+BFqq4AXB9LqpOQpugNPCY9n7dhVPr7OIvNE9r0R\n\txFVlvUwLR5v5FSC2Q9haFdcUy73UTAwMdA==","X-Google-Smtp-Source":"APiQypI84gD54UfPxLC//1KKQMXye0vOpQi5waFhVt56x1v/4BLALKHSjEjkPdF1Q3pbo3UUm5GLPQ==","X-Received":"by 2002:a1c:148:: with SMTP id 69mr9743669wmb.181.1587725234560; \n\tFri, 24 Apr 2020 03:47:14 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 24 Apr 2020 11:46:58 +0100","Message-Id":"<20200424104700.26819-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20200424104700.26819-1-naush@raspberrypi.com>","References":"<20200424104700.26819-1-naush@raspberrypi.com>","Subject":"[libcamera-devel] [PATCH v4 3/5] libcamera: controls: Reorder and\n\tupdate description of existing controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 24 Apr 2020 10:47:15 -0000"},"content":"Group AE, AWB, etc. controls together for accessibility.\n\nUpdate descriptions for Contrast, Brightness, and Saturation controls.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/control_ids.yaml | 41 ++++++++++++++++++++--------------\n 1 file changed, 24 insertions(+), 17 deletions(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex d8bdb382..f7403081 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -25,23 +25,6 @@ controls:\n \n \\sa AeEnable\n \n- - AwbEnable:\n- type: bool\n- description: |\n- Enable or disable the AWB.\n-\n- - Brightness:\n- type: int32_t\n- description: Specify a fixed brightness parameter\n-\n- - Contrast:\n- type: int32_t\n- description: Specify a fixed contrast parameter\n-\n- - Saturation:\n- type: int32_t\n- description: Specify a fixed saturation parameter\n-\n - ExposureTime:\n type: int32_t\n description: |\n@@ -58,4 +41,28 @@ controls:\n colour channels. This value cannot be lower than 1.0.\n \n \\sa ExposureTime AeEnable\n+\n+ - Brightness:\n+ type: float\n+ description: |\n+ Specify a fixed brightness parameter. Positive values (up to 65535.0)\n+ produce brighter images; negative values (up to -65536.0) produce darker\n+ images and 0.0 leaves pixels unchanged.\n+\n+ - Contrast:\n+ type: float\n+ description: |\n+ Specify a fixed contrast parameter. Normal contrast is given by the\n+ value 1.0; larger values produce images with more contrast.\n+\n+ - AwbEnable:\n+ type: bool\n+ description: |\n+ Enable or disable the AWB.\n+\n+ - Saturation:\n+ type: float\n+ description: |\n+ Specify a fixed saturation parameter. Normal saturation is given by\n+ the value 1.0; larger values produce more saturated colours.\n ...\n","prefixes":["libcamera-devel","v4","3/5"]}