[{"id":4498,"web_url":"https://patchwork.libcamera.org/comment/4498/","msgid":"<20200424105443.GC5954@pendragon.ideasonboard.com>","date":"2020-04-24T10:54:43","subject":"Re: [libcamera-devel] [PATCH v4 1/5] libcamera: control_ids: Add\n\tcomment to specify control direction","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Apr 24, 2020 at 11:46:56AM +0100, Naushir Patuck wrote:\n> Document that controls are bi-directional by default. If a control\n> is only returned in metadata, this must be specified in the control's\n> description.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/control_ids.cpp.in | 3 +++\n> src/libcamera/control_ids.yaml | 2 ++\n> 2 files changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in\n> index 99c511d0..cba6258d 100644\n> --- a/src/libcamera/control_ids.cpp.in\n> +++ b/src/libcamera/control_ids.cpp.in\n> @@ -33,6 +33,9 @@ ${controls_def}\n> \n> /**\n> * \\brief List of all supported libcamera controls\n> + *\n> + * Unless otherwise stated, all controls are bi-directional, i.e. they can be\n> + * set through Request::controls() and returned out through Request::metadata().\n> */\n> extern const ControlIdMap controls {\n> ${controls_map}\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 4befec74..bcbab195 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -4,6 +4,8 @@\n> #\n> %YAML 1.2\n> ---\n> +# Unless otherwise stated, all controls are bi-directional, i.e. they can be\n> +# set through Request::controls() and returned out through Request::metadata().\n> controls:\n> - AeEnable:\n> type: bool","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69836603FC\n\tfor ;\n\tFri, 24 Apr 2020 12:54:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE72F4F7;\n\tFri, 24 Apr 2020 12:54:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"b0gU4FY0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587725698;\n\tbh=B1MhYP0Ugx0G9sFTKO8Mk6QAC0iRjDcS+v5iJxkasDE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=b0gU4FY0awvTz3t7m10rWIG4CndJ9NbZK+/PIE2ZvAwVLx+mrfnkm1DsOYh1MjOSF\n\tvyRganx+Z946QsWv3/EGN1N/KVs4kdFf1rtTMNGzbeu07IkORLIzdfGm6ejcKMYCK1\n\tCwh5U/K1aH2Baa/P3rpgvPydECgIbj0SpnNGBGYI=","Date":"Fri, 24 Apr 2020 13:54:43 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200424105443.GC5954@pendragon.ideasonboard.com>","References":"<20200424104700.26819-1-naush@raspberrypi.com>\n\t<20200424104700.26819-2-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200424104700.26819-2-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v4 1/5] libcamera: control_ids: Add\n\tcomment to specify control direction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 24 Apr 2020 10:54:58 -0000"}}]