{"id":3513,"url":"https://patchwork.libcamera.org/api/patches/3513/?format=json","web_url":"https://patchwork.libcamera.org/patch/3513/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200424104700.26819-2-naush@raspberrypi.com>","date":"2020-04-24T10:46:56","name":"[libcamera-devel,v4,1/5] libcamera: control_ids: Add comment to specify control direction","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"05e096638d4574ebe31f32fbdfcbbc47dd2a5ffc","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3513/mbox/","series":[{"id":821,"url":"https://patchwork.libcamera.org/api/series/821/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=821","date":"2020-04-24T10:46:55","name":"Patchset for libcamera controls","version":4,"mbox":"https://patchwork.libcamera.org/series/821/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3513/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3513/checks/","tags":{},"headers":{"Return-Path":"","Received":["from mail-wm1-x341.google.com (mail-wm1-x341.google.com\n\t[IPv6:2a00:1450:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A8DCC603FC\n\tfor ;\n\tFri, 24 Apr 2020 12:47:12 +0200 (CEST)","by mail-wm1-x341.google.com with SMTP id r26so10191640wmh.0\n\tfor ;\n\tFri, 24 Apr 2020 03:47:12 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tj68sm7884997wrj.32.2020.04.24.03.47.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Apr 2020 03:47:11 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"gUW1dhSN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=7AEGnA5S/d2+iT60qv7PR5d/7S8hOxh1bBRKMqWNlLs=;\n\tb=gUW1dhSNbCTQkNf3utkg6KnA2qcggRuMvpaetCZSdYTpRWYqiWc/OELsD3VnmYroUx\n\tKXAPe2A9JsafPS57Ct7+GCnI9iC/vBl5DJU0sA392NfxIpoxsGWk3JuK98Ee4/jvGUb0\n\tBOFHzfFX286WVEkAfUj/kY/B8cmYy7sYEpvnbsFZSZnn0w0tvfx5T94f0kkPkOcgSspQ\n\t31krKcr2IhR1t2MGu97ZHtWlym695w1uOgQVH/W5U/5cTuUgXB11KkbVRGsEbjV2XuE3\n\toR09pe+JDlnGTxRa7sUQ0I+1SV2GbMyXaZuSLc1gx3NeFYnOHmQBeJ8vKZaUConagJ5H\n\tXsXA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=7AEGnA5S/d2+iT60qv7PR5d/7S8hOxh1bBRKMqWNlLs=;\n\tb=F3b6tBGc3vy/md+lMaf1KZC4SNznosjDpLrYqNUbW/Pjcm24wJYdSDZd1CCn66SQ/V\n\t8t/DsALYZGGYP6N7QaHHoOPTpoHZatyYksavjn+yUss6myjYy+lsc2MxcW2jrkpmkw21\n\t7Nl3BD6Q8BNZpT8GWZViXPf/MPOVHfjX5tYlrPI9xzJA0mJgZwaEXYZ24tD1N5PRPsrp\n\tdLsp1UWLwr6kfsIavBpmK+mYOY9umZGJy2DtWzzCWz/lzBu0s8fm/ZNA7gAIGp3PIqCC\n\tEh48n6f5XzERibOgOysQgOjLVHWeKhopbtQPq3k4JpNz/bhqzGce7jCpC/v55XtegKgt\n\tJdPQ==","X-Gm-Message-State":"AGi0Pubm/nXe7MjyHgQu1XFF94r9tNlNa3MTrOtnBgFshq79d17j19aO\n\t2VSXZaR11W0lzg8uPexRtN6DplK1X8DHvg==","X-Google-Smtp-Source":"APiQypLpqUgtqiUtV1oyhEXNX7mVeg+bWxVuMNST9zt3QuLtN7HOdsEAv2X2d9zciHoTGSOxfuQXcw==","X-Received":"by 2002:a1c:68d7:: with SMTP id\n\td206mr8876317wmc.29.1587725232128; \n\tFri, 24 Apr 2020 03:47:12 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 24 Apr 2020 11:46:56 +0100","Message-Id":"<20200424104700.26819-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20200424104700.26819-1-naush@raspberrypi.com>","References":"<20200424104700.26819-1-naush@raspberrypi.com>","Subject":"[libcamera-devel] [PATCH v4 1/5] libcamera: control_ids: Add\n\tcomment to specify control direction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 24 Apr 2020 10:47:12 -0000"},"content":"Document that controls are bi-directional by default. If a control\nis only returned in metadata, this must be specified in the control's\ndescription.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/control_ids.cpp.in | 3 +++\n src/libcamera/control_ids.yaml | 2 ++\n 2 files changed, 5 insertions(+)","diff":"diff --git a/src/libcamera/control_ids.cpp.in b/src/libcamera/control_ids.cpp.in\nindex 99c511d0..cba6258d 100644\n--- a/src/libcamera/control_ids.cpp.in\n+++ b/src/libcamera/control_ids.cpp.in\n@@ -33,6 +33,9 @@ ${controls_def}\n \n /**\n * \\brief List of all supported libcamera controls\n+ *\n+ * Unless otherwise stated, all controls are bi-directional, i.e. they can be\n+ * set through Request::controls() and returned out through Request::metadata().\n */\n extern const ControlIdMap controls {\n ${controls_map}\ndiff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 4befec74..bcbab195 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -4,6 +4,8 @@\n #\n %YAML 1.2\n ---\n+# Unless otherwise stated, all controls are bi-directional, i.e. they can be\n+# set through Request::controls() and returned out through Request::metadata().\n controls:\n - AeEnable:\n type: bool\n","prefixes":["libcamera-devel","v4","1/5"]}