[{"id":535,"web_url":"https://patchwork.libcamera.org/comment/535/","msgid":"<20190123144042.GP4127@bigcity.dyn.berto.se>","date":"2019-01-23T14:40:42","subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Fix two typos.","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2019-01-23 14:24:45 +0000, Kieran Bingham wrote:\n> Two incorrect spellings are fixed.\n> 'logr' -> 'log'\n> 'environement' -> 'environment'\n> \n> Fixes: 747ace042cc1 (\"libcamera: log: Get log levels from the environment\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/log.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index 241dc5395976..dc88414c338a 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -134,7 +134,7 @@ void Logger::parseLogFile()\n> /**\n> * \\brief Parse the log levels from the environment\n> *\n> - * The logr levels are stored in LIBCAMERA_LOG_LEVELS environement variable as a list\n> + * The log levels are stored in LIBCAMERA_LOG_LEVELS environment variable as a list\n> * of \"category=level\" pairs, separated by commas (','). Parse the variable and\n> * store the levels to configure all log categories.\n> */\n> -- \n> 2.19.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51D6960B2D\n\tfor ;\n\tWed, 23 Jan 2019 15:40:44 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id q2-v6so2129507lji.10\n\tfor ;\n\tWed, 23 Jan 2019 06:40:44 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\ta18-v6sm527681ljk.86.2019.01.23.06.40.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 23 Jan 2019 06:40:42 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=27HNJ7RlBXBialtebSBTQe2BBuUkpN3pmiVJkJSzfBY=;\n\tb=U/Q25pFBI/RHrDCpNJABWdB0E6VnQE4/BR+r0KpjCi0SsDd+Q8YB4rrhQxhINLgI5U\n\tMkAlEffcT6bKSEkY5Qp3hUQoPFwvU4F/chack6as4kvHyY+OMANSlA8r4Ko5dHLJafKm\n\teiX1ytXjS6lpfZbuNecaRuJ9FxDlQwpgGFlK7F43c7Vu3f7fAkjyiPwe2s5krsyaSh9V\n\tpJ4rL+Tu9uWNUkvTsCyrnaP1iv7QYz7oxxSS8njS7HGh1ZClLijggif6fzljr/aq2eOP\n\tVVE+q7y2Y9xMd9BmXA3BcZHsmMfQiMjdHOPK+SJkpcqUmQAKTr+ctiN7kmhcOG1GREWc\n\t+mdw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=27HNJ7RlBXBialtebSBTQe2BBuUkpN3pmiVJkJSzfBY=;\n\tb=iYHGZxQ0GjCyFjLRYINUWA7qE83PX2kSSlgTvDi7+vVHcDXxCgK0wWNnXXx+H0lRZ5\n\tt2GOHnpWPAMjdoxR5eRG5R9I/7QvBDIuxk++AXpcSq+nTOwRRJqiF66QS9WE44ylEizO\n\tmeJwHEA5VkOMepyWq0xEdeTj56x6TKFU0ZL/XvZEjTa9F7qDHL7dWzQ8ewBHoMzCvSHo\n\ts14JBxD0obJutaCCJVGBBZ1ZxxMXC70ZOfr1zIctYqsmgTwuDkYMHXTU5mqD3OADkYrv\n\tjWPwMa156CkceG1hyqq8GoUXBE2/tPsb1OpukJDe4fUUpedj6BDqR/MTdfAYIOa9XGBZ\n\tNCNg==","X-Gm-Message-State":"AJcUukcZmv7YjFMo/87vUZLFuuT2vnELhvRSAvbNrr9SVBRRJiPEcam0\n\tJA7QUOjc0AqadGVTj5t5mOvCEGgSwK0=","X-Google-Smtp-Source":"ALg8bN5odCHAnT0RfGt9NLYWfQTM5LFwUornLJg/O+nIQak2eymHNTvZERylfk7Kkv3Doqh7Ci5LaA==","X-Received":"by 2002:a2e:86ca:: with SMTP id\n\tn10-v6mr1984474ljj.49.1548254443584; \n\tWed, 23 Jan 2019 06:40:43 -0800 (PST)","Date":"Wed, 23 Jan 2019 15:40:42 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190123144042.GP4127@bigcity.dyn.berto.se>","References":"<20190123142445.29416-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190123142445.29416-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Fix two typos.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 23 Jan 2019 14:40:44 -0000"}},{"id":537,"web_url":"https://patchwork.libcamera.org/comment/537/","msgid":"<20190123154052.GA31885@pendragon.ideasonboard.com>","date":"2019-01-23T15:40:52","subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Fix two typos.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch..\n\nOn Wed, Jan 23, 2019 at 02:24:45PM +0000, Kieran Bingham wrote:\n> Two incorrect spellings are fixed.\n> 'logr' -> 'log'\n> 'environement' -> 'environment'\n> \n> Fixes: 747ace042cc1 (\"libcamera: log: Get log levels from the environment\")\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/log.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index 241dc5395976..dc88414c338a 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -134,7 +134,7 @@ void Logger::parseLogFile()\n> /**\n> * \\brief Parse the log levels from the environment\n> *\n> - * The logr levels are stored in LIBCAMERA_LOG_LEVELS environement variable as a list\n> + * The log levels are stored in LIBCAMERA_LOG_LEVELS environment variable as a list\n\nWhile at it, s/in /in the /.\n\nReviewed-by: Laurent Pinchart \n\nI'll push it.\n\n> * of \"category=level\" pairs, separated by commas (','). Parse the variable and\n> * store the levels to configure all log categories.\n> */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4F1160B2D\n\tfor ;\n\tWed, 23 Jan 2019 16:40:53 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0AD6D23D;\n\tWed, 23 Jan 2019 16:40:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548258053;\n\tbh=jX1U0jWj5wRv0aaA3t9m7HKtjLrvr3nts3xx/9TlByU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vJ2GdMkf2DndMGCItTlcNGOC8IjjG9INYyvxComvQxFeuRL8iOqzS7PpvCWsjzPZP\n\ttXSLeKxlzJqz2ZMXlTgVVge8Hts0+WoUQUV3fzxADx/2Jpp2yp1yS/wjGTYYKNxUVo\n\tmBGBnJjUIaZ23UQyeVsCCsHHHmgn59E0T9RHOaRM=","Date":"Wed, 23 Jan 2019 17:40:52 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190123154052.GA31885@pendragon.ideasonboard.com>","References":"<20190123142445.29416-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190123142445.29416-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Fix two typos.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 23 Jan 2019 15:40:53 -0000"}}]