[{"id":4470,"web_url":"https://patchwork.libcamera.org/comment/4470/","msgid":"<7PG29Q.RR8PD9L2599O3@uajain.com>","date":"2020-04-20T03:08:03","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator_udev:\n\tLog the right number of missing deps","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Laurent,\nOn Mon, Apr 20, 2020 at 00:33, Laurent Pinchart \n wrote:\n> Since commit e75ef59e028e (\"libcamera: device_enumerator_udev: Update\n> pending list in addUdevDevice\") the populateMediaDevice() function\n> returns 0 on success instead of the number of missing dependencies,\n> resulting in a wrong number being logged. Fix it.\n> \n> Fixes: e75ef59e028e (\"libcamera: device_enumerator_udev: Update \n> pending list in addUdevDevice\")\n> Signed-off-by: Laurent Pinchart >\n> ---\n> src/libcamera/device_enumerator_udev.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/device_enumerator_udev.cpp \n> b/src/libcamera/device_enumerator_udev.cpp\n> index 9cbc7e47d2d9..2e33c898aeef 100644\n> --- a/src/libcamera/device_enumerator_udev.cpp\n> +++ b/src/libcamera/device_enumerator_udev.cpp\n> @@ -94,7 +94,8 @@ int DeviceEnumeratorUdev::addUdevDevice(struct \n> udev_device *dev)\n> \t\tif (!deps.empty()) {\n> \t\t\tLOG(DeviceEnumerator, Debug)\n> \t\t\t\t<< \"Defer media device \" << media->deviceNode()\n> -\t\t\t\t<< \" due to \" << ret << \" missing dependencies\";\n> +\t\t\t\t<< \" due to \" << deps.size()\n> +\t\t\t\t<< \" missing dependencies\";\n> \n> \t\t\tpending_.emplace_back(std::move(media), std::move(deps));\n> \t\t\tMediaDeviceDeps *mediaDeps = &pending_.back();\n\nLGTM.\n\nReviewed-by: Umang Jain \n\n> --\n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5051F603FD\n\tfor ;\n\tMon, 20 Apr 2020 05:08:05 +0200 (CEST)","by filterdrecv-p3mdw1-6dbfd75bfd-rd7m8 with SMTP id\n\tfilterdrecv-p3mdw1-6dbfd75bfd-rd7m8-20-5E9D1213-1E\n\t2020-04-20 03:08:03.616696979 +0000 UTC m=+2167244.129207296","from mail.uajain.com (unknown)\n\tby ismtpd0004p1maa1.sendgrid.net (SG) with ESMTP\n\tid NiLiMmB0TXiJv1gX_vSAZw Mon, 20 Apr 2020 03:08:03.208 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"GATvdzmE\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:in-reply-to:references:mime-version:to:cc:content-type;\n\ts=s1; bh=g/OZwTPWNnt2MET4L+rvtuiFONgk8Ts6TKL7ykT5mYc=;\n\tb=GATvdzmENQvwWM38fIunR40j4P7DWJJPsouT4lRwu5f7aKKyURQ6nc9Al96VzYSRAVxu\n\talDlQuHBTRjgVj/KPjnzFPwJq++U7IoJrHDSRac/2il8ygT+H3qLavvemSHo/u31YUT+Tu\n\tFFWo1l8rIeSXytqsITAbvzXmeLotZc07A=","Date":"Mon, 20 Apr 2020 03:08:03 +0000 (UTC)","From":"Umang Jain ","Message-Id":"<7PG29Q.RR8PD9L2599O3@uajain.com>","In-Reply-To":"<20200419213341.18925-1-laurent.pinchart@ideasonboard.com>","References":"<20200419213341.18925-1-laurent.pinchart@ideasonboard.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcHIuSzkf5/M5SksOT1pntGy75a1FmH1ukNxe+2sANt4r+DL49v5mZxQGtd1kOkhBq+9L/FiX1BpHCMK0eH3ThYWkiIT6RL+9MKS0keQLJ8J2hetN1GAf6so3qRlprt/wF2NLLDRVCgu81cEZmUsOeOnBwkRHj/FRH/a+iePNbfukHf4qkVJWKzPmMvb+YwMecF4nof11lOD4+GhZ1uRkirg==","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"=-skbMmxx08Vd0iwKuCl8U\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator_udev:\n\tLog the right number of missing deps","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 20 Apr 2020 03:08:06 -0000"}}]