{"id":3485,"url":"https://patchwork.libcamera.org/api/patches/3485/?format=json","web_url":"https://patchwork.libcamera.org/patch/3485/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200417124110.72313-12-jacopo@jmondi.org>","date":"2020-04-17T12:41:10","name":"[libcamera-devel,v9,11/11] media: i2c: ov13858: Parse and register properties","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"44cd1a69698e5f6d8e0fbe1af89e79ff149d0f78","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/3485/mbox/","series":[{"id":815,"url":"https://patchwork.libcamera.org/api/series/815/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=815","date":"2020-04-17T12:40:59","name":"media: report camera sensor properties","version":9,"mbox":"https://patchwork.libcamera.org/series/815/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3485/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3485/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93F2360402\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Apr 2020 14:38:59 +0200 (CEST)","from uno.homenet.telecomitalia.it (unknown [87.13.136.104])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 3C64560009;\n\tFri, 17 Apr 2020 12:38:51 +0000 (UTC)"],"X-Originating-IP":"87.13.136.104","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Mauro Carvalho Chehab <mchehab@kernel.org>,\n\tHans Verkuil <hverkuil-cisco@xs4all.nl>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>, tfiga@google.com,\n\tpavel@ucw.cz","Cc":"Jacopo Mondi <jacopo@jmondi.org>,\n\tlinux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE\n\t(V4L/DVB)), libcamera-devel@lists.libcamera.org","Date":"Fri, 17 Apr 2020 14:41:10 +0200","Message-Id":"<20200417124110.72313-12-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.26.1","In-Reply-To":"<20200417124110.72313-1-jacopo@jmondi.org>","References":"<20200417124110.72313-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v9 11/11] media: i2c: ov13858: Parse and\n\tregister properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 17 Apr 2020 12:38:59 -0000"},"content":"Parse device properties and register controls for them using the newly\nintroduced helpers.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n drivers/media/i2c/ov13858.c | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c\nindex aac6f77afa0f..2ef5fb5cf519 100644\n--- a/drivers/media/i2c/ov13858.c\n+++ b/drivers/media/i2c/ov13858.c\n@@ -7,6 +7,7 @@\n #include <linux/pm_runtime.h>\n #include <media/v4l2-ctrls.h>\n #include <media/v4l2-device.h>\n+#include <media/v4l2-fwnode.h>\n \n #define OV13858_REG_VALUE_08BIT\t\t1\n #define OV13858_REG_VALUE_16BIT\t\t2\n@@ -1589,6 +1590,7 @@ static const struct v4l2_subdev_internal_ops ov13858_internal_ops = {\n static int ov13858_init_controls(struct ov13858 *ov13858)\n {\n \tstruct i2c_client *client = v4l2_get_subdevdata(&ov13858->sd);\n+\tstruct v4l2_fwnode_device_properties props;\n \tstruct v4l2_ctrl_handler *ctrl_hdlr;\n \ts64 exposure_max;\n \ts64 vblank_def;\n@@ -1666,6 +1668,15 @@ static int ov13858_init_controls(struct ov13858 *ov13858)\n \t\tgoto error;\n \t}\n \n+\tret = v4l2_fwnode_device_parse(&client->dev, &props);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tret = v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &ov13858_ctrl_ops,\n+\t\t\t\t\t      &props);\n+\tif (ret)\n+\t\treturn ret;\n+\n \tov13858->sd.ctrl_handler = ctrl_hdlr;\n \n \treturn 0;\n","prefixes":["libcamera-devel","v9","11/11"]}