[{"id":524,"web_url":"https://patchwork.libcamera.org/comment/524/","msgid":"<23fbf25b-4a03-8356-921b-e67ff67b4575@ideasonboard.com>","date":"2019-01-23T11:50:57","subject":"Re: [libcamera-devel] [PATCH 4/4] tests: event-dispatcher: Add\n\tprocessEvents() interruption test","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/01/2019 08:59, Laurent Pinchart wrote:\n> Test that the EventDispatcher::interrupt() function correctly interrupts\n> the processEvents() function, both when called before processEvents()\n> and when called while it is running.\n> \n\nLGTM\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n\nWhile testing this, it occurs to me - is there any way we can call into\nthe Logger instance from an application (or specifically a *test*\napplication) to raise the default log level to DEBUG?\n\nIt's about the only time where I'd want LIBCAMERA_LOG_LEVELS=*:DEBUG by\ndefault.\n\nI tried adding a call to putenv(\"LIBCAMERA_LOG_LEVELS=*:DEBUG\"); in\nTest::init(); but of course this only gets executed after the static\nLogger->instance() is already created.\n\n\nI wonder if we might expose a static method on the internal Logger()\ninstance so that we can call\n\n libcamera::Logger::SetLogLevel(Debug);\n\nOnly an idea... and not directly related to this patch, so don't put too\nmuch thought into it just yet.\n\n--\nKieran\n\n\n> ---\n> test/event-dispatcher.cpp | 32 +++++++++++++++++++++++++++++++-\n> 1 file changed, 31 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/event-dispatcher.cpp b/test/event-dispatcher.cpp\n> index 06c2657f09d6..e8818dcab4ad 100644\n> --- a/test/event-dispatcher.cpp\n> +++ b/test/event-dispatcher.cpp\n> @@ -18,16 +18,23 @@\n> using namespace std;\n> using namespace libcamera;\n> \n> +static EventDispatcher *dispatcher;\n> +static bool interrupt;\n> +\n> class EventDispatcherTest : public Test\n> {\n> protected:\n> \tstatic void sigAlarmHandler(int)\n> \t{\n> \t\tcout << \"SIGALARM received\" << endl;\n> +\t\tif (interrupt)\n> +\t\t\tdispatcher->interrupt();\n> \t}\n> \n> \tint init()\n> \t{\n> +\t\tdispatcher = CameraManager::instance()->eventDispatcher();\n> +\n> \t\tstruct sigaction sa = {};\n> \t\tsa.sa_handler = &sigAlarmHandler;\n> \t\tsigaction(SIGALRM, &sa, nullptr);\n> @@ -37,7 +44,6 @@ protected:\n> \n> \tint run()\n> \t{\n> -\t\tEventDispatcher *dispatcher = CameraManager::instance()->eventDispatcher();\n> \t\tTimer timer;\n> \n> \t\t/* Event processing interruption by signal. */\n> @@ -48,6 +54,7 @@ protected:\n> \n> \t\tstruct itimerval itimer = {};\n> \t\titimer.it_value.tv_usec = 500000;\n> +\t\tinterrupt = false;\n> \t\tsetitimer(ITIMER_REAL, &itimer, nullptr);\n> \n> \t\tdispatcher->processEvents();\n> @@ -62,6 +69,29 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\t/* Event processing interruption. */\n> +\t\ttimer.start(1000);\n> +\t\tdispatcher->interrupt();\n> +\n> +\t\tdispatcher->processEvents();\n> +\n> +\t\tif (!timer.isRunning()) {\n> +\t\t\tcout << \"Event processing immediate interruption failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ttimer.start(1000);\n> +\t\titimer.it_value.tv_usec = 500000;\n> +\t\tinterrupt = true;\n> +\t\tsetitimer(ITIMER_REAL, &itimer, nullptr);\n> +\n> +\t\tdispatcher->processEvents();\n> +\n> +\t\tif (!timer.isRunning()) {\n> +\t\t\tcout << \"Event processing delayed interruption failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\treturn TestPass;\n> \t}\n> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AADB60C7D\n\tfor ;\n\tWed, 23 Jan 2019 12:51:00 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E6CB223D;\n\tWed, 23 Jan 2019 12:50:59 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548244260;\n\tbh=AKIIu6NDhCwEW4AK/JDqpK5zKWq7uXItFCxZOgojC3g=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=wB319I9r6ujulXFZd1yy+d93Pg8uv0scY2Mv6fMARQvM7Qu0/c2RgkmfuFp2gKcw5\n\tCC5zctGLeWATuG13UyETSowmAxXfykWrvHZm1bSQqUtMPQXdaztImZBFexjyoy409O\n\taVleHpMUUHwNGALa6uHpplR00kLizJlFPUdH63pY=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190123085923.12524-1-laurent.pinchart@ideasonboard.com>\n\t<20190123085923.12524-5-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<23fbf25b-4a03-8356-921b-e67ff67b4575@ideasonboard.com>","Date":"Wed, 23 Jan 2019 11:50:57 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190123085923.12524-5-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 4/4] tests: event-dispatcher: Add\n\tprocessEvents() interruption test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 23 Jan 2019 11:51:00 -0000"}},{"id":546,"web_url":"https://patchwork.libcamera.org/comment/546/","msgid":"<20190123165102.GJ31885@pendragon.ideasonboard.com>","date":"2019-01-23T16:51:02","subject":"Re: [libcamera-devel] [PATCH 4/4] tests: event-dispatcher: Add\n\tprocessEvents() interruption test","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Jan 23, 2019 at 11:50:57AM +0000, Kieran Bingham wrote:\n> On 23/01/2019 08:59, Laurent Pinchart wrote:\n> > Test that the EventDispatcher::interrupt() function correctly interrupts\n> > the processEvents() function, both when called before processEvents()\n> > and when called while it is running.\n> > \n> \n> LGTM\n> \n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> \n> While testing this, it occurs to me - is there any way we can call into\n> the Logger instance from an application (or specifically a *test*\n> application) to raise the default log level to DEBUG?\n> \n> It's about the only time where I'd want LIBCAMERA_LOG_LEVELS=*:DEBUG by\n> default.\n> \n> I tried adding a call to putenv(\"LIBCAMERA_LOG_LEVELS=*:DEBUG\"); in\n> Test::init(); but of course this only gets executed after the static\n> Logger->instance() is already created.\n> \n> \n> I wonder if we might expose a static method on the internal Logger()\n> instance so that we can call\n> \n> libcamera::Logger::SetLogLevel(Debug);\n> \n> Only an idea... and not directly related to this patch, so don't put too\n> much thought into it just yet.\n\nI think should would make sense, possibly even exposed by the\nCameraManager class as non-test applications could have a use for this.\nPatches are welcome :-) We need to think about the API though, as we may\nwant to enable per-category log level control (that doesn't have to be\nincluded in the code, but needs to be considered to design the API).\n\n> > ---\n> > test/event-dispatcher.cpp | 32 +++++++++++++++++++++++++++++++-\n> > 1 file changed, 31 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/test/event-dispatcher.cpp b/test/event-dispatcher.cpp\n> > index 06c2657f09d6..e8818dcab4ad 100644\n> > --- a/test/event-dispatcher.cpp\n> > +++ b/test/event-dispatcher.cpp\n> > @@ -18,16 +18,23 @@\n> > using namespace std;\n> > using namespace libcamera;\n> > \n> > +static EventDispatcher *dispatcher;\n> > +static bool interrupt;\n> > +\n> > class EventDispatcherTest : public Test\n> > {\n> > protected:\n> > \tstatic void sigAlarmHandler(int)\n> > \t{\n> > \t\tcout << \"SIGALARM received\" << endl;\n> > +\t\tif (interrupt)\n> > +\t\t\tdispatcher->interrupt();\n> > \t}\n> > \n> > \tint init()\n> > \t{\n> > +\t\tdispatcher = CameraManager::instance()->eventDispatcher();\n> > +\n> > \t\tstruct sigaction sa = {};\n> > \t\tsa.sa_handler = &sigAlarmHandler;\n> > \t\tsigaction(SIGALRM, &sa, nullptr);\n> > @@ -37,7 +44,6 @@ protected:\n> > \n> > \tint run()\n> > \t{\n> > -\t\tEventDispatcher *dispatcher = CameraManager::instance()->eventDispatcher();\n> > \t\tTimer timer;\n> > \n> > \t\t/* Event processing interruption by signal. */\n> > @@ -48,6 +54,7 @@ protected:\n> > \n> > \t\tstruct itimerval itimer = {};\n> > \t\titimer.it_value.tv_usec = 500000;\n> > +\t\tinterrupt = false;\n> > \t\tsetitimer(ITIMER_REAL, &itimer, nullptr);\n> > \n> > \t\tdispatcher->processEvents();\n> > @@ -62,6 +69,29 @@ protected:\n> > \t\t\treturn TestFail;\n> > \t\t}\n> > \n> > +\t\t/* Event processing interruption. */\n> > +\t\ttimer.start(1000);\n> > +\t\tdispatcher->interrupt();\n> > +\n> > +\t\tdispatcher->processEvents();\n> > +\n> > +\t\tif (!timer.isRunning()) {\n> > +\t\t\tcout << \"Event processing immediate interruption failed\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\ttimer.start(1000);\n> > +\t\titimer.it_value.tv_usec = 500000;\n> > +\t\tinterrupt = true;\n> > +\t\tsetitimer(ITIMER_REAL, &itimer, nullptr);\n> > +\n> > +\t\tdispatcher->processEvents();\n> > +\n> > +\t\tif (!timer.isRunning()) {\n> > +\t\t\tcout << \"Event processing delayed interruption failed\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > \t\treturn TestPass;\n> > \t}\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FD7760B2D\n\tfor ;\n\tWed, 23 Jan 2019 17:51:04 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72D7323D;\n\tWed, 23 Jan 2019 17:51:03 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548262263;\n\tbh=HHFStFGtY3dREGR0o23zzHuJS6C+/EvcgcFs5KFUoks=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ouE9yBmuMYPbNMid8I/p2ZbuXIRHe34AUh3A7mpTCbaOUvX0jiaWWT+TvYP2dMLDh\n\tdbIUpoz84w/W18bln63j5+vPou2IxIipHtfZCbeqJv129OBBgU3w632omVOaUbYK1c\n\t8OhqiZcFTRBd4250JhLPWiZerjAX5vEbiY847rCI=","Date":"Wed, 23 Jan 2019 18:51:02 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190123165102.GJ31885@pendragon.ideasonboard.com>","References":"<20190123085923.12524-1-laurent.pinchart@ideasonboard.com>\n\t<20190123085923.12524-5-laurent.pinchart@ideasonboard.com>\n\t<23fbf25b-4a03-8356-921b-e67ff67b4575@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<23fbf25b-4a03-8356-921b-e67ff67b4575@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/4] tests: event-dispatcher: Add\n\tprocessEvents() interruption test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 23 Jan 2019 16:51:04 -0000"}}]