[{"id":4461,"web_url":"https://patchwork.libcamera.org/comment/4461/","msgid":"<20200417000757.GB1262816@oden.dyn.berto.se>","date":"2020-04-17T00:07:57","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Return\n\tcorrect format for metadata","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-04-17 01:05:58 +0300, Laurent Pinchart wrote:\n> When setting format on a metadata video device, the returned format\n> isn't updated with the actual set format due to a typo. Fix it.\n> \n> Fixes: 629e9301c518 (\"libcamera: v4l2_device: Add META support in g/s_fmt\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 439a9c90dbf7..a959cfe65c43 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -848,7 +848,7 @@ int V4L2VideoDevice::setFormatMeta(V4L2DeviceFormat *format)\n> \t */\n> \tformat->size.width = 0;\n> \tformat->size.height = 0;\n> -\tformat->fourcc = format->fourcc;\n> +\tformat->fourcc = V4L2PixelFormat(pix->dataformat);\n> \tformat->planesCount = 1;\n> \tformat->planes[0].bpl = pix->buffersize;\n> \tformat->planes[0].size = pix->buffersize;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BEA760406\n\tfor ;\n\tFri, 17 Apr 2020 02:07:59 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id x23so289738lfq.1\n\tfor ;\n\tThu, 16 Apr 2020 17:07:59 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t83sm16831358lfn.30.2020.04.16.17.07.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 16 Apr 2020 17:07:57 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com header.b=\"LZdXhYKf\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=EMcO/+zJlRBmGUcm4/pzAt9Z6WYQIvzVsgXbOVbyW0U=;\n\tb=LZdXhYKfz0s8AlWukjpxKmlgct+0u2bpwrQqrt//I05fpCFWAj7FmXhBm0zBfoWRTC\n\tOKuK133EPH8TBl3fVFsYpetpM1B/KYzgOPK31dmrAzc/pmxeR+FH8eTx6NqEs3TzsHSu\n\tT7SYAuoE04X9V7eJ7xjd8H87CGATHXDoRNziEkfg8B3GdXG+kNrRV6BTo/Rj1lpcb1iP\n\tBxgcH1FfiE2CsD24EdfZdU2dgM2wcvPEvz8FNplb91VVYHXmE55TdYWZqwkN3GWabbQ0\n\tAPWQ+3kWCuUP6v9XeURss11rIcY2RBf047sujgQXjI3VwwO2QRkBvDCaDSaoOz61wK9H\n\tTcYw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=EMcO/+zJlRBmGUcm4/pzAt9Z6WYQIvzVsgXbOVbyW0U=;\n\tb=Yf7m/jepqbYSwQsdAp3V8EGnWnmxbmzGg5Um93RIvdtJkO+4W8KfHqqpNiL/XEzbgJ\n\tIIVnYGSO+9P8m7p/HsMmhyr7LJAL6B0cnsVlgb7k65ekqLXfHbA+0AfubayspJCSI9+6\n\tIjZfcIrR5xsxjNerFiUYzY4srgbtJoQ7OaH5pIyrFBJugThEi46aRjq676mbz/qZRWDZ\n\t4dt1yGzEm+/oPg1TEIyd0n+FkIZWI8wzPz2R8D/X3iK97dzc/9FbV7Ite0k6S0TSqJA+\n\toX0bj+TrxSwkscCJtaZUmrk8J3X17kUAcEeiUUTMd04t45u9FPvGaelnCqN3McrpEUtg\n\tRuVA==","X-Gm-Message-State":"AGi0PuYeVV31urEQa+R3ioRTL89ptR4oB90gVBroVkVR4W/8a38cL2cx\n\twk1umxi83RAbIoZK/jMBwuBBuw==","X-Google-Smtp-Source":"APiQypL8go6iA10YwrdVaXQg0cfdstI8aGG1jsTINt23V1ocfIrCTQrGCkt3vc7xjF5se1lBAiguxw==","X-Received":"by 2002:ac2:5684:: with SMTP id 4mr247284lfr.88.1587082078440;\n\tThu, 16 Apr 2020 17:07:58 -0700 (PDT)","Date":"Fri, 17 Apr 2020 02:07:57 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200417000757.GB1262816@oden.dyn.berto.se>","References":"<20200416220558.32136-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200416220558.32136-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Return\n\tcorrect format for metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Apr 2020 00:08:00 -0000"}},{"id":4462,"web_url":"https://patchwork.libcamera.org/comment/4462/","msgid":"<54c9aa91-ecb8-a288-98b9-4324781d1eac@ideasonboard.com>","date":"2020-04-17T08:31:34","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Return\n\tcorrect format for metadata","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 16/04/2020 23:05, Laurent Pinchart wrote:\n> When setting format on a metadata video device, the returned format\n> isn't updated with the actual set format due to a typo. Fix it.\n\nDid you hit this? Or identify it from the coverity scan?\n\nThis is Coverity ID: 279098, if it's worth adding that to the commit\nmessage.\n\n> Fixes: 629e9301c518 (\"libcamera: v4l2_device: Add META support in g/s_fmt\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 439a9c90dbf7..a959cfe65c43 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -848,7 +848,7 @@ int V4L2VideoDevice::setFormatMeta(V4L2DeviceFormat *format)\n> \t */\n> \tformat->size.width = 0;\n> \tformat->size.height = 0;\n> -\tformat->fourcc = format->fourcc;\n> +\tformat->fourcc = V4L2PixelFormat(pix->dataformat);\n> \tformat->planesCount = 1;\n> \tformat->planes[0].bpl = pix->buffersize;\n> \tformat->planes[0].size = pix->buffersize;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5686360401\n\tfor ;\n\tFri, 17 Apr 2020 10:31:38 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BBE8B97D;\n\tFri, 17 Apr 2020 10:31:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PfrHS6LY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587112297;\n\tbh=ARGSH9EGGESBCv94L9qVwcwRZlnAatkLDPCfUQZ9Fyc=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=PfrHS6LYJebA9t44zQsYS2ONxSsfQTdMtr8VTYuESR00Oy9qpMp0fir5KEcXFu2YH\n\tgAtzowSMeyrRHo1Guoc2qfL1nz2s5rhlq81jc8g+fhPa/6WRb5C+fa6N8yZfDITj/s\n\tkiYW51DNQ7R9g9DKO/nqrL0zZxyGJZbGYDd0vha4=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200416220558.32136-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<54c9aa91-ecb8-a288-98b9-4324781d1eac@ideasonboard.com>","Date":"Fri, 17 Apr 2020 09:31:34 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200416220558.32136-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Return\n\tcorrect format for metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Apr 2020 08:31:38 -0000"}},{"id":4463,"web_url":"https://patchwork.libcamera.org/comment/4463/","msgid":"<20200417111322.GA4748@pendragon.ideasonboard.com>","date":"2020-04-17T11:13:22","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Return\n\tcorrect format for metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Apr 17, 2020 at 09:31:34AM +0100, Kieran Bingham wrote:\n> On 16/04/2020 23:05, Laurent Pinchart wrote:\n> > When setting format on a metadata video device, the returned format\n> > isn't updated with the actual set format due to a typo. Fix it.\n> \n> Did you hit this? Or identify it from the coverity scan?\n> \n> This is Coverity ID: 279098, if it's worth adding that to the commit\n> message.\n\nWhat would you think of using a Reported-by tag for this ?\n\nReported-by: Coverity DefectId=279098\nReported-by: Coverity CID=279098\nReported-by: Coverity Scan CID=279098\n\nAny preference ? CID is used in the e-mail reports, no idea what the web\nUI uses as it still refuses to show me any data :-)\n\n> > Fixes: 629e9301c518 (\"libcamera: v4l2_device: Add META support in g/s_fmt\")\n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/libcamera/v4l2_videodevice.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> > index 439a9c90dbf7..a959cfe65c43 100644\n> > --- a/src/libcamera/v4l2_videodevice.cpp\n> > +++ b/src/libcamera/v4l2_videodevice.cpp\n> > @@ -848,7 +848,7 @@ int V4L2VideoDevice::setFormatMeta(V4L2DeviceFormat *format)\n> > \t */\n> > \tformat->size.width = 0;\n> > \tformat->size.height = 0;\n> > -\tformat->fourcc = format->fourcc;\n> > +\tformat->fourcc = V4L2PixelFormat(pix->dataformat);\n> > \tformat->planesCount = 1;\n> > \tformat->planes[0].bpl = pix->buffersize;\n> > \tformat->planes[0].size = pix->buffersize;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DAADC60402\n\tfor ;\n\tFri, 17 Apr 2020 13:13:35 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 462E197D;\n\tFri, 17 Apr 2020 13:13:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wLMzD98W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587122015;\n\tbh=o888JMFqLpRhqbdxGouFn4Ad/J+ObP7vWxYtdKd9fdM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wLMzD98WAlt7nK8PQiIlofa9BKQFr/bKZsq+Z2dZ/rUtI7Uydlj7EYdqckJcZSq2K\n\tEqgyTzk44idlG66KLl+nvaGzccXvC7FD28IXBLHDAKzSCtNGvuw2yioVRnrzpeNasH\n\toyV4rwusiYU+gE96sXjdpnCMYWVuYusQQfr4hRao=","Date":"Fri, 17 Apr 2020 14:13:22 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200417111322.GA4748@pendragon.ideasonboard.com>","References":"<20200416220558.32136-1-laurent.pinchart@ideasonboard.com>\n\t<54c9aa91-ecb8-a288-98b9-4324781d1eac@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<54c9aa91-ecb8-a288-98b9-4324781d1eac@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Return\n\tcorrect format for metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Apr 2020 11:13:36 -0000"}},{"id":4464,"web_url":"https://patchwork.libcamera.org/comment/4464/","msgid":"<3f57ce68-6e5c-ec15-0e6f-98d2204ad952@ideasonboard.com>","date":"2020-04-17T12:20:08","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Return\n\tcorrect format for metadata","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 17/04/2020 12:13, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Fri, Apr 17, 2020 at 09:31:34AM +0100, Kieran Bingham wrote:\n>> On 16/04/2020 23:05, Laurent Pinchart wrote:\n>>> When setting format on a metadata video device, the returned format\n>>> isn't updated with the actual set format due to a typo. Fix it.\n>>\n>> Did you hit this? Or identify it from the coverity scan?\n>>\n>> This is Coverity ID: 279098, if it's worth adding that to the commit\n>> message.\n> \n> What would you think of using a Reported-by tag for this ?\n> \n> Reported-by: Coverity DefectId=279098\n> Reported-by: Coverity CID=279098\n> Reported-by: Coverity Scan CID=279098\n> \n> Any preference ? CID is used in the e-mail reports, no idea what the web\n> UI uses as it still refuses to show me any data :-)\n\nThe web interface uses CID too, but as I expect that to represent\n\"Coverity ID\", Coverity CID becomes Coverity Coverity ID...\n\nBut as CID is referenced everywhere, and people are already used to\nreferencing \"PIN numbers\" ...\n\nI'm happy with either of:\n\nReported-by: Coverity CID=279098\nor\nReported-by: Coverity ID=279098\n\nDealers choice...\n\n--\nKieran\n\n\n>>> Fixes: 629e9301c518 (\"libcamera: v4l2_device: Add META support in g/s_fmt\")\n>>> Signed-off-by: Laurent Pinchart \n>>\n>> Reviewed-by: Kieran Bingham \n>>\n>>> ---\n>>> src/libcamera/v4l2_videodevice.cpp | 2 +-\n>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n>>> index 439a9c90dbf7..a959cfe65c43 100644\n>>> --- a/src/libcamera/v4l2_videodevice.cpp\n>>> +++ b/src/libcamera/v4l2_videodevice.cpp\n>>> @@ -848,7 +848,7 @@ int V4L2VideoDevice::setFormatMeta(V4L2DeviceFormat *format)\n>>> \t */\n>>> \tformat->size.width = 0;\n>>> \tformat->size.height = 0;\n>>> -\tformat->fourcc = format->fourcc;\n>>> +\tformat->fourcc = V4L2PixelFormat(pix->dataformat);\n>>> \tformat->planesCount = 1;\n>>> \tformat->planes[0].bpl = pix->buffersize;\n>>> \tformat->planes[0].size = pix->buffersize;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E321160402\n\tfor ;\n\tFri, 17 Apr 2020 14:20:11 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 520B097D;\n\tFri, 17 Apr 2020 14:20:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"e5QnBlAT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1587126011;\n\tbh=74DzRTaCZQDA7L+hDJcAdu4jEuvMx4hsW/F0aUPk6K8=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=e5QnBlATXoB/zvkqI2axwdofSYisEarjQWCCVu/vPu1AqoLMq/e190SOL5l5duMV6\n\tY46f/1Gqkp3hrjHWo2jsoh4GivwzcxewLk7MUe8Co96koA+XUAwVjxVkFHJs3NssyF\n\tOi1aN3LBZdRBJNU43uMmHJiPWTpvtq5Pln6GY6RA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200416220558.32136-1-laurent.pinchart@ideasonboard.com>\n\t<54c9aa91-ecb8-a288-98b9-4324781d1eac@ideasonboard.com>\n\t<20200417111322.GA4748@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3f57ce68-6e5c-ec15-0e6f-98d2204ad952@ideasonboard.com>","Date":"Fri, 17 Apr 2020 13:20:08 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200417111322.GA4748@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Return\n\tcorrect format for metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Apr 2020 12:20:12 -0000"}}]